annotate lib/unistr/u-cpy-alloc.h @ 40212:8da9577294da

unistr/*, uniconv/*: Fix undefined behaviour. Reported by Jeffrey Walton <noloader@gmail.com>. * lib/unistr/u-cpy.h (FUNC): Don't invoke memcpy with a zero size. * lib/unistr/u-cpy-alloc.h (FUNC): Likewise. * lib/uniconv/u8-conv-from-enc.c (u8_conv_from_encoding): Likewise. * lib/uniconv/u8-conv-to-enc.c (u8_conv_to_encoding): Likewise.
author Bruno Haible <bruno@clisp.org>
date Sat, 09 Mar 2019 00:01:47 +0100
parents b06060465f09
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
1 /* Copy piece of UTF-8/UTF-16/UTF-32 string.
40057
b06060465f09 maint: Run 'make update-copyright'
Paul Eggert <eggert@cs.ucla.edu>
parents: 19484
diff changeset
2 Copyright (C) 1999, 2002, 2006-2007, 2009-2019 Free Software Foundation,
12559
c2cbabec01dd update nearly all FSF copyright year lists to include 2010
Jim Meyering <meyering@redhat.com>
parents: 12421
diff changeset
3 Inc.
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
4 Written by Bruno Haible <bruno@clisp.org>, 2002.
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
5
9307
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
6 This program is free software: you can redistribute it and/or modify it
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
7 under the terms of the GNU Lesser General Public License as published
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
8 by the Free Software Foundation; either version 3 of the License, or
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
9 (at your option) any later version.
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
10
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
11 This program is distributed in the hope that it will be useful,
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
12 but WITHOUT ANY WARRANTY; without even the implied warranty of
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
9307
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
14 Lesser General Public License for more details.
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
15
9307
ad8a75a45dc9 Change copyright notice from LGPLv2.0+ to LGPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 8456
diff changeset
16 You should have received a copy of the GNU Lesser General Public License
19190
9759915b2aca all: prefer https: URLs
Paul Eggert <eggert@cs.ucla.edu>
parents: 18626
diff changeset
17 along with this program. If not, see <https://www.gnu.org/licenses/>. */
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
18
8456
2e7713869657 Include <stdlib>, for malloc().
Bruno Haible <bruno@clisp.org>
parents: 7817
diff changeset
19 #include <stdlib.h>
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
20 #include <string.h>
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
21
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
22 UNIT *
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
23 FUNC (const UNIT *s, size_t n)
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
24 {
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
25 UNIT *dest;
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
26
11508
62fc220f4e95 Avoid test failures on AIX and OSF/1.
Bruno Haible <bruno@clisp.org>
parents: 9307
diff changeset
27 dest = (UNIT *) malloc (n > 0 ? n * sizeof (UNIT) : 1);
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
28 if (dest != NULL)
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
29 {
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
30 #if 0
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
31 UNIT *destptr = dest;
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
32
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
33 for (; n > 0; n--)
12421
e8d2c6fc33ad Use spaces for indentation, not tabs.
Bruno Haible <bruno@clisp.org>
parents: 11508
diff changeset
34 *destptr++ = *s++;
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
35 #else
40212
8da9577294da unistr/*, uniconv/*: Fix undefined behaviour.
Bruno Haible <bruno@clisp.org>
parents: 40057
diff changeset
36 if (n > 0)
8da9577294da unistr/*, uniconv/*: Fix undefined behaviour.
Bruno Haible <bruno@clisp.org>
parents: 40057
diff changeset
37 memcpy ((char *) dest, (const char *) s, n * sizeof (UNIT));
7817
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
38 #endif
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
39 }
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
40 return dest;
133ad5cc2a9b New modules 'unistr/u8-cpy-alloc', 'unistr/u16-cpy-alloc', 'unistr/u32-cpy-alloc'.
Bruno Haible <bruno@clisp.org>
parents:
diff changeset
41 }