Mercurial > gnulib
annotate top/maint.mk @ 11853:97a383c7cec4
maint.mk: _header_without_use: fix a quoting bug and remove a bash'ism
* top/maint.mk (_header_without_use): Use "\\\\", not "\\" in the sed
expression that converts "." in a file name to "\." in the resulting
regexp. Start with a dummy statement, so that prior shell variable
definitions are expanded portably. Reported by Simon Josefsson.
author | Jim Meyering <meyering@redhat.com> |
---|---|
date | Thu, 20 Aug 2009 11:04:20 +0200 |
parents | 5dd8e8cf05db |
children | 2cd9af4a1b6a |
rev | line source |
---|---|
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1 # -*-Makefile-*- |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
2 # This Makefile fragment tries to be general-purpose enough to be |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
3 # used by many projects via the gnulib maintainer-makefile module. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
4 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
5 ## Copyright (C) 2001-2009 Free Software Foundation, Inc. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
6 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
7 ## This program is free software: you can redistribute it and/or modify |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
8 ## it under the terms of the GNU General Public License as published by |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
9 ## the Free Software Foundation, either version 3 of the License, or |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
10 ## (at your option) any later version. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
11 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
12 ## This program is distributed in the hope that it will be useful, |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
13 ## but WITHOUT ANY WARRANTY; without even the implied warranty of |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
14 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
15 ## GNU General Public License for more details. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
16 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
17 ## You should have received a copy of the GNU General Public License |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
18 ## along with this program. If not, see <http://www.gnu.org/licenses/>. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
19 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
20 # This is reported not to work with make-3.79.1 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
21 # ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST)) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
22 ME := maint.mk |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
23 |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
24 # Override this in cfg.mk if you use a non-standard build-aux directory. |
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
25 build_aux ?= $(srcdir)/build-aux |
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
26 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
27 # Do not save the original name or timestamp in the .tar.gz file. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
28 # Use --rsyncable if available. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
29 gzip_rsyncable := \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
30 $(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo --rsyncable) |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
31 GZIP_ENV = '--no-name --best $(gzip_rsyncable)' |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
32 |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
33 # cfg.mk must define the gpg_key_ID used by this package. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
34 GIT = git |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
35 VC = $(GIT) |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
36 VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)' |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
37 |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
38 VC_LIST = $(build_aux)/vc-list-files -C $(srcdir) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
39 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
40 VC_LIST_EXCEPT = \ |
11847
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
41 $(VC_LIST) | if test -f $(srcdir)/.x-$@; then grep -vEf $(srcdir)/.x-$@; \ |
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
42 else grep -Ev "$${VC_LIST_EXCEPT_DEFAULT-ChangeLog}"; fi |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
43 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
44 ifeq ($(origin prev_version_file), undefined) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
45 prev_version_file = $(srcdir)/.prev-version |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
46 endif |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
47 |
11736
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
48 PREV_VERSION := $(shell cat $(prev_version_file) 2>/dev/null) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
49 VERSION_REGEXP = $(subst .,\.,$(VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
50 PREV_VERSION_REGEXP = $(subst .,\.,$(PREV_VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
51 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
52 ifeq ($(VC),$(GIT)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
53 this-vc-tag = v$(VERSION) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
54 this-vc-tag-regexp = v$(VERSION_REGEXP) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
55 else |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
56 tag-package = $(shell echo "$(PACKAGE)" | tr '[:lower:]' '[:upper:]') |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
57 tag-this-version = $(subst .,_,$(VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
58 this-vc-tag = $(tag-package)-$(tag-this-version) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
59 this-vc-tag-regexp = $(this-vc-tag) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
60 endif |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
61 my_distdir = $(PACKAGE)-$(VERSION) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
62 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
63 # Old releases are stored here. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
64 release_archive_dir ?= ../release |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
65 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
66 # Prevent programs like 'sort' from considering distinct strings to be equal. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
67 # Doing it here saves us from having to set LC_ALL elsewhere in this file. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
68 export LC_ALL = C |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
69 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
70 ## --------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
71 ## Sanity checks. ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
72 ## --------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
73 |
11736
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
74 _cfg_mk := $(shell test -f $(srcdir)/cfg.mk && echo '$(srcdir)/cfg.mk') |
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
75 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
76 # Collect the names of rules starting with `sc_'. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
77 syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \ |
11736
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
78 $(srcdir)/$(ME) $(_cfg_mk)) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
79 .PHONY: $(syntax-check-rules) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
80 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
81 local-checks-available = \ |
11498
4eb7918a17d0
top/maint.mk (makefile-check): Renamed to sc_makefile_check for consistency.
Simon Josefsson <simon@josefsson.org>
parents:
11495
diff
changeset
|
82 $(syntax-check-rules) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
83 .PHONY: $(local-checks-available) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
84 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
85 # Arrange to print the name of each syntax-checking rule just before running it. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
86 $(syntax-check-rules): %: %.m |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
87 $(patsubst %, %.m, $(syntax-check-rules)): |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
88 @echo $(patsubst sc_%.m, %, $@) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
89 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
90 local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
91 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
92 syntax-check: $(local-check) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
93 # @grep -nE '# *include <(limits|std(def|arg|bool))\.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
94 # $$(find -type f -name '*.[chly]') && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
95 # { echo '$(ME): found conditional include' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
96 # exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
97 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
98 # grep -nE '^# *include <(string|stdlib)\.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
99 # $(srcdir)/{lib,src}/*.[chy] && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
100 # { echo '$(ME): FIXME' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
101 # exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
102 # FIXME: don't allow `#include .strings\.h' anywhere |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
103 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
104 # By default, _prohibit_regexp does not ignore case. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
105 export ignore_case = |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
106 _ignore_case = $$(test -n "$$ignore_case" && echo -i || :) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
107 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
108 # There are many rules below that prohibit constructs in this package. |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
109 # If the offending construct can be matched with a grep-E-style regexp, |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
110 # use this macro. The shell variables "re" and "msg" must be defined. |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
111 define _prohibit_regexp |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
112 dummy=; : so we do not need a semicolon before each use; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
113 test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
114 test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
115 grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) && \ |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
116 { echo '$(ME): '"$$msg" 1>&2; exit 1; } || : |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
117 endef |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
118 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
119 sc_avoid_if_before_free: |
11564
ab18b3d5e34a
* top/maint.mk: Adjust backslash alignment.
Jim Meyering <meyering@redhat.com>
parents:
11563
diff
changeset
|
120 @$(build_aux)/useless-if-before-free \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
121 $(useless_free_options) \ |
11518
956eb61203ab
top/maint.mk (sc_avoid_if_before_free): Except useless-if-before-free script.
Simon Josefsson <simon@josefsson.org>
parents:
11517
diff
changeset
|
122 $$($(VC_LIST_EXCEPT) | grep -v useless-if-before-free) && \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
123 { echo '$(ME): found useless "if" before "free" above' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
124 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
125 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
126 sc_cast_of_argument_to_free: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
127 @re='\<free *\( *\(' msg='don'\''t cast free argument' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
128 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
129 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
130 sc_cast_of_x_alloc_return_value: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
131 @re='\*\) *x(m|c|re)alloc\>' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
132 msg='don'\''t cast x*alloc return value' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
133 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
134 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
135 sc_cast_of_alloca_return_value: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
136 @re='\*\) *alloca\>' msg='don'\''t cast alloca return value' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
137 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
138 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
139 sc_space_tab: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
140 @re='[ ] ' msg='found SPACE-TAB sequence; remove the SPACE' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
141 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
142 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
143 # Don't use *scanf or the old ato* functions in `real' code. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
144 # They provide no error checking mechanism. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
145 # Instead, use strto* functions. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
146 sc_prohibit_atoi_atof: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
147 @re='\<([fs]?scanf|ato([filq]|ll)) *\(' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
148 msg='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
149 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
150 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
151 # Use STREQ rather than comparing strcmp == 0, or != 0. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
152 sc_prohibit_strcmp: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
153 @grep -nE '! *str''cmp *\(|\<str''cmp *\([^)]+\) *==' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
154 $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
155 | grep -vE ':# *define STREQ\(' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
156 { echo '$(ME): use STREQ in place of the above uses of str''cmp' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
157 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
158 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
159 # Using EXIT_SUCCESS as the first argument to error is misleading, |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
160 # since when that parameter is 0, error does not exit. Use `0' instead. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
161 sc_error_exit_success: |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
162 @grep -nE 'error \(EXIT_SUCCESS,' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
163 $$($(VC_LIST_EXCEPT) | grep -E '\.[chly]$$') && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
164 { echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
165 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
166 # `FATAL:' should be fully upper-cased in error messages |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
167 # `WARNING:' should be fully upper-cased, or fully lower-cased |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
168 sc_error_message_warn_fatal: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
169 @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
170 | grep -E '"Warning|"Fatal|"fatal' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
171 { echo '$(ME): use FATAL, WARNING or warning' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
172 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
173 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
174 # Error messages should not start with a capital letter |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
175 sc_error_message_uppercase: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
176 @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
177 | grep -E '"[A-Z]' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
178 | grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
179 { echo '$(ME): found capitalized error message' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
180 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
181 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
182 # Error messages should not end with a period |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
183 sc_error_message_period: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
184 @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
185 | grep -E '[^."]\."' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
186 { echo '$(ME): found error message ending in period' 1>&2; \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
187 exit 1; } || : |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
188 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
189 sc_file_system: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
190 @re=file''system ignore_case=1 \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
191 msg='found use of "file''system"; spell it "file system"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
192 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
193 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
194 # Don't use cpp tests of this symbol. All code assumes config.h is included. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
195 sc_prohibit_have_config_h: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
196 @grep -n '^# *if.*HAVE''_CONFIG_H' $$($(VC_LIST_EXCEPT)) && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
197 { echo '$(ME): found use of HAVE''_CONFIG_H; remove' \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
198 1>&2; exit 1; } || : |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
199 |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
200 # Nearly all .c files must include <config.h>. However, we also permit this |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
201 # via inclusion of a package-specific header, if cfg.mk specified one. |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
202 # config_h_header must be suitable for grep -E. |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
203 config_h_header ?= <config\.h> |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
204 sc_require_config_h: |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
205 @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
206 grep -EL '^# *include $(config_h_header)' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
207 $$($(VC_LIST_EXCEPT) | grep '\.c$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
208 | grep . && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
209 { echo '$(ME): the above files do not include <config.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
210 1>&2; exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
211 else :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
212 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
213 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
214 # You must include <config.h> before including any other header file. |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
215 # This can possibly be via a package-specific header, if given by cfg.mk. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
216 sc_require_config_h_first: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
217 @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
218 fail=0; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
219 for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
220 grep '^# *include\>' $$i | sed 1q \ |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
221 | grep -E '^# *include $(config_h_header)' > /dev/null \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
222 || { echo $$i; fail=1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
223 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
224 test $$fail = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
225 { echo '$(ME): the above files include some other header' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
226 'before <config.h>' 1>&2; exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
227 else :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
228 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
229 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
230 sc_prohibit_HAVE_MBRTOWC: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
231 @re='\bHAVE_MBRTOWC\b' msg="do not use $$re; it is always defined" \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
232 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
233 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
234 # To use this "command" macro, you must first define two shell variables: |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
235 # h: the header, enclosed in <> or "" |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
236 # re: a regular expression that matches IFF something provided by $h is used. |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
237 define _header_without_use |
11853
97a383c7cec4
maint.mk: _header_without_use: fix a quoting bug and remove a bash'ism
Jim Meyering <meyering@redhat.com>
parents:
11847
diff
changeset
|
238 dummy=; : so we do not need a semicolon before each use; \ |
97a383c7cec4
maint.mk: _header_without_use: fix a quoting bug and remove a bash'ism
Jim Meyering <meyering@redhat.com>
parents:
11847
diff
changeset
|
239 h_esc=`echo "$$h"|sed 's/\./\\\\./g'`; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
240 if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
241 files=$$(grep -l '^# *include '"$$h_esc" \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
242 $$($(VC_LIST_EXCEPT) | grep '\.c$$')) && \ |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
243 grep -LE "$$re" $$files | grep . && \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
244 { echo "$(ME): the above files include $$h but don't use it" \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
245 1>&2; exit 1; } || :; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
246 else :; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
247 fi |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
248 endef |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
249 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
250 # Prohibit the inclusion of assert.h without an actual use of assert. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
251 sc_prohibit_assert_without_use: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
252 @h='<assert.h>' re='\<assert *\(' $(_header_without_use) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
253 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
254 # Prohibit the inclusion of getopt.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
255 sc_prohibit_getopt_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
256 @h='<getopt.h>' re='\<getopt(_long)? *\(' $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
257 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
258 # Don't include quotearg.h unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
259 sc_prohibit_quotearg_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
260 @h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
261 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
262 # Don't include quote.h unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
263 sc_prohibit_quote_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
264 @h='"quote.h"' re='\<quote(_n)? *\(' $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
265 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
266 # Don't include this header unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
267 sc_prohibit_long_options_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
268 @h='"long-options.h"' re='\<parse_long_options *\(' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
269 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
270 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
271 # Don't include this header unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
272 sc_prohibit_inttostr_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
273 @h='"inttostr.h"' re='\<(off|[iu]max|uint)tostr *\(' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
274 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
275 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
276 # Don't include this header unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
277 sc_prohibit_error_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
278 @h='"error.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
279 re='\<error(_at_line|_print_progname|_one_per_line|_message_count)? *\('\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
280 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
281 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
282 sc_prohibit_safe_read_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
283 @h='"safe-read.h"' re='(\<SAFE_READ_ERROR\>|\<safe_read *\()' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
284 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
285 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
286 sc_prohibit_argmatch_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
287 @h='"argmatch.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
288 re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid) *\()' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
289 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
290 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
291 sc_prohibit_root_dev_ino_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
292 @h='"root-dev-ino.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
293 re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
294 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
295 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
296 # Prohibit the inclusion of c-ctype.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
297 ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
298 |isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
299 sc_prohibit_c_ctype_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
300 @h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
301 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
302 _empty = |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
303 _sp = $(_empty) $(_empty) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
304 # The following list was generated by running: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
305 # man signal.h|col -b|perl -ne '/bsd_signal.*;/.../sigwaitinfo.*;/ and print' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
306 # | perl -lne '/^\s+(?:int|void).*?(\w+).*/ and print $1' | fmt |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
307 _sig_functions = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
308 bsd_signal kill killpg pthread_kill pthread_sigmask raise sigaction \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
309 sigaddset sigaltstack sigdelset sigemptyset sigfillset sighold sigignore \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
310 siginterrupt sigismember signal sigpause sigpending sigprocmask sigqueue \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
311 sigrelse sigset sigsuspend sigtimedwait sigwait sigwaitinfo |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
312 _sig_function_re = $(subst $(_sp),|,$(strip $(_sig_functions))) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
313 # The following were extracted from "man signal.h" manually. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
314 _sig_types_and_consts = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
315 MINSIGSTKSZ SA_NOCLDSTOP SA_NOCLDWAIT SA_NODEFER SA_ONSTACK \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
316 SA_RESETHAND SA_RESTART SA_SIGINFO SIGEV_NONE SIGEV_SIGNAL \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
317 SIGEV_THREAD SIGSTKSZ SIG_BLOCK SIG_SETMASK SIG_UNBLOCK SS_DISABLE \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
318 SS_ONSTACK mcontext_t pid_t sig_atomic_t sigevent siginfo_t sigset_t \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
319 sigstack sigval stack_t ucontext_t |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
320 # generated via this: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
321 # perl -lne '/^#ifdef (SIG\w+)/ and print $1' lib/sig2str.c|sort -u|fmt -70 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
322 _sig_names = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
323 SIGABRT SIGALRM SIGALRM1 SIGBUS SIGCANCEL SIGCHLD SIGCLD SIGCONT \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
324 SIGDANGER SIGDIL SIGEMT SIGFPE SIGFREEZE SIGGRANT SIGHUP SIGILL \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
325 SIGINFO SIGINT SIGIO SIGIOT SIGKAP SIGKILL SIGKILLTHR SIGLOST SIGLWP \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
326 SIGMIGRATE SIGMSG SIGPHONE SIGPIPE SIGPOLL SIGPRE SIGPROF SIGPWR \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
327 SIGQUIT SIGRETRACT SIGSAK SIGSEGV SIGSOUND SIGSTKFLT SIGSTOP SIGSYS \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
328 SIGTERM SIGTHAW SIGTRAP SIGTSTP SIGTTIN SIGTTOU SIGURG SIGUSR1 \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
329 SIGUSR2 SIGVIRT SIGVTALRM SIGWAITING SIGWINCH SIGWIND SIGWINDOW \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
330 SIGXCPU SIGXFSZ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
331 _sig_syms_re = $(subst $(_sp),|,$(strip $(_sig_names) $(_sig_types_and_consts))) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
332 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
333 # Prohibit the inclusion of signal.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
334 sc_prohibit_signal_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
335 @h='<signal.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
336 re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
337 $(_header_without_use) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
338 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
339 sc_obsolete_symbols: |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
340 @re='\<(HAVE''_FCNTL_H|O''_NDELAY)\>' \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
341 msg='do not use HAVE''_FCNTL_H or O'_NDELAY \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
342 $(_prohibit_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
343 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
344 # FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
345 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
346 # Each nonempty ChangeLog line must start with a year number, or a TAB. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
347 sc_changelog: |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
348 @if $(VC_LIST_EXCEPT) | grep -l '^ChangeLog$$' >/dev/null; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
349 grep -n '^[^12 ]' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
350 $$($(VC_LIST_EXCEPT) | grep '^ChangeLog$$') && \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
351 { echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
352 exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
353 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
354 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
355 # Ensure that each .c file containing a "main" function also |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
356 # calls set_program_name. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
357 sc_program_name: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
358 @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
359 files=$$(grep -l '^main *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$')); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
360 grep -LE 'set_program_name *\(m?argv\[0\]\);' $$files \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
361 | grep . && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
362 { echo '$(ME): the above files do not call set_program_name' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
363 1>&2; exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
364 else :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
365 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
366 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
367 # Require that the final line of each test-lib.sh-using test be this one: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
368 # Exit $fail |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
369 # Note: this test requires GNU grep's --label= option. |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
370 Exit_witness_file ?= tests/test-lib.sh |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
371 Exit_base := $(notdir $(Exit_witness_file)) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
372 sc_require_test_exit_idiom: |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
373 @if test -f $(srcdir)/$(Exit_witness_file); then \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
374 die=0; \ |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
375 for i in $$(grep -l -F 'srcdir/$(Exit_base)' \ |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
376 $$($(VC_LIST) tests)); do \ |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
377 tail -n1 $$i | grep '^Exit .' > /dev/null \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
378 && : || { die=1; echo $$i; } \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
379 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
380 test $$die = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
381 { echo 1>&2 '$(ME): the final line in each of the above is not:'; \ |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
382 echo 1>&2 'Exit something'; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
383 exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
384 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
385 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
386 sc_the_the: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
387 @re='\<the ''the\>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
388 ignore_case=1 msg='found use of "the ''the";' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
389 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
390 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
391 sc_trailing_blank: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
392 @re='[ ]$$' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
393 msg='found trailing blank(s)' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
394 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
395 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
396 # Match lines like the following, but where there is only one space |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
397 # between the options and the description: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
398 # -D, --all-repeated[=delimit-method] print all duplicate lines\n |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
399 longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)? |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
400 sc_two_space_separator_in_usage: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
401 @grep -nE '^ *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
402 $$($(VC_LIST_EXCEPT)) && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
403 { echo "$(ME): help2man requires at least two spaces between"; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
404 echo "$(ME): an option and its description"; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
405 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
406 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
407 # Look for diagnostics that aren't marked for translation. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
408 # This won't find any for which error's format string is on a separate line. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
409 sc_unmarked_diagnostics: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
410 @grep -nE \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
411 '\<error \([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
412 | grep -v '_''(' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
413 { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
414 exit 1; } || : |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
415 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
416 # Avoid useless parentheses like those in this example: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
417 # #if defined (SYMBOL) || defined (SYM2) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
418 sc_useless_cpp_parens: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
419 @grep -n '^# *if .*defined *(' $$($(VC_LIST_EXCEPT)) && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
420 { echo '$(ME): found useless parentheses in cpp directive' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
421 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
422 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
423 # Require the latest GPL. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
424 sc_GPL_version: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
425 @re='either ''version [^3]' msg='GPL vN, N!=3' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
426 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
427 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
428 cvs_keywords = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
429 Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
430 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
431 sc_prohibit_cvs_keyword: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
432 @re='\$$($(cvs_keywords))\$$' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
433 msg='do not use CVS keyword expansion' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
434 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
435 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
436 # Make sure we don't use st_blocks. Use ST_NBLOCKS instead. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
437 # This is a bit of a kludge, since it prevents use of the string |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
438 # even in comments, but for now it does the job with no false positives. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
439 sc_prohibit_stat_st_blocks: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
440 @re='[.>]st_blocks' msg='do not use st_blocks; use ST_NBLOCKS' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
441 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
442 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
443 # Make sure we don't define any S_IS* macros in src/*.c files. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
444 # They're already defined via gnulib's sys/stat.h replacement. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
445 sc_prohibit_S_IS_definition: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
446 @re='^ *# *define *S_IS' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
447 msg='do not define S_IS* macros; include <sys/stat.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
448 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
449 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
450 # Each program that uses proper_name_utf8 must link with |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
451 # one of the ICONV libraries. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
452 sc_proper_name_utf8_requires_ICONV: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
453 @progs=$$(grep -l 'proper_name_utf8 ''("' $$($(VC_LIST_EXCEPT)));\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
454 if test "x$$progs" != x; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
455 fail=0; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
456 for p in $$progs; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
457 dir=$$(dirname "$$p"); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
458 base=$$(basename "$$p" .c); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
459 grep "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
460 || { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
461 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
462 test $$fail = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
463 { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
464 exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
465 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
466 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
467 # Warn about "c0nst struct Foo const foo[]", |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
468 # but not about "char const *const foo" or "#define const const". |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
469 sc_redundant_const: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
470 @re='\bconst\b[[:space:][:alnum:]]{2,}\bconst\b' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
471 msg='redundant "const" in declarations' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
472 $(_prohibit_regexp) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
473 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
474 sc_const_long_option: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
475 @grep '^ *static.*struct option ' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
476 | grep -Ev 'const struct option|struct option const' && { \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
477 echo 1>&2 '$(ME): add "const" to the above declarations'; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
478 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
479 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
480 NEWS_hash = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
481 $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
482 $(srcdir)/NEWS \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
483 | grep -v '^Copyright .*Free Software' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
484 | md5sum - \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
485 | sed 's/ .*//') |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
486 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
487 # Ensure that we don't accidentally insert an entry into an old NEWS block. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
488 sc_immutable_NEWS: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
489 @if test -f $(srcdir)/NEWS; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
490 test "$(NEWS_hash)" = '$(old_NEWS_hash)' && : || \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
491 { echo '$(ME): you have modified old NEWS' 1>&2; exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
492 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
493 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
494 # Update the hash stored above. Do this after each release and |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
495 # for any corrections to old entries. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
496 update-NEWS-hash: NEWS |
11750
246d2e2f523d
maint.mk: relax update-NEWS-hash to accept more syntax
Peter Simons <simons@cryp.to>
parents:
11736
diff
changeset
|
497 perl -pi -e 's/^(old_NEWS_hash[ \t]+:?=[ \t]+).*/$${1}'"$(NEWS_hash)/" \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
498 $(srcdir)/cfg.mk |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
499 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
500 # Ensure that we use only the standard $(VAR) notation, |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
501 # not @...@ in Makefile.am, now that we can rely on automake |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
502 # to emit a definition for each substituted variable. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
503 # We use perl rather than "grep -nE ..." to exempt a single |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
504 # use of an @...@-delimited variable name in src/Makefile.am. |
11498
4eb7918a17d0
top/maint.mk (makefile-check): Renamed to sc_makefile_check for consistency.
Simon Josefsson <simon@josefsson.org>
parents:
11495
diff
changeset
|
505 sc_makefile_check: |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
506 @perl -ne '/\@[A-Z_0-9]+\@/ && !/^cu_install_program =/' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
507 -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
508 $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
509 && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
510 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
511 news-date-check: NEWS |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
512 today=`date +%Y-%m-%d`; \ |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
513 if head $(srcdir)/NEWS | grep '^\*.* $(VERSION_REGEXP) ('$$today')' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
514 >/dev/null; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
515 :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
516 else \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
517 echo "version or today's date is not in NEWS" 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
518 exit 1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
519 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
520 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
521 sc_makefile_TAB_only_indentation: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
522 @grep -nE '^ [ ]{8}' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
523 $$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
524 && { echo '$(ME): found TAB-8-space indentation' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
525 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
526 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
527 sc_m4_quote_check: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
528 @grep -nE '(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
529 $$($(VC_LIST_EXCEPT) | grep -E '(^configure\.ac|\.m4)$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
530 && { echo '$(ME): quote the first arg to AC_DEF*' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
531 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
532 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
533 fix_po_file_diag = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
534 'you have changed the set of files with translatable diagnostics;\n\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
535 apply the above patch\n' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
536 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
537 # Verify that all source files using _() are listed in po/POTFILES.in. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
538 po_file = po/POTFILES.in |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
539 sc_po_check: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
540 @if test -f $(po_file); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
541 grep -E -v '^(#|$$)' $(po_file) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
542 | grep -v '^src/false\.c$$' | sort > $@-1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
543 files=; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
544 for file in $$($(VC_LIST_EXCEPT)) lib/*.[ch]; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
545 test -r $$file || continue; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
546 case $$file in \ |
11710
e59c94826772
maint.mk: don't look for translatable strings in *.m4 or *.mk
Jim Meyering <meyering@redhat.com>
parents:
11646
diff
changeset
|
547 *.m4|*.mk) continue ;; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
548 *.?|*.??) ;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
549 *) continue;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
550 esac; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
551 case $$file in \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
552 *.[ch]) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
553 base=`expr " $$file" : ' \(.*\)\..'`; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
554 { test -f $$base.l || test -f $$base.y; } && continue;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
555 esac; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
556 files="$$files $$file"; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
557 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
558 grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
559 | sort -u > $@-2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
560 diff -u -L $(po_file) -L $(po_file) $@-1 $@-2 \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
561 || { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
562 rm -f $@-1 $@-2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
563 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
564 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
565 # Sometimes it is useful to change the PATH environment variable |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
566 # in Makefiles. When doing so, it's better not to use the Unix-centric |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
567 # path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
568 msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
569 sc_makefile_path_separator_check: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
570 @grep -nE 'PATH[=].*:' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
571 $$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
572 && { echo $(msg) 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
573 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
574 # Check that `make alpha' will not fail at the end of the process. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
575 writable-files: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
576 if test -d $(release_archive_dir); then :; else \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
577 for file in $(distdir).tar.gz \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
578 $(release_archive_dir)/$(distdir).tar.gz; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
579 test -e $$file || continue; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
580 test -w $$file \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
581 || { echo ERROR: $$file is not writable; fail=1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
582 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
583 test "$$fail" && exit 1 || : ; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
584 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
585 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
586 v_etc_file = lib/version-etc.c |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
587 sample-test = tests/sample-test |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
588 texi = doc/$(PACKAGE).texi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
589 # Make sure that the copyright date in $(v_etc_file) is up to date. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
590 # Do the same for the $(sample-test) and the main doc/.texi file. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
591 sc_copyright_check: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
592 @if test -f $(v_etc_file); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
593 grep 'enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' $(v_etc_file) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
594 >/dev/null \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
595 || { echo 'out of date copyright in $(v_etc_file); update it' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
596 exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
597 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
598 @if test -f $(sample-test); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
599 grep '# Copyright (C) '$$(date +%Y)' Free' $(sample-test) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
600 >/dev/null \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
601 || { echo 'out of date copyright in $(sample-test); update it' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
602 exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
603 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
604 @if test -f $(texi); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
605 grep 'Copyright @copyright{} .*'$$(date +%Y)' Free' $(texi) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
606 >/dev/null \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
607 || { echo 'out of date copyright in $(texi); update it' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
608 exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
609 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
610 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
611 vc-diff-check: |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
612 (unset CDPATH; cd $(srcdir) && $(VC) diff) > vc-diffs || : |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
613 if test -s vc-diffs; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
614 cat vc-diffs; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
615 echo "Some files are locally modified:" 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
616 exit 1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
617 else \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
618 rm vc-diffs; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
619 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
620 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
621 cvs-check: vc-diff-check |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
622 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
623 ALL_RECURSIVE_TARGETS += maintainer-distcheck |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
624 maintainer-distcheck: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
625 $(MAKE) distcheck |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
626 $(MAKE) taint-distcheck |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
627 $(MAKE) my-distcheck |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
628 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
629 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
630 # Don't make a distribution if checks fail. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
631 # Also, make sure the NEWS file is up-to-date. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
632 ALL_RECURSIVE_TARGETS += vc-dist |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
633 vc-dist: $(local-check) cvs-check maintainer-distcheck |
11733
65c13bc94058
maint.mk: invoke "make dist" with a working value of XZ_OPT
Jim Meyering <meyering@redhat.com>
parents:
11710
diff
changeset
|
634 XZ_OPT=9ev $(MAKE) dist |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
635 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
636 # Use this to make sure we don't run these programs when building |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
637 # from a virgin tgz file, below. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
638 null_AM_MAKEFLAGS = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
639 ACLOCAL=false \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
640 AUTOCONF=false \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
641 AUTOMAKE=false \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
642 AUTOHEADER=false \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
643 MAKEINFO=false |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
644 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
645 built_programs = $$(cd src && MAKEFLAGS= $(MAKE) -s built_programs.list) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
646 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
647 rel-files = $(DIST_ARCHIVES) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
648 |
11575
cfe435cf936c
maint.mk: allow gnulib_dir in VPATH build
Eric Blake <ebb9@byu.net>
parents:
11573
diff
changeset
|
649 gnulib_dir ?= $(srcdir)/gnulib |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
650 gnulib-version = $$(cd $(gnulib_dir) && git describe) |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
651 bootstrap-tools ?= autoconf,automake,gnulib |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
652 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
653 announcement: NEWS ChangeLog $(rel-files) |
11564
ab18b3d5e34a
* top/maint.mk: Adjust backslash alignment.
Jim Meyering <meyering@redhat.com>
parents:
11563
diff
changeset
|
654 @$(build_aux)/announce-gen \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
655 --release-type=$(RELEASE_TYPE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
656 --package=$(PACKAGE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
657 --prev=$(PREV_VERSION) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
658 --curr=$(VERSION) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
659 --gpg-key-id=$(gpg_key_ID) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
660 --news=NEWS \ |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
661 --bootstrap-tools=$(bootstrap-tools) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
662 --gnulib-version=$(gnulib-version) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
663 --no-print-checksums \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
664 $(addprefix --url-dir=, $(url_dir_list)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
665 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
666 ## ---------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
667 ## Updating files. ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
668 ## ---------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
669 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
670 ftp-gnu = ftp://ftp.gnu.org/gnu |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
671 www-gnu = http://www.gnu.org |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
672 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
673 emit_upload_commands: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
674 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
675 @echo ===================================== |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
676 @echo "$(build_aux)/gnupload $(GNUPLOADFLAGS) \\" |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
677 @echo " --to $(gnu_rel_host):$(PACKAGE) \\" |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
678 @echo " $(rel-files)" |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
679 @echo '# send the /tmp/announcement e-mail' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
680 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
681 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
682 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
683 noteworthy = * Noteworthy changes in release ?.? (????-??-??) [?] |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
684 define emit-commit-log |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
685 printf '%s\n' 'post-release administrivia' '' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
686 '* NEWS: Add header line for next release.' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
687 '* .prev-version: Record previous version.' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
688 '* cfg.mk (old_NEWS_hash): Auto-update.' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
689 endef |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
690 |
11534
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
691 .PHONY: no-submodule-changes |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
692 no-submodule-changes: |
11547
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
693 if test -d $(srcdir)/.git; then \ |
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
694 diff=$$(cd $(srcdir) && git submodule -q foreach \ |
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
695 git diff-index --name-only HEAD) \ |
11534
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
696 || exit 1; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
697 case $$diff in '') ;; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
698 *) echo '$(ME): submodule files are locally modified:'; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
699 echo "$$diff"; exit 1;; esac; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
700 else \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
701 : ; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
702 fi |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
703 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
704 .PHONY: alpha beta major |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
705 ALL_RECURSIVE_TARGETS += alpha beta major |
11534
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
706 alpha beta major: $(local-check) writable-files no-submodule-changes |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
707 test $@ = major \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
708 && { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
709 || { echo "invalid version string: $(VERSION)" 1>&2; exit 1;};}\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
710 || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
711 $(MAKE) vc-dist |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
712 $(MAKE) news-date-check |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
713 $(MAKE) -s announcement RELEASE_TYPE=$@ > /tmp/announce-$(my_distdir) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
714 if test -d $(release_archive_dir); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
715 ln $(rel-files) $(release_archive_dir); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
716 chmod a-w $(rel-files); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
717 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
718 $(MAKE) -s emit_upload_commands RELEASE_TYPE=$@ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
719 echo $(VERSION) > $(prev_version_file) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
720 $(MAKE) update-NEWS-hash |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
721 perl -pi -e '$$. == 3 and print "$(noteworthy)\n\n\n"' NEWS |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
722 $(emit-commit-log) > .ci-msg |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
723 $(VC) commit -F .ci-msg -a |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
724 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
725 .PHONY: web-manual |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
726 web-manual: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
727 @test -z "$(manual_title)" \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
728 && { echo define manual_title in cfg.mk 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
729 @cd '$(srcdir)/doc'; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
730 $(SHELL) ../build-aux/gendocs.sh -o '$(abs_builddir)/doc/manual' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
731 --email $(PACKAGE_BUGREPORT) $(PACKAGE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
732 "$(PACKAGE_NAME) - $(manual_title)" |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
733 @echo " *** Upload the doc/manual directory to web-cvs." |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
734 |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
735 # Code Coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
736 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
737 init-coverage: |
11406
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
738 $(MAKE) $(AM_MAKEFLAGS) clean |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
739 lcov --directory . --zerocounters |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
740 |
10757
0affc3e42aa9
maint.mk: Use --coverage.
Simon Josefsson <simon@josefsson.org>
parents:
10738
diff
changeset
|
741 COVERAGE_CCOPTS ?= "-g --coverage" |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
742 COVERAGE_OUT ?= doc/coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
743 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
744 build-coverage: |
11406
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
745 $(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS) |
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
746 $(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS) check |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
747 mkdir -p $(COVERAGE_OUT) |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
748 lcov --directory . --output-file $(COVERAGE_OUT)/$(PACKAGE).info \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
749 --capture |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
750 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
751 gen-coverage: |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
752 genhtml --output-directory $(COVERAGE_OUT) \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
753 $(COVERAGE_OUT)/$(PACKAGE).info \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
754 --highlight --frames --legend \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
755 --title "$(PACKAGE_NAME)" |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
756 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
757 coverage: init-coverage build-coverage gen-coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
758 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
759 # Update gettext files. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
760 PACKAGE ?= $(shell basename $(PWD)) |
11484
489151a3b578
maintainer-makefile: (PO_DOMAIN): New variable, allows overriding of gettext domain.
Simon Josefsson <simon@josefsson.org>
parents:
11468
diff
changeset
|
761 PO_DOMAIN ?= $(PACKAGE) |
489151a3b578
maintainer-makefile: (PO_DOMAIN): New variable, allows overriding of gettext domain.
Simon Josefsson <simon@josefsson.org>
parents:
11468
diff
changeset
|
762 POURL = http://translationproject.org/latest/$(PO_DOMAIN)/ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
763 PODIR ?= po |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
764 refresh-po: |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
765 rm -f $(PODIR)/*.po && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
766 echo "$(ME): getting translations into po (please ignore the robots.txt ERROR 404)..." && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
767 wget --no-verbose --directory-prefix $(PODIR) --no-directories --recursive --level 1 --accept .po --accept .po.1 $(POURL) && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
768 echo 'en@boldquot' > $(PODIR)/LINGUAS && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
769 echo 'en@quot' >> $(PODIR)/LINGUAS && \ |
10828
45b8dcc40064
maintainer-makefile: Fix sed regexp.
Simon Josefsson <simon@josefsson.org>
parents:
10757
diff
changeset
|
770 ls $(PODIR)/*.po | sed 's/\.po//' | sed 's,$(PODIR)/,,' | sort >> $(PODIR)/LINGUAS |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
771 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
772 INDENT_SOURCES ?= $(C_SOURCES) |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
773 .PHONY: indent |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
774 indent: |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
775 indent $(INDENT_SOURCES) |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
776 |
11834
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
777 # If you want to set UPDATE_COPYRIGHT_* environment variables, |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
778 # put the assignments in this variable. |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
779 update-copyright-env ?= |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
780 |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
781 # Run this rule once per year (usually early in January) |
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
782 # to update all FSF copyright year lists in your project. |
11836
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
783 # If you have an additional project-specific rule, |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
784 # add it in cfg.mk along with a line 'update-copyright: prereq'. |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
785 # By default, exclude all variants of COPYING; you can also |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
786 # add exemptions (such as ChangeLog..* for rotated change logs) |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
787 # in the file .x-update-copyright. |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
788 .PHONY: update-copyright |
11836
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
789 update-copyright: |
11847
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
790 grep -l -w Copyright \ |
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
791 $$(export VC_LIST_EXCEPT_DEFAULT=COPYING && $(VC_LIST_EXCEPT)) \ |
11834
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
792 | $(update-copyright-env) xargs $(build_aux)/$@ |