Mercurial > gnulib

changeset 30518:0aef6b2e2787

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
warnings: Improve code.
author Simon Josefsson <simon@josefsson.org>
date Mon, 17 Nov 2008 22:11:30 +0100
parents 2fcdda67dbd8
children b2772700ca96
files ChangeLog m4/warnings.m4
diffstat 2 files changed, 13 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Nov 17 21:35:50 2008 +0100
+++ b/ChangeLog	Mon Nov 17 22:11:30 2008 +0100
@@ -1,3 +1,8 @@
+2008-11-17  Simon Josefsson  <simon@josefsson.org>
+
+	* m4/warnings.m4: Improve code.  Reported by Ralf Wildenhues
+	<Ralf.Wildenhues@gmx.de> and Paolo Bonzini <bonzini@gnu.org>.
+
 2008-11-17  Simon Josefsson  <simon@josefsson.org>
 
 	* m4/warnings.m4: Use CPPFLAGS to really check whether the
--- a/m4/warnings.m4	Mon Nov 17 21:35:50 2008 +0100
+++ b/m4/warnings.m4	Mon Nov 17 22:11:30 2008 +0100
@@ -114,16 +114,17 @@
 # does OUTVAR = LISTVAR \ REMOVEVAR.
 AC_DEFUN([gl_WARN_COMPLEMENT],
 [
-  FOO=
-  set -- "$2"
-  for w in $_; do
-    case "$3" in
-      *" $w "* | *" $w" | "$w "*)
+  gl_warn_set=
+  set x $2; shift
+  for gl_warn_item
+  do
+    case " $3 " in
+      *" $gl_warn_item "*)
         ;;
       *)
-        FOO="$FOO $w"
+        gl_warn_set="$gl_warn_set $gl_warn_item"
         ;;
     esac
   done
-  $1=$FOO
+  $1=$gl_warn_set
 ])