Mercurial > gnulib

changeset 29227:0be09e88acb1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Revert addition of verify, for BSD/OS. * lib/fseeko.c [!HAVE_FSEEKO]: Allow off_t > long, even though it can't handle large files, for the sake of obsolete platforms. * modules/fseeko (Depends-on): Remove verify. * doc/functions/fseeko.texi (fseeko): Document BSD/OS limitation. * doc/functions/ftello.texi (ftello): Likewise. * doc/functions/fgetpos.texi (fgetpos): Likewise. Reported by Larry Jones. Signed-off-by: Eric Blake <ebb9@byu.net>
author Eric Blake <ebb9@byu.net>
date Mon, 17 Dec 2007 21:50:40 -0700
parents 4e4ff272cf67
children e00bc0cd9038
files ChangeLog doc/functions/fgetpos.texi doc/functions/fseeko.texi doc/functions/ftello.texi lib/fseeko.c modules/fseeko
diffstat 6 files changed, 23 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Dec 17 13:30:09 2007 +0100
+++ b/ChangeLog	Mon Dec 17 21:50:40 2007 -0700
@@ -1,3 +1,14 @@
+2007-12-17  Eric Blake  <ebb9@byu.net>
+
+	Revert addition of verify, for BSD/OS.
+	* lib/fseeko.c [!HAVE_FSEEKO]: Allow off_t > long, even though it
+	can't handle large files, for the sake of obsolete platforms.
+	* modules/fseeko (Depends-on): Remove verify.
+	* doc/functions/fseeko.texi (fseeko): Document BSD/OS limitation.
+	* doc/functions/ftello.texi (ftello): Likewise.
+	* doc/functions/fgetpos.texi (fgetpos): Likewise.
+	Reported by Larry Jones.
+
 2007-12-17  Petr Salinger  <Petr.Salinger@seznam.cz>
 
 	getcwd.c: Use a more readable witness: HAVE_OPENAT_SUPPORT
--- a/doc/functions/fgetpos.texi	Mon Dec 17 13:30:09 2007 +0100
+++ b/doc/functions/fgetpos.texi	Mon Dec 17 21:50:40 2007 -0700
@@ -16,4 +16,8 @@
 @code{fflush}, @code{ftell}, @code{ftello}, @code{fgetpos} behave incorrectly
 on input streams that are opened in @code{O_TEXT} mode and whose contents
 contains Unix line terminators (LF), on some platforms: mingw.
+@item
+On platforms where @code{off_t} is a 64-bit type, but @code{fseeko} is
+not present, stream operations on files larger than 2 GB silently do
+the wrong thing.  This affects BSD/OS, which is mostly obsolete.
 @end itemize
--- a/doc/functions/fseeko.texi	Mon Dec 17 13:30:09 2007 +0100
+++ b/doc/functions/fseeko.texi	Mon Dec 17 21:50:40 2007 -0700
@@ -24,4 +24,8 @@
 On platforms where @code{off_t} is a 32-bit type, @code{fseeko} does not work
 correctly with files larger than 2 GB.  The fix is to use the
 @code{AC_SYS_LARGEFILE} macro.
+@item
+On platforms where @code{off_t} is a 64-bit type, but @code{fseeko} is
+not present, stream operations on files larger than 2 GB silently do
+the wrong thing.  This affects BSD/OS, which is mostly obsolete.
 @end itemize
--- a/doc/functions/ftello.texi	Mon Dec 17 13:30:09 2007 +0100
+++ b/doc/functions/ftello.texi	Mon Dec 17 21:50:40 2007 -0700
@@ -28,4 +28,8 @@
 @code{fflush}, @code{ftell}, @code{ftello}, @code{fgetpos} behave incorrectly
 on input streams that are opened in @code{O_TEXT} mode and whose contents
 contains Unix line terminators (LF), on some platforms: mingw.
+@item
+On platforms where @code{off_t} is a 64-bit type, but @code{fseeko} is
+not present, stream operations on files larger than 2 GB silently do
+the wrong thing.  This affects BSD/OS, which is mostly obsolete.
 @end itemize
--- a/lib/fseeko.c	Mon Dec 17 13:30:09 2007 +0100
+++ b/lib/fseeko.c	Mon Dec 17 21:50:40 2007 -0700
@@ -27,9 +27,6 @@
 #if !HAVE_FSEEKO
 # undef fseek
 # define fseeko fseek
-
-# include <verify.h>
-verify (sizeof (off_t) == sizeof (long));
 #endif
 
 int
--- a/modules/fseeko	Mon Dec 17 13:30:09 2007 +0100
+++ b/modules/fseeko	Mon Dec 17 21:50:40 2007 -0700
@@ -8,7 +8,6 @@
 Depends-on:
 lseek
 stdio
-verify
 
 configure.ac-early:
 AC_REQUIRE([AC_FUNC_FSEEKO])