Mercurial > gnulib
changeset 18623:4c11f0afa3b7
maint.mk: do not always evaluate intprops-related shell
* top/maint.mk (_intprops_names): Change := to just "=" to avoid
using gnulib_dir undefined (gnulib_dir is defined later in the
file, which will be fixed separately), and besides, there is no
need to incur the cost of this shell invocation for every single
use of this .mk file. Reported by Eric Blake in
https://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00137.html
| author | Jim Meyering <meyering@fb.com> |
|---|---|
| date | Sat, 31 Dec 2016 01:31:59 -0800 |
| parents | 7faf67396166 |
| children | 789224cb7717 |
| files | ChangeLog top/maint.mk |
| diffstat | 2 files changed, 11 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Fri Dec 30 09:01:05 2016 -0800 +++ b/ChangeLog Sat Dec 31 01:31:59 2016 -0800 @@ -1,3 +1,13 @@ +2016-12-31 Jim Meyering <meyering@fb.com> + + maint.mk: do not always evaluate intprops-related shell + * top/maint.mk (_intprops_names): Change := to just "=" to avoid + using gnulib_dir undefined (gnulib_dir is defined later in the + file, which will be fixed separately), and besides, there is no + need to incur the cost of this shell invocation for every single + use of this .mk file. Reported by Eric Blake in + https://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00137.html + 2016-12-30 Jim Meyering <meyering@fb.com> maint.mk: improve sc_prohibit_intprops_without_use
--- a/top/maint.mk Fri Dec 30 09:01:05 2016 -0800 +++ b/top/maint.mk Sat Dec 31 01:31:59 2016 -0800 @@ -661,7 +661,7 @@ gl_extract_define_simple = \ /^\# *define ([A-Z]\w+)\(/ and print $$1 # Filter out duplicates and convert to a space-separated list: -_intprops_names := \ +_intprops_names = \ $(shell f=$(gnulib_dir)/lib/intprops.h; \ perl -lne '$(gl_extract_define_simple)' $$f | sort -u | tr '\n' ' ') # Remove trailing space and convert to a regular expression: