changeset 30547:9f3d148da7a1

posixtm.c: avoid a warning * lib/posixtm.c (posixtime): Don't initialize tm0. It's no longer needed to placate gcc4's -Wuninitialized, and the attempt to placate would elicit a new warning.
author Jim Meyering <meyering@redhat.com>
date Sun, 07 Dec 2008 18:47:02 +0100
parents 0099109cbf4a
children 09f96311c007
files ChangeLog lib/posixtm.c
diffstat 2 files changed, 6 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Sat Nov 29 17:42:45 2008 +0100
+++ b/ChangeLog	Sun Dec 07 18:47:02 2008 +0100
@@ -1,5 +1,10 @@
 2008-12-07  Jim Meyering  <meyering@redhat.com>
 
+	posixtm.c: avoid a warning
+	* lib/posixtm.c (posixtime): Don't initialize tm0.
+	It's no longer needed to placate gcc4's -Wuninitialized,
+	and the attempt to placate would elicit a new warning.
+
 	unicodeio.c: mark unused parameters
 	* lib/unicodeio.c (exit_failure_callback): Mark unused parameter.
 	(fallback_failure_callback): Likewise.
--- a/lib/posixtm.c	Sat Nov 29 17:42:45 2008 +0100
+++ b/lib/posixtm.c	Sun Dec 07 18:47:02 2008 +0100
@@ -186,15 +186,7 @@
 bool
 posixtime (time_t *p, const char *s, unsigned int syntax_bits)
 {
-  struct tm tm0
-#ifdef lint
-  /* Placate gcc-4's -Wuninitialized.
-     posix_time_parse fails to set all of tm0 only when it returns
-     nonzero (due to year() returning nonzero), and in that case,
-     this code doesn't use the tm0 at all.  */
-    = { 0, }
-#endif
-    ;
+  struct tm tm0;
   struct tm tm1;
   struct tm const *tm;
   time_t t;