Mercurial > gnulib

changeset 37942:b358ef3f9804

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
acl: fix missing return on Cygwin Compilation on Cygwin 2.4.1 resulted in an 'install' that behaved differently depending on compile-time flags; I traced it to this warning, where the difference was based on what was left in the return register: lib/set-permissions.c: In function 'set_acls_from_mode': lib/set-permissions.c:273:1: warning: control reaches end of non-void function [-Wreturn-type] * lib/set-permissions.c (set_acls) [HAVE_FACL && GETACL]: Don't fall off end of function. Fixes http://bugs.gnu.org/22949 Signed-off-by: Eric Blake <eblake@redhat.com>
author Eric Blake <eblake@redhat.com>
date Tue, 08 Mar 2016 15:35:30 -0700
parents f1b9d5cfe01f
children 486f9d0f767a
files ChangeLog lib/set-permissions.c
diffstat 2 files changed, 7 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Mar 07 08:32:32 2016 -0800
+++ b/ChangeLog	Tue Mar 08 15:35:30 2016 -0700
@@ -1,3 +1,9 @@
+2016-03-08  Eric Blake  <eblake@redhat.com>
+
+	acl: fix missing return on Cygwin
+	* lib/set-permissions.c (set_acls) [HAVE_FACL && GETACL]: Don't
+	fall off end of function. Fixes http://bugs.gnu.org/22949
+
 2016-03-05  Bruno Haible  <bruno@clisp.org>
 
 	extern-inline: port to PGI CC
--- a/lib/set-permissions.c	Mon Mar 07 08:32:32 2016 -0800
+++ b/lib/set-permissions.c	Tue Mar 08 15:35:30 2016 -0700
@@ -269,6 +269,7 @@
 	  }
 	return -1;
       }
+    return 0;
   }
 }