Mercurial > gnulib

changeset 37498:c121cc9a1948

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
vasnprintf: fix potential use after free * lib/vasnprintf.c (VASNPRINTF): Fix free-memory read, flagged by clang-analyzer 3.4.2.
author Pádraig Brady <P@draigBrady.com>
date Sat, 06 Dec 2014 01:14:02 +0000
parents c3bbb3ce357d
children 5fe05aea43d1
files ChangeLog lib/vasnprintf.c
diffstat 2 files changed, 7 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Fri Dec 05 05:56:18 2014 -0800
+++ b/ChangeLog	Sat Dec 06 01:14:02 2014 +0000
@@ -1,3 +1,9 @@
+2014-12-06  Pádraig Brady  <P@draigBrady.com>
+
+	vasnprintf: fix potential use after free
+	* lib/vasnprintf.c (VASNPRINTF): Fix free-memory read,
+	flagged by clang-analyzer 3.4.2.
+
 2014-12-05  Pádraig Brady  <P@draigBrady.com>
 
 	filevercmp, posixtm: avoid compiler warnings with -O3
--- a/lib/vasnprintf.c	Fri Dec 05 05:56:18 2014 -0800
+++ b/lib/vasnprintf.c	Sat Dec 06 01:14:02 2014 +0000
@@ -5184,13 +5184,13 @@
                           free (result);
                         if (buf_malloced != NULL)
                           free (buf_malloced);
-                        CLEANUP ();
                         errno =
                           (saved_errno != 0
                            ? saved_errno
                            : (dp->conversion == 'c' || dp->conversion == 's'
                               ? EILSEQ
                               : EINVAL));
+                        CLEANUP ();
                         return NULL;
                       }