Mercurial > gnulib
changeset 38152:d8a3c8ff3d61
Fix some "gcc -Wall" warnings.
* tests/test-ffsl.c (main): Use variable x, not i.
* tests/test-posix_spawn3.c (parent_main): Consider the return value of
freopen.
* tests/test-sethostname1.c (main): Explicitly ignore the return value
of sethostname.
| author | Bruno Haible <bruno@clisp.org> |
|---|---|
| date | Sun, 16 Oct 2016 16:59:45 +0200 |
| parents | 2c076dc4ca4d |
| children | ecc81d05044c |
| files | ChangeLog tests/test-ffsl.c tests/test-posix_spawn3.c tests/test-sethostname1.c |
| diffstat | 4 files changed, 21 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Sun Oct 16 14:11:18 2016 +0200 +++ b/ChangeLog Sun Oct 16 16:59:45 2016 +0200 @@ -1,3 +1,12 @@ +2016-10-16 Bruno Haible <bruno@clisp.org> + + Fix some "gcc -Wall" warnings. + * tests/test-ffsl.c (main): Use variable x, not i. + * tests/test-posix_spawn3.c (parent_main): Consider the return value of + freopen. + * tests/test-sethostname1.c (main): Explicitly ignore the return value + of sethostname. + 2016-10-16 Bruno Haible <bruno@clisp.org> gnulib-tool: Make --create-testdir on all modules work again.
--- a/tests/test-ffsl.c Sun Oct 16 14:11:18 2016 +0200 +++ b/tests/test-ffsl.c Sun Oct 16 16:59:45 2016 +0200 @@ -44,8 +44,8 @@ long int x; int i; - for (i = -128; i <= 128; i++) - ASSERT (ffsl (i) == naive (i)); + for (x = -128; x <= 128; x++) + ASSERT (ffsl (x) == naive (x)); for (i = 0; i < NBITS; i++) { ASSERT (ffsl (1UL << i) == naive (1UL << i));
--- a/tests/test-posix_spawn3.c Sun Oct 16 14:11:18 2016 +0200 +++ b/tests/test-posix_spawn3.c Sun Oct 16 16:59:45 2016 +0200 @@ -75,7 +75,11 @@ } /* Avoid reading from our stdin, as it could block. */ - freopen ("/dev/null", "rb", stdin); + if (freopen ("/dev/null", "rb", stdin) == NULL) + { + perror ("cannot redirect stdin"); + return 1; + } /* Test whether posix_spawn_file_actions_addopen with this file name actually works, but spawning a child that reads from this file. */
--- a/tests/test-sethostname1.c Sun Oct 16 14:11:18 2016 +0200 +++ b/tests/test-sethostname1.c Sun Oct 16 16:59:45 2016 +0200 @@ -30,8 +30,11 @@ /* Some code that has a link-time dependency to the sethostname() function and that is likely not optimized away by compilers. */ if (do_dangerous_things) - /* Never executed. */ - sethostname ("oprah", 5); + { + /* Never executed. */ + int ret = sethostname ("oprah", 5); + (void) ret; + } return 0; }