changeset 832:799c41a24e75

git_handler.export_git_objects: avoid unnecessary list creation These are used just once, so generators are fine for them.
author Siddharth Agarwal <sid0@fb.com>
date Sun, 30 Nov 2014 00:46:58 -0800
parents 4b5a18d2fa10
children 427f26764fab
files hggit/git_handler.py
diffstat 1 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/hggit/git_handler.py	Sun Nov 30 00:42:30 2014 -0800
+++ b/hggit/git_handler.py	Sun Nov 30 00:46:58 2014 -0800
@@ -378,8 +378,8 @@
     def export_git_objects(self):
         repo = self.repo
         clnode = repo.changelog.node
-        nodes = [clnode(n) for n in repo]
-        export = [repo[node] for node in nodes if not hex(node) in self._map_hg]
+        nodes = (clnode(n) for n in repo)
+        export = (repo[node] for node in nodes if not hex(node) in self._map_hg)
         export = [ctx for ctx in export
                   if ctx.extra().get('hg-git', None) != 'octopus']
         total = len(export)