Mercurial > jwe > octave
comparison libinterp/corefcn/ls-hdf5.cc @ 31110:670a0d878af1
eliminate WHO arguments from interpreter-private functions
* interpreter-private.h, inpterpreter-private.cc (__get_interpreter__,
__get_dynamic_loader__, __get_error_system__, __get_gh_manager__,
__get_help_system__, __get_input_system__, __get_load_path__,
__get_load_save_system__, __get_event_manager__,
__get_output_system__, __get_type_info__, __get_symbol_table__,
__get_current_scope__, __require_current_scope__, __get_evaluator__,
__get_bp_table__, __get_child_list__, __get_cdef_manager__,
__get_display_info__, __get_gtk_manager__): Eliminate WHO argument.
Previously, it was never displayed by __get_interpreter__. And, as
pointed out by Petter Tomner in patch #10216, passing a std::string
object could have performance issues.
(__get_interpreter__): Eliminate useless call to error. Display
message to std::cerr then abort.
| author | John W. Eaton <jwe@octave.org> |
|---|---|
| date | Wed, 22 Jun 2022 12:48:59 -0400 |
| parents | c9788d7f6e65 |
| children |
comparison
equal
deleted
inserted
replaced
| 31109:90549b20fb28 | 31110:670a0d878af1 |
|---|---|
| 620 H5Tclose (st_id); | 620 H5Tclose (st_id); |
| 621 H5Dclose (data_hid); | 621 H5Dclose (data_hid); |
| 622 | 622 |
| 623 args(0) = std::string (iftext_tmp); | 623 args(0) = std::string (iftext_tmp); |
| 624 | 624 |
| 625 octave::interpreter& interp | 625 octave::interpreter& interp = octave::__get_interpreter__ (); |
| 626 = octave::__get_interpreter__ ("load_inline_fcn"); | |
| 627 | 626 |
| 628 octave_value_list tmp = interp.feval ("inline", args, 1); | 627 octave_value_list tmp = interp.feval ("inline", args, 1); |
| 629 | 628 |
| 630 if (tmp.length () > 0) | 629 if (tmp.length () > 0) |
| 631 { | 630 { |
| 670 herr_t retval = 0; | 669 herr_t retval = 0; |
| 671 bool ident_valid = octave::valid_identifier (name); | 670 bool ident_valid = octave::valid_identifier (name); |
| 672 | 671 |
| 673 std::string vname = name; | 672 std::string vname = name; |
| 674 | 673 |
| 675 octave::type_info& type_info | 674 octave::type_info& type_info = octave::__get_type_info__ (); |
| 676 = octave::__get_type_info__ ("hdf5_read_next_data_internal"); | |
| 677 | 675 |
| 678 // Allow identifiers as all digits so we can load lists saved by | 676 // Allow identifiers as all digits so we can load lists saved by |
| 679 // earlier versions of Octave. | 677 // earlier versions of Octave. |
| 680 | 678 |
| 681 if (! ident_valid) | 679 if (! ident_valid) |