Mercurial > jwe > octave
diff libinterp/corefcn/ls-hdf5.cc @ 31110:670a0d878af1
eliminate WHO arguments from interpreter-private functions
* interpreter-private.h, inpterpreter-private.cc (__get_interpreter__,
__get_dynamic_loader__, __get_error_system__, __get_gh_manager__,
__get_help_system__, __get_input_system__, __get_load_path__,
__get_load_save_system__, __get_event_manager__,
__get_output_system__, __get_type_info__, __get_symbol_table__,
__get_current_scope__, __require_current_scope__, __get_evaluator__,
__get_bp_table__, __get_child_list__, __get_cdef_manager__,
__get_display_info__, __get_gtk_manager__): Eliminate WHO argument.
Previously, it was never displayed by __get_interpreter__. And, as
pointed out by Petter Tomner in patch #10216, passing a std::string
object could have performance issues.
(__get_interpreter__): Eliminate useless call to error. Display
message to std::cerr then abort.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Wed, 22 Jun 2022 12:48:59 -0400 |
parents | c9788d7f6e65 |
children |
line wrap: on
line diff
--- a/libinterp/corefcn/ls-hdf5.cc Tue Jun 21 15:44:03 2022 +0200 +++ b/libinterp/corefcn/ls-hdf5.cc Wed Jun 22 12:48:59 2022 -0400 @@ -622,8 +622,7 @@ args(0) = std::string (iftext_tmp); - octave::interpreter& interp - = octave::__get_interpreter__ ("load_inline_fcn"); + octave::interpreter& interp = octave::__get_interpreter__ (); octave_value_list tmp = interp.feval ("inline", args, 1); @@ -672,8 +671,7 @@ std::string vname = name; - octave::type_info& type_info - = octave::__get_type_info__ ("hdf5_read_next_data_internal"); + octave::type_info& type_info = octave::__get_type_info__ (); // Allow identifiers as all digits so we can load lists saved by // earlier versions of Octave.