Mercurial > jwe > octave

changeset 27120:014e137947d7

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Work around Qt rename bug in File Browser window (bug #56298). * files-dock-widget.cc (contextmenu_rename): Use rename() member function from QFile class, rather than QDir class, which has been patched to work correctly on Windows for Qt versions >= 5.10.
author Rik <rik@octave.org>
date Mon, 27 May 2019 09:32:38 -0700
parents 8a04f5454350
children e14e48e838fa
files libgui/src/files-dock-widget.cc
diffstat 1 files changed, 2 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libgui/src/files-dock-widget.cc	Sat May 25 18:36:59 2019 -0700
+++ b/libgui/src/files-dock-widget.cc	Mon May 27 09:32:38 2019 -0700
@@ -671,7 +671,8 @@
             // editor: close old
             emit file_remove_signal (old_name, new_name);
             // Do the renaming
-            bool st = path.rename (old_name, new_name);
+            QFile f (old_name);  // Must use QFile, not QDir (bug #56298)
+            bool st = f.rename (new_name);
             // editor: load new/old file depending on success
             emit file_renamed_signal (st);
             // Clear cache of file browser