Mercurial > jwe > octave
changeset 26401:586413770c7f
pass save_as_floats by value in octave_value save_binary functions
* ov.h (octave_value::save_binary): Pass save_as_floats parameter by
value.
* ov-base.h, ov-base.cc (octave_base_value::save_binary): Likewise.
* ov-base-int.cc, ov-base-int.h, ov-bool-mat.cc, ov-bool-mat.h,
ov-bool-sparse.cc, ov-bool-sparse.h, ov-bool.cc, ov-bool.h,
ov-cell.cc, ov-cell.h, ov-class.cc, ov-class.h, ov-complex.cc,
ov-complex.h, ov-cx-diag.cc, ov-cx-diag.h, ov-cx-mat.cc, ov-cx-mat.h,
ov-cx-sparse.cc, ov-cx-sparse.h, ov-fcn-handle.cc, ov-fcn-handle.h,
ov-fcn-inline.cc, ov-fcn-inline.h, ov-float.cc, ov-float.h,
ov-flt-complex.cc, ov-flt-complex.h, ov-flt-cx-diag.cc,
ov-flt-cx-diag.h, ov-flt-cx-mat.cc, ov-flt-cx-mat.h,
ov-flt-re-diag.cc, ov-flt-re-diag.h, ov-flt-re-mat.cc,
ov-flt-re-mat.h, ov-java.cc, ov-java.h, ov-lazy-idx.cc, ov-lazy-idx.h,
ov-oncleanup.cc, ov-oncleanup.h, ov-perm.cc, ov-perm.h, ov-range.cc,
ov-range.h, ov-re-diag.cc, ov-re-diag.h, ov-re-mat.cc, ov-re-mat.h,
ov-re-sparse.cc, ov-re-sparse.h, ov-scalar.cc, ov-scalar.h,
ov-str-mat.cc, ov-str-mat.h, ov-struct.cc, ov-struct.h:
Pass save_as_floats parameter by value in all classes derived from
octave_base_value.
line wrap: on
line diff
--- a/libinterp/octave-value/ov-base-int.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-base-int.cc Thu Jan 03 09:36:00 2019 -0500 @@ -325,7 +325,7 @@ template <typename T> bool -octave_base_int_matrix<T>::save_binary (std::ostream& os, bool&) +octave_base_int_matrix<T>::save_binary (std::ostream& os, bool) { dim_vector dv = this->dims (); if (dv.ndims () < 1) @@ -691,7 +691,7 @@ template <typename T> bool -octave_base_int_scalar<T>::save_binary (std::ostream& os, bool&) +octave_base_int_scalar<T>::save_binary (std::ostream& os, bool) { os.write (reinterpret_cast<char *> (&(this->scalar)), this->byte_size ()); return true;
--- a/libinterp/octave-value/ov-base-int.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-base-int.h Thu Jan 03 09:36:00 2019 -0500 @@ -91,7 +91,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool&); + bool save_binary (std::ostream& os, bool); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format); @@ -156,7 +156,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool&); + bool save_binary (std::ostream& os, bool); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format);
--- a/libinterp/octave-value/ov-base.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-base.cc Thu Jan 03 09:36:00 2019 -0500 @@ -941,7 +941,7 @@ } bool -octave_base_value::save_binary (std::ostream&, bool&) +octave_base_value::save_binary (std::ostream&, bool) { err_wrong_type_arg ("octave_base_value::save_binary()", type_name ()); }
--- a/libinterp/octave-value/ov-base.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-base.h Thu Jan 03 09:36:00 2019 -0500 @@ -672,7 +672,7 @@ virtual bool load_ascii (std::istream& is); - virtual bool save_binary (std::ostream& os, bool& save_as_floats); + virtual bool save_binary (std::ostream& os, bool save_as_floats); virtual bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-bool-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -343,7 +343,7 @@ } bool -octave_bool_matrix::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_bool_matrix::save_binary (std::ostream& os, bool /* save_as_floats */) { dim_vector dv = dims ();
--- a/libinterp/octave-value/ov-bool-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -213,7 +213,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-bool-sparse.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool-sparse.cc Thu Jan 03 09:36:00 2019 -0500 @@ -202,7 +202,7 @@ } bool -octave_sparse_bool_matrix::save_binary (std::ostream& os, bool&) +octave_sparse_bool_matrix::save_binary (std::ostream& os, bool) { dim_vector dv = this->dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-bool-sparse.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool-sparse.h Thu Jan 03 09:36:00 2019 -0500 @@ -132,7 +132,7 @@ octave_value as_double (void) const; - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-bool.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool.cc Thu Jan 03 09:36:00 2019 -0500 @@ -203,7 +203,7 @@ } bool -octave_bool::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_bool::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = (scalar ? 1 : 0); os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-bool.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-bool.h Thu Jan 03 09:36:00 2019 -0500 @@ -226,7 +226,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-cell.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cell.cc Thu Jan 03 09:36:00 2019 -0500 @@ -887,7 +887,7 @@ } bool -octave_cell::save_binary (std::ostream& os, bool& save_as_floats) +octave_cell::save_binary (std::ostream& os, bool save_as_floats) { dim_vector dv = dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-cell.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cell.h Thu Jan 03 09:36:00 2019 -0500 @@ -152,7 +152,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-class.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-class.cc Thu Jan 03 09:36:00 2019 -0500 @@ -1270,7 +1270,7 @@ } bool -octave_class::save_binary (std::ostream& os, bool& save_as_floats) +octave_class::save_binary (std::ostream& os, bool save_as_floats) { int32_t classname_len = class_name ().length ();
--- a/libinterp/octave-value/ov-class.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-class.h Thu Jan 03 09:36:00 2019 -0500 @@ -189,7 +189,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-complex.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-complex.cc Thu Jan 03 09:36:00 2019 -0500 @@ -324,7 +324,7 @@ } bool -octave_complex::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_complex::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = static_cast<char> (LS_DOUBLE); os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-complex.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-complex.h Thu Jan 03 09:36:00 2019 -0500 @@ -169,7 +169,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-cx-diag.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-diag.cc Thu Jan 03 09:36:00 2019 -0500 @@ -177,7 +177,7 @@ } bool -octave_complex_diag_matrix::save_binary (std::ostream& os, bool& save_as_floats) +octave_complex_diag_matrix::save_binary (std::ostream& os, bool save_as_floats) { int32_t r = matrix.rows ();
--- a/libinterp/octave-value/ov-cx-diag.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-diag.h Thu Jan 03 09:36:00 2019 -0500 @@ -82,7 +82,7 @@ octave_value as_double (void) const; octave_value as_single (void) const; - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-cx-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -410,7 +410,7 @@ } bool -octave_complex_matrix::save_binary (std::ostream& os, bool& save_as_floats) +octave_complex_matrix::save_binary (std::ostream& os, bool save_as_floats) { dim_vector dv = dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-cx-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -153,7 +153,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-cx-sparse.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-sparse.cc Thu Jan 03 09:36:00 2019 -0500 @@ -219,7 +219,7 @@ bool octave_sparse_complex_matrix::save_binary (std::ostream& os, - bool& save_as_floats) + bool save_as_floats) { dim_vector dv = this->dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-cx-sparse.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-cx-sparse.h Thu Jan 03 09:36:00 2019 -0500 @@ -138,7 +138,7 @@ } #endif - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-fcn-handle.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-fcn-handle.cc Thu Jan 03 09:36:00 2019 -0500 @@ -535,7 +535,7 @@ } bool -octave_fcn_handle::save_binary (std::ostream& os, bool& save_as_floats) +octave_fcn_handle::save_binary (std::ostream& os, bool save_as_floats) { if (nm == anonymous) {
--- a/libinterp/octave-value/ov-fcn-handle.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-fcn-handle.h Thu Jan 03 09:36:00 2019 -0500 @@ -137,7 +137,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-fcn-inline.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-fcn-inline.cc Thu Jan 03 09:36:00 2019 -0500 @@ -201,7 +201,7 @@ } bool -octave_fcn_inline::save_binary (std::ostream& os, bool&) +octave_fcn_inline::save_binary (std::ostream& os, bool) { int32_t tmp = ifargs.numel (); os.write (reinterpret_cast<char *> (&tmp), 4);
--- a/libinterp/octave-value/ov-fcn-inline.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-fcn-inline.h Thu Jan 03 09:36:00 2019 -0500 @@ -74,7 +74,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-float.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-float.cc Thu Jan 03 09:36:00 2019 -0500 @@ -215,7 +215,7 @@ } bool -octave_float_scalar::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_float_scalar::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = LS_FLOAT; os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-float.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-float.h Thu Jan 03 09:36:00 2019 -0500 @@ -241,7 +241,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-flt-complex.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-complex.cc Thu Jan 03 09:36:00 2019 -0500 @@ -271,7 +271,7 @@ } bool -octave_float_complex::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_float_complex::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = static_cast<char> (LS_FLOAT); os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-flt-complex.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-complex.h Thu Jan 03 09:36:00 2019 -0500 @@ -165,7 +165,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-flt-cx-diag.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-cx-diag.cc Thu Jan 03 09:36:00 2019 -0500 @@ -158,7 +158,7 @@ bool octave_float_complex_diag_matrix::save_binary (std::ostream& os, - bool& /* save_as_floats */) + bool /* save_as_floats */) { int32_t r = matrix.rows ();
--- a/libinterp/octave-value/ov-flt-cx-diag.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-cx-diag.h Thu Jan 03 09:36:00 2019 -0500 @@ -80,7 +80,7 @@ octave_value as_double (void) const; octave_value as_single (void) const; - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-flt-cx-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-cx-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -384,7 +384,7 @@ } bool -octave_float_complex_matrix::save_binary (std::ostream& os, bool&) +octave_float_complex_matrix::save_binary (std::ostream& os, bool) { dim_vector dv = dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-flt-cx-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-cx-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -149,7 +149,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-flt-re-diag.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-re-diag.cc Thu Jan 03 09:36:00 2019 -0500 @@ -176,7 +176,7 @@ bool octave_float_diag_matrix::save_binary (std::ostream& os, - bool& /* save_as_floats*/) + bool /* save_as_floats*/) { int32_t r = matrix.rows ();
--- a/libinterp/octave-value/ov-flt-re-diag.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-re-diag.h Thu Jan 03 09:36:00 2019 -0500 @@ -90,7 +90,7 @@ octave_value as_uint32 (void) const; octave_value as_uint64 (void) const; - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-flt-re-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-re-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -461,7 +461,7 @@ } bool -octave_float_matrix::save_binary (std::ostream& os, bool&) +octave_float_matrix::save_binary (std::ostream& os, bool) { dim_vector dv = dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-flt-re-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-flt-re-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -197,7 +197,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-java.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-java.cc Thu Jan 03 09:36:00 2019 -0500 @@ -2339,7 +2339,7 @@ } bool -octave_java::save_binary (std::ostream& /* os */, bool& /* save_as_floats */) +octave_java::save_binary (std::ostream& /* os */, bool /* save_as_floats */) { warning ("save: unable to save java objects, skipping");
--- a/libinterp/octave-value/ov-java.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-java.h Thu Jan 03 09:36:00 2019 -0500 @@ -81,7 +81,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-lazy-idx.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-lazy-idx.cc Thu Jan 03 09:36:00 2019 -0500 @@ -237,7 +237,7 @@ return true; } -bool octave_lazy_index::save_binary (std::ostream& os, bool& save_as_floats) +bool octave_lazy_index::save_binary (std::ostream& os, bool save_as_floats) { return save_binary_data (os, make_value (), value_save_tag, "", false, save_as_floats);
--- a/libinterp/octave-value/ov-lazy-idx.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-lazy-idx.h Thu Jan 03 09:36:00 2019 -0500 @@ -209,7 +209,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-oncleanup.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-oncleanup.cc Thu Jan 03 09:36:00 2019 -0500 @@ -134,7 +134,7 @@ bool octave_oncleanup::save_binary (std::ostream& /* os */, - bool& /* save_as_floats */) + bool /* save_as_floats */) { warning ("save: unable to save onCleanup variables, skipping");
--- a/libinterp/octave-value/ov-oncleanup.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-oncleanup.h Thu Jan 03 09:36:00 2019 -0500 @@ -72,7 +72,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-perm.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-perm.cc Thu Jan 03 09:36:00 2019 -0500 @@ -368,7 +368,7 @@ } bool -octave_perm_matrix::save_binary (std::ostream& os, bool&) +octave_perm_matrix::save_binary (std::ostream& os, bool) { int32_t sz = matrix.rows ();
--- a/libinterp/octave-value/ov-perm.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-perm.h Thu Jan 03 09:36:00 2019 -0500 @@ -218,7 +218,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-range.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-range.cc Thu Jan 03 09:36:00 2019 -0500 @@ -566,7 +566,7 @@ } bool -octave_range::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_range::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = LS_DOUBLE; os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-range.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-range.h Thu Jan 03 09:36:00 2019 -0500 @@ -279,7 +279,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-re-diag.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-diag.cc Thu Jan 03 09:36:00 2019 -0500 @@ -243,7 +243,7 @@ } bool -octave_diag_matrix::save_binary (std::ostream& os, bool& save_as_floats) +octave_diag_matrix::save_binary (std::ostream& os, bool save_as_floats) { int32_t r = matrix.rows ();
--- a/libinterp/octave-value/ov-re-diag.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-diag.h Thu Jan 03 09:36:00 2019 -0500 @@ -95,7 +95,7 @@ octave_value as_uint32 (void) const; octave_value as_uint64 (void) const; - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-re-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -564,7 +564,7 @@ } bool -octave_matrix::save_binary (std::ostream& os, bool& save_as_floats) +octave_matrix::save_binary (std::ostream& os, bool save_as_floats) { dim_vector dv = dims ();
--- a/libinterp/octave-value/ov-re-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -221,7 +221,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-re-sparse.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-sparse.cc Thu Jan 03 09:36:00 2019 -0500 @@ -244,7 +244,7 @@ } bool -octave_sparse_matrix::save_binary (std::ostream& os, bool& save_as_floats) +octave_sparse_matrix::save_binary (std::ostream& os, bool save_as_floats) { dim_vector dv = this->dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-re-sparse.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-re-sparse.h Thu Jan 03 09:36:00 2019 -0500 @@ -141,7 +141,7 @@ { return os.write (matrix, block_size, output_type, skip, flt_fmt); } #endif - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-scalar.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-scalar.cc Thu Jan 03 09:36:00 2019 -0500 @@ -235,7 +235,7 @@ } bool -octave_scalar::save_binary (std::ostream& os, bool& /* save_as_floats */) +octave_scalar::save_binary (std::ostream& os, bool /* save_as_floats */) { char tmp = LS_DOUBLE; os.write (reinterpret_cast<char *> (&tmp), 1);
--- a/libinterp/octave-value/ov-scalar.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-scalar.h Thu Jan 03 09:36:00 2019 -0500 @@ -244,7 +244,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-str-mat.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-str-mat.cc Thu Jan 03 09:36:00 2019 -0500 @@ -456,7 +456,7 @@ bool octave_char_matrix_str::save_binary (std::ostream& os, - bool& /* save_as_floats */) + bool /* save_as_floats */) { dim_vector dv = dims (); if (dv.ndims () < 1)
--- a/libinterp/octave-value/ov-str-mat.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-str-mat.h Thu Jan 03 09:36:00 2019 -0500 @@ -153,7 +153,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov-struct.cc Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-struct.cc Thu Jan 03 09:36:00 2019 -0500 @@ -791,7 +791,7 @@ } bool -octave_struct::save_binary (std::ostream& os, bool& save_as_floats) +octave_struct::save_binary (std::ostream& os, bool save_as_floats) { octave_map m = map_value (); @@ -1451,7 +1451,7 @@ } bool -octave_scalar_struct::save_binary (std::ostream& os, bool& save_as_floats) +octave_scalar_struct::save_binary (std::ostream& os, bool save_as_floats) { octave_map m = map_value ();
--- a/libinterp/octave-value/ov-struct.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov-struct.h Thu Jan 03 09:36:00 2019 -0500 @@ -138,7 +138,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt); @@ -262,7 +262,7 @@ bool load_ascii (std::istream& is); - bool save_binary (std::ostream& os, bool& save_as_floats); + bool save_binary (std::ostream& os, bool save_as_floats); bool load_binary (std::istream& is, bool swap, octave::mach_info::float_format fmt);
--- a/libinterp/octave-value/ov.h Thu Jan 03 10:16:26 2019 -0500 +++ b/libinterp/octave-value/ov.h Thu Jan 03 09:36:00 2019 -0500 @@ -1269,7 +1269,7 @@ bool load_ascii (std::istream& is) { return rep->load_ascii (is); } - bool save_binary (std::ostream& os, bool& save_as_floats) + bool save_binary (std::ostream& os, bool save_as_floats) { return rep->save_binary (os, save_as_floats); } bool load_binary (std::istream& is, bool swap,