changeset 26748:bbc6b88aacc1

eliminate some useless functions * ov-class.h, ov-class.cc (octave_class::print_name_tag, octave_class::print_with_name): Delete virtual functions that simply call the base class implementation. * ov-classdef.h, ov-classdef.cc (octave_classdef::print_name_tag, octave_classdef::print_with_name): Likewise.
author John W. Eaton <jwe@octave.org>
date Tue, 19 Feb 2019 17:53:40 +0000
parents 568565a70b58
children a3dfdbb9d8c5
files libinterp/octave-value/ov-class.cc libinterp/octave-value/ov-class.h libinterp/octave-value/ov-classdef.cc libinterp/octave-value/ov-classdef.h
diffstat 4 files changed, 0 insertions(+), 37 deletions(-) [+]
line wrap: on
line diff
--- a/libinterp/octave-value/ov-class.cc	Mon Feb 18 19:10:43 2019 +0000
+++ b/libinterp/octave-value/ov-class.cc	Tue Feb 19 17:53:40 2019 +0000
@@ -1023,19 +1023,6 @@
   newline (os);
 }
 
-bool
-octave_class::print_name_tag (std::ostream& os, const std::string& name) const
-{
-  return octave_base_value::print_name_tag (os, name);
-}
-
-void
-octave_class::print_with_name (std::ostream& os, const std::string& name,
-                               bool print_padding)
-{
-  octave_base_value::print_with_name (os, name, print_padding);
-}
-
 // Loading a class properly requires an exemplar map entry for success.
 // If we don't have one, we attempt to create one by calling the constructor
 // with no arguments.
--- a/libinterp/octave-value/ov-class.h	Mon Feb 18 19:10:43 2019 +0000
+++ b/libinterp/octave-value/ov-class.h	Tue Feb 19 17:53:40 2019 +0000
@@ -174,11 +174,6 @@
 
   void print_raw (std::ostream& os, bool pr_as_read_syntax = false) const;
 
-  bool print_name_tag (std::ostream& os, const std::string& name) const;
-
-  void print_with_name (std::ostream& os, const std::string& name,
-                        bool print_padding = true);
-
   bool reconstruct_exemplar (void);
 
   static void clear_exemplar_map (void);
--- a/libinterp/octave-value/ov-classdef.cc	Mon Feb 18 19:10:43 2019 +0000
+++ b/libinterp/octave-value/ov-classdef.cc	Tue Feb 19 17:53:40 2019 +0000
@@ -1027,20 +1027,6 @@
 }
 
 bool
-octave_classdef::print_name_tag (std::ostream& os,
-                                 const std::string& name) const
-{
-  return octave_base_value::print_name_tag (os, name);
-}
-
-void
-octave_classdef::print_with_name (std::ostream& os, const std::string& name,
-                                  bool print_padding)
-{
-  octave_base_value::print_with_name (os, name, print_padding);
-}
-
-bool
 octave_classdef::is_instance_of (const std::string& cls_name) const
 {
   cdef_class cls = lookup_class (cls_name, false, false);
--- a/libinterp/octave-value/ov-classdef.h	Mon Feb 18 19:10:43 2019 +0000
+++ b/libinterp/octave-value/ov-classdef.h	Tue Feb 19 17:53:40 2019 +0000
@@ -1515,11 +1515,6 @@
 
   void print_raw (std::ostream& os, bool pr_as_read_syntax = false) const;
 
-  bool print_name_tag (std::ostream& os, const std::string& name) const;
-
-  void print_with_name (std::ostream& os, const std::string& name,
-                        bool print_padding = true);
-
   bool is_instance_of (const std::string& cls_name) const;
 
   octave_value_list subsref (const std::string& type,