changeset 7350:288614c6634d

[project @ 2008-01-07 16:50:34 by jwe]
author jwe
date Mon, 07 Jan 2008 16:51:31 +0000
parents a1ab9dbc9622
children 8470a6b0b769
files liboctave/ChangeLog liboctave/Sparse-op-defs.h
diffstat 2 files changed, 10 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/liboctave/ChangeLog	Mon Jan 07 14:40:24 2008 +0000
+++ b/liboctave/ChangeLog	Mon Jan 07 16:51:31 2008 +0000
@@ -1,3 +1,8 @@
+2008-01-07  David Bateman  <dbateman@free.fr>
+
+	* Sparse-op-defs.h (SPARSE_ANY_ALL_OP_ROW_CODE): Don't break from
+	loop if this test succeeds.
+
 2008-01-03  David Bateman  <dbateman@free.fr>
 
 	* MSparse.cc (SPARSE_A2A2_OP): If first arg is scalar zero, then
--- a/liboctave/Sparse-op-defs.h	Mon Jan 07 14:40:24 2008 +0000
+++ b/liboctave/Sparse-op-defs.h	Mon Jan 07 16:51:31 2008 +0000
@@ -1694,12 +1694,13 @@
 			SPARSE_REDUCTION_OP_COL_EXPR (OP), \
 			INIT_VAL, MT_RESULT)
 
+
+// Don't break from this loop if the test succeeds because
+// we are looping over the rows and not the columns in the inner
+// loop.
 #define SPARSE_ANY_ALL_OP_ROW_CODE(TEST_OP, TEST_TRUE_VAL) \
   if (data (i) TEST_OP 0.0) \
-    { \
-      tmp[ridx(i)] = TEST_TRUE_VAL; \
-      break; \
-    }
+    tmp[ridx(i)] = TEST_TRUE_VAL; \
 
 #define SPARSE_ANY_ALL_OP_COL_CODE(TEST_OP, TEST_TRUE_VAL) \
   if (data (i) TEST_OP 0.0) \