annotate test/deprecate-props.tst @ 27918:b442ec6dda5c

use centralized file for copyright info for individual contributors * COPYRIGHT.md: New file. * In most other files, use "Copyright (C) YYYY-YYYY The Octave Project Developers" instead of tracking individual names in separate source files. The motivation is to reduce the effort required to update the notices each year. Until now, the Octave source files contained copyright notices that list individual contributors. I adopted these file-scope copyright notices because that is what everyone was doing 30 years ago in the days before distributed version control systems. But now, with many contributors and modern version control systems, having these file-scope copyright notices causes trouble when we update copyright years or refactor code. Over time, the file-scope copyright notices may become outdated as new contributions are made or code is moved from one file to another. Sometimes people contribute significant patches but do not add a line claiming copyright. Other times, people add a copyright notice for their contribution but then a later refactoring moves part or all of their contribution to another file and the notice is not moved with the code. As a practical matter, moving such notices is difficult -- determining what parts are due to a particular contributor requires a time-consuming search through the project history. Even managing the yearly update of copyright years is problematic. We have some contributors who are no longer living. Should we update the copyright dates for their contributions when we release new versions? Probably not, but we do still want to claim copyright for the project as a whole. To minimize the difficulty of maintaining the copyright notices, I would like to change Octave's sources to use what is described here: https://softwarefreedom.org/resources/2012/ManagingCopyrightInformation.html in the section "Maintaining centralized copyright notices": The centralized notice approach consolidates all copyright notices in a single location, usually a top-level file. This file should contain all of the copyright notices provided project contributors, unless the contribution was clearly insignificant. It may also credit -- without a copyright notice -- anyone who helped with the project but did not contribute code or other copyrighted material. This approach captures less information about contributions within individual files, recognizing that the DVCS is better equipped to record those details. As we mentioned before, it does have one disadvantage as compared to the file-scope approach: if a single file is separated from the distribution, the recipient won't see the contributors' copyright notices. But this can be easily remedied by including a single copyright notice in each file's header, pointing to the top-level file: Copyright YYYY-YYYY The Octave Project Developers See the COPYRIGHT file at the top-level directory of this distribution or at https://octave.org/COPYRIGHT.html. followed by the usual GPL copyright statement. For more background, see the discussion here: https://lists.gnu.org/archive/html/octave-maintainers/2020-01/msg00009.html Most files in the following directories have been skipped intentinally in this changeset: doc libgui/qterminal liboctave/external m4
author John W. Eaton <jwe@octave.org>
date Mon, 06 Jan 2020 15:38:17 -0500
parents ab5bfee22d18
children 1891570abac8
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
27918
b442ec6dda5c use centralized file for copyright info for individual contributors
John W. Eaton <jwe@octave.org>
parents: 26995
diff changeset
1 ## Copyright (C) 2017-2019 The Octave Project Developers
b442ec6dda5c use centralized file for copyright info for individual contributors
John W. Eaton <jwe@octave.org>
parents: 26995
diff changeset
2 ##
b442ec6dda5c use centralized file for copyright info for individual contributors
John W. Eaton <jwe@octave.org>
parents: 26995
diff changeset
3 ## See the file COPYRIGHT.md in the top-level directory of this distribution
b442ec6dda5c use centralized file for copyright info for individual contributors
John W. Eaton <jwe@octave.org>
parents: 26995
diff changeset
4 ## or <https://octave.org/COPYRIGHT.html/>.
b442ec6dda5c use centralized file for copyright info for individual contributors
John W. Eaton <jwe@octave.org>
parents: 26995
diff changeset
5 ##
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
6 ##
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
7 ## This file is part of Octave.
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
8 ##
24534
194eb4bd202b maint: Update punctuation for GPL v3 license text.
Rik <rik@octave.org>
parents: 23210
diff changeset
9 ## Octave is free software: you can redistribute it and/or modify it
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
10 ## under the terms of the GNU General Public License as published by
24534
194eb4bd202b maint: Update punctuation for GPL v3 license text.
Rik <rik@octave.org>
parents: 23210
diff changeset
11 ## the Free Software Foundation, either version 3 of the License, or
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
12 ## (at your option) any later version.
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
13 ##
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
14 ## Octave is distributed in the hope that it will be useful, but
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
15 ## WITHOUT ANY WARRANTY; without even the implied warranty of
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
16 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
17 ## GNU General Public License for more details.
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
18 ##
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
19 ## You should have received a copy of the GNU General Public License
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
20 ## along with Octave; see the file COPYING. If not, see
24534
194eb4bd202b maint: Update punctuation for GPL v3 license text.
Rik <rik@octave.org>
parents: 23210
diff changeset
21 ## <https://www.gnu.org/licenses/>.
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
22
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
23 ## Put graphics properties here that should be removed, or for which some
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
24 ## values (radio strings only) should not be accepted, in a given future
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
25 ## version. Don't forget to add a note in the NEWS file.
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
26
25174
6fdfe4127f0f deprecated-props.tst: improve version comparison
John W. Eaton <jwe@octave.org>
parents: 25172
diff changeset
27 %!function testprop (h, prop, removal_version, val = [])
6fdfe4127f0f deprecated-props.tst: improve version comparison
John W. Eaton <jwe@octave.org>
parents: 25172
diff changeset
28 %! if (compare_versions (version (), removal_version, ">="))
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
29 %! if (isempty (val) && isprop (h, prop))
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
30 %! error ("Please remove %s property %s", get (h, "type"), prop);
25174
6fdfe4127f0f deprecated-props.tst: improve version comparison
John W. Eaton <jwe@octave.org>
parents: 25172
diff changeset
31 %! elseif (! isempty (val) && any (strcmp (val, set (h, prop))))
23201
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
32 %! error ("Please remove '%s' from allowed values for %s property %s",
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
33 %! val, get (h, "type"), prop);
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
34 %! endif
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
35 %! endif
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
36 %!endfunction
239a9fed80de New mechanism to deprecate graphics properties (bug #50327)
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents:
diff changeset
37
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
38 ## text/uicontrol/uipanel/uibuttongroup/uitable "oblique" value for
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
39 ## "fontangle" property was deprecated in 5.0, remove from version 7:
26995
ab5bfee22d18 maint: Strip trailing whitespace from source files.
John W. Eaton <jwe@octave.org>
parents: 26377
diff changeset
40 ## * remove "oblique" options in graphics.in.h, QtHandlesUtils.cc,
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
41 ## and ft-text-renderer.cc
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
42 ## * remove warnings from update_fontangle in graphics.in.h
23210
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
43 %!test
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
44 %! hf = figure ("visible", "off");
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
45 %! unwind_protect
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
46 %! ht = text ();
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
47 %! testprop (ht, "fontangle", "7.0", "oblique");
23210
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
48 %! hui = uicontrol ();
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
49 %! testprop (hui, "fontangle", "7.0", "oblique");
23210
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
50 %! hui = uipanel ();
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
51 %! testprop (hui, "fontangle", "7.0", "oblique");
23210
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
52 %! hui = uibuttongroup ();
26275
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
53 %! testprop (hui, "fontangle", "7.0", "oblique");
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
54 %! hui = uitable ();
dd97dc559679 maint: Remove deprecated graphics properties.
Rik <rik@octave.org>
parents: 25175
diff changeset
55 %! testprop (hui, "fontangle", "7.0", "oblique");
23210
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
56 %! unwind_protect_cleanup
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
57 %! close (hf);
3a298e07002c Deprecate "light" and "demi" values for "fontweight" property (bug #50353).
Pantxo Diribarne <pantxo.diribarne@gmail.com>
parents: 23201
diff changeset
58 %! end_unwind_protect