Mercurial > octave

comparison liboctave/numeric/svd.h @ 22228:4afe3705ea75

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
svd: do not shadow member variables with local variables. * liboctave/numeric/svd.cc, liboctave/numeric/svd.h: there was no issue with current code because member variables never change after construction. Still, it's not good practice and the compilers will warn about it.
author Carnë Draug <carandraug@octave.org>
date Tue, 09 Aug 2016 00:21:36 +0100
parents 469c817eb256
children e43199618777
comparison
equal deleted inserted replaced
22227:ab139f0733b9 22228:4afe3705ea75
48 GESVD, 48 GESVD,
49 GESDD 49 GESDD
50 }; 50 };
51 51
52 svd (void) 52 svd (void)
53 : type (), driver (), left_sm (), sigma (), right_sm () 53 : m_type (), m_driver (), left_sm (), sigma (), right_sm ()
54 { } 54 { }
55 55
56 svd (const T& a, svd::Type type = svd::Type::std, 56 svd (const T& a, svd::Type type = svd::Type::std,
57 svd::Driver driver = svd::Driver::GESVD); 57 svd::Driver driver = svd::Driver::GESVD);
58 58
59 svd (const svd& a) 59 svd (const svd& a)
60 : type (a.type), driver (a.driver), left_sm (a.left_sm), sigma (a.sigma), 60 : m_type (a.m_type), m_driver (a.m_driver), left_sm (a.left_sm),
61 right_sm (a.right_sm) 61 sigma (a.sigma), right_sm (a.right_sm)
62 { } 62 { }
63 63
64 svd& operator = (const svd& a) 64 svd& operator = (const svd& a)
65 { 65 {
66 if (this != &a) 66 if (this != &a)
67 { 67 {
68 type = a.type; 68 m_type = a.m_type;
69 left_sm = a.left_sm; 69 left_sm = a.left_sm;
70 sigma = a.sigma; 70 sigma = a.sigma;
71 right_sm = a.right_sm; 71 right_sm = a.right_sm;
72 driver = a.driver; 72 m_driver = a.m_driver;
73 } 73 }
74 74
75 return *this; 75 return *this;
76 } 76 }
77 77
86 private: 86 private:
87 87
88 typedef typename T::element_type P; 88 typedef typename T::element_type P;
89 typedef typename DM_T::element_type DM_P; 89 typedef typename DM_T::element_type DM_P;
90 90
91 svd::Type type; 91 svd::Type m_type;
92 svd::Driver driver; 92 svd::Driver m_driver;
93 93
94 T left_sm; 94 T left_sm;
95 DM_T sigma; 95 DM_T sigma;
96 T right_sm; 96 T right_sm;
97 97