Mercurial > octave
diff liboctave/numeric/svd.h @ 22228:4afe3705ea75
svd: do not shadow member variables with local variables.
* liboctave/numeric/svd.cc, liboctave/numeric/svd.h: there was no issue
with current code because member variables never change after construction.
Still, it's not good practice and the compilers will warn about it.
| author | Carnë Draug <carandraug@octave.org> |
|---|---|
| date | Tue, 09 Aug 2016 00:21:36 +0100 |
| parents | 469c817eb256 |
| children | e43199618777 |
line wrap: on
line diff
--- a/liboctave/numeric/svd.h Sun Jun 12 19:38:22 2016 +1000 +++ b/liboctave/numeric/svd.h Tue Aug 09 00:21:36 2016 +0100 @@ -50,26 +50,26 @@ }; svd (void) - : type (), driver (), left_sm (), sigma (), right_sm () + : m_type (), m_driver (), left_sm (), sigma (), right_sm () { } svd (const T& a, svd::Type type = svd::Type::std, svd::Driver driver = svd::Driver::GESVD); svd (const svd& a) - : type (a.type), driver (a.driver), left_sm (a.left_sm), sigma (a.sigma), - right_sm (a.right_sm) + : m_type (a.m_type), m_driver (a.m_driver), left_sm (a.left_sm), + sigma (a.sigma), right_sm (a.right_sm) { } svd& operator = (const svd& a) { if (this != &a) { - type = a.type; + m_type = a.m_type; left_sm = a.left_sm; sigma = a.sigma; right_sm = a.right_sm; - driver = a.driver; + m_driver = a.m_driver; } return *this; @@ -88,8 +88,8 @@ typedef typename T::element_type P; typedef typename DM_T::element_type DM_P; - svd::Type type; - svd::Driver driver; + svd::Type m_type; + svd::Driver m_driver; T left_sm; DM_T sigma;