Mercurial > octave

comparison libinterp/dldfcn/audioread.cc @ 25572:64bcc3ab2f6a stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Write audio OGG files in smaller chunk sizes (bug #54280). This works around a bug is libvorbis. * audioread.cc (Faudiowrite): Change chunk size that data is written in to 2^20 rather than 2^21.
author Rik <rik@octave.org>
date Tue, 10 Jul 2018 13:08:04 -0700
parents 6652d3823428
children 305147646ca9
comparison
equal deleted inserted replaced
25570:da2b38b7a077 25572:64bcc3ab2f6a
330 330
331 if (ext == "ogg") 331 if (ext == "ogg")
332 { 332 {
333 info.format = SF_FORMAT_VORBIS; 333 info.format = SF_FORMAT_VORBIS;
334 334
335 // FIXME: there seems to be a bug writing ogg files in one shot 335 // FIXME: There seems to be a bug writing ogg files in one shot that
336 // that causes a segfault. Breaking it up into a series of 336 // causes a segfault: https://bugs.debian.org/760898.
337 // smaller chunks seems to avoid the problem and produce valid 337 // Breaking it up into a series of smaller chunks appears to avoid the
338 // files. 338 // problem and produces valid files.
339 chunk_size = 0x1FFFFE; 339 chunk_size = 0x100000;
340 } 340 }
341 else 341 else
342 info.format = SF_FORMAT_PCM_16; 342 info.format = SF_FORMAT_PCM_16;
343 343
344 info.channels = audio.columns (); 344 info.channels = audio.columns ();