Mercurial > octave

diff libinterp/dldfcn/audioread.cc @ 25572:64bcc3ab2f6a stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Write audio OGG files in smaller chunk sizes (bug #54280). This works around a bug is libvorbis. * audioread.cc (Faudiowrite): Change chunk size that data is written in to 2^20 rather than 2^21.
author Rik <rik@octave.org>
date Tue, 10 Jul 2018 13:08:04 -0700
parents 6652d3823428
children 305147646ca9
line wrap: on
line diff
--- a/libinterp/dldfcn/audioread.cc	Sun May 13 12:37:37 2018 +0200
+++ b/libinterp/dldfcn/audioread.cc	Tue Jul 10 13:08:04 2018 -0700
@@ -332,11 +332,11 @@
     {
       info.format = SF_FORMAT_VORBIS;
 
-      // FIXME: there seems to be a bug writing ogg files in one shot
-      // that causes a segfault.  Breaking it up into a series of
-      // smaller chunks seems to avoid the problem and produce valid
-      // files.
-      chunk_size = 0x1FFFFE;
+      // FIXME: There seems to be a bug writing ogg files in one shot that
+      // causes a segfault: https://bugs.debian.org/760898.
+      // Breaking it up into a series of smaller chunks appears to avoid the
+      // problem and produces valid files.
+      chunk_size = 0x100000;
     }
   else
     info.format = SF_FORMAT_PCM_16;