diff libgui/src/files-dock-widget.cc @ 31621:0645ea65ca6b

handle icons and themes in gui_settings class, not resource_manager * resource-manager.h, resource-manager.cc (resource_manager::config_icon_theme, resource_manager::icon): Move funtcions to gui-settings.h and gui-settings.cc. * Canvas.cc, QTerminal.cc, documentation-bookmarks.cc, documentation.cc, dw-main-window.cc, files-dock-widget.cc, find-files-dialog.cc, gui-settings.cc, gui-settings.h, history-dock-widget.cc, file-editor.cc, main-window.cc, octave-dock-widget.cc, octave-qobject.cc, qt-interpreter-events.cc, resource-manager.cc, resource-manager.h, variable-editor.cc: Change all uses.
author John W. Eaton <jwe@octave.org>
date Fri, 02 Dec 2022 18:43:12 -0500
parents ad014fc78bd6
children 431f80aba37a
line wrap: on
line diff
--- a/libgui/src/files-dock-widget.cc	Fri Dec 02 18:31:30 2022 -0500
+++ b/libgui/src/files-dock-widget.cc	Fri Dec 02 18:43:12 2022 -0500
@@ -227,20 +227,21 @@
     QSizePolicy sizePol (QSizePolicy::Expanding, QSizePolicy::Preferred);
     m_current_directory->setSizePolicy (sizePol);
 
-    resource_manager& rmgr = m_octave_qobj.get_resource_manager ();
+    gui_settings settings;
 
     QAction *directory_up_action
-      = new QAction (rmgr.icon ("folder-up", false, "go-up"), "", m_navigation_tool_bar);
+      = new QAction (settings.icon ("folder-up", false, "go-up"), "",
+                     m_navigation_tool_bar);
     directory_up_action->setToolTip (tr ("One directory up"));
 
     m_sync_browser_directory_action
-      = new QAction (rmgr.icon ("go-first"), tr ("Show Octave directory"),
+      = new QAction (settings.icon ("go-first"), tr ("Show Octave directory"),
                      m_navigation_tool_bar);
     m_sync_browser_directory_action->setToolTip (tr ("Go to current Octave directory"));
     m_sync_browser_directory_action->setEnabled (false);
 
     m_sync_octave_directory_action
-      = new QAction (rmgr.icon ("go-last"), tr ("Set Octave directory"),
+      = new QAction (settings.icon ("go-last"), tr ("Set Octave directory"),
                      m_navigation_tool_bar);
     m_sync_octave_directory_action->setToolTip (tr ("Set Octave directory to current browser directory"));
     m_sync_octave_directory_action->setEnabled (false);
@@ -248,7 +249,7 @@
     QToolButton *popdown_button = new QToolButton ();
     popdown_button->setToolTip (tr ("Actions on current directory"));
     QMenu *popdown_menu = new QMenu ();
-    popdown_menu->addAction (rmgr.icon ("user-home"),
+    popdown_menu->addAction (settings.icon ("user-home"),
                              tr ("Show Home Directory"), this,
                              SLOT (popdownmenu_home (bool)));
     popdown_menu->addAction (m_sync_browser_directory_action);
@@ -256,22 +257,23 @@
     popdown_button->setMenu (popdown_menu);
     popdown_button->setPopupMode (QToolButton::InstantPopup);
     popdown_button->setDefaultAction (
-        new QAction (rmgr.icon ("folder-settings", false, "applications-system"),
-        "", m_navigation_tool_bar));
+        new QAction (settings.icon ("folder-settings", false,
+                                    "applications-system"),
+                     "", m_navigation_tool_bar));
 
     popdown_menu->addSeparator ();
-    popdown_menu->addAction (rmgr.icon ("folder"),
+    popdown_menu->addAction (settings.icon ("folder"),
                              tr ("Set Browser Directory..."),
                              this, &files_dock_widget::popdownmenu_search_dir);
     popdown_menu->addSeparator ();
-    popdown_menu->addAction (rmgr.icon ("edit-find"),
+    popdown_menu->addAction (settings.icon ("edit-find"),
                              tr ("Find Files..."),
                              this, &files_dock_widget::popdownmenu_findfiles);
     popdown_menu->addSeparator ();
-    popdown_menu->addAction (rmgr.icon ("document-new"),
+    popdown_menu->addAction (settings.icon ("document-new"),
                              tr ("New File..."),
                              this, &files_dock_widget::popdownmenu_newfile);
-    popdown_menu->addAction (rmgr.icon ("folder-new"),
+    popdown_menu->addAction (settings.icon ("folder-new"),
                              tr ("New Directory..."),
                              this, &files_dock_widget::popdownmenu_newdir);
 
@@ -286,8 +288,6 @@
     connect (m_sync_browser_directory_action, &QAction::triggered,
              this, &files_dock_widget::do_sync_browser_directory);
 
-    gui_settings settings;
-
     // Create the QFileSystemModel starting in the desired directory
     QDir startup_dir;  // take current dir
 
@@ -650,10 +650,10 @@
                                 | QItemSelectionModel::Rows);
           }
 
-        resource_manager& rmgr = m_octave_qobj.get_resource_manager ();
+        gui_settings settings;
 
         // construct the context menu depending on item
-        menu.addAction (rmgr.icon ("document-open"), tr ("Open"),
+        menu.addAction (settings.icon ("document-open"), tr ("Open"),
                         this, &files_dock_widget::contextmenu_open);
 
         if (info.isDir ())
@@ -670,7 +670,7 @@
                         this, &files_dock_widget::contextmenu_copy_selection);
 
         if (info.isFile () && info.suffix () == "m")
-          menu.addAction (rmgr.icon ("media-playback-start"), tr ("Run"),
+          menu.addAction (settings.icon ("media-playback-start"), tr ("Run"),
                           this, &files_dock_widget::contextmenu_run);
 
         if (info.isFile ())
@@ -680,7 +680,7 @@
         if (info.isDir ())
           {
             menu.addSeparator ();
-            menu.addAction (rmgr.icon ("go-first"), tr ("Set Current Directory"),
+            menu.addAction (settings.icon ("go-first"), tr ("Set Current Directory"),
                             this, &files_dock_widget::contextmenu_setcurrentdir);
 
             QMenu *add_path_menu = menu.addMenu (tr ("Add to Path"));
@@ -699,21 +699,21 @@
 
             menu.addSeparator ();
 
-            menu.addAction (rmgr.icon ("edit-find"), tr ("Find Files..."),
+            menu.addAction (settings.icon ("edit-find"), tr ("Find Files..."),
                             this, &files_dock_widget::contextmenu_findfiles);
           }
 
         menu.addSeparator ();
         menu.addAction (m_rename_action);
-        menu.addAction (rmgr.icon ("edit-delete"), tr ("Delete..."),
+        menu.addAction (settings.icon ("edit-delete"), tr ("Delete..."),
                         this, &files_dock_widget::contextmenu_delete);
 
         if (info.isDir ())
           {
             menu.addSeparator ();
-            menu.addAction (rmgr.icon ("document-new"), tr ("New File..."),
+            menu.addAction (settings.icon ("document-new"), tr ("New File..."),
                             this, &files_dock_widget::contextmenu_newfile);
-            menu.addAction (rmgr.icon ("folder-new"), tr ("New Directory..."),
+            menu.addAction (settings.icon ("folder-new"), tr ("New Directory..."),
                             this, &files_dock_widget::contextmenu_newdir);
           }