Mercurial > octave
diff scripts/statistics/base/skewness.m @ 21309:7fbecef105ca
Allow statistics functions to work over non-existent dimension (bug #33523).
* var.m, center.m, kurtosis.m, mean.m, meansq.m, median.m, moment.m,
skewness.m, std.m: Remove check for input dimension being within the range
of ndims (x). Add BIST tests for new behavior and update input validation
tests.
| author | Rik <rik@octave.org> |
|---|---|
| date | Fri, 19 Feb 2016 21:27:03 -0800 |
| parents | c53bfd6d8e08 |
| children | bac0d6f07a3e |
line wrap: on
line diff
--- a/scripts/statistics/base/skewness.m Fri Feb 19 09:40:59 2016 -0800 +++ b/scripts/statistics/base/skewness.m Fri Feb 19 21:27:03 2016 -0800 @@ -92,10 +92,8 @@ if (nargin < 2 || isempty (flag)) flag = 1; # default: do not use the "bias corrected" version - else - if (! isscalar (flag) || (flag != 0 && flag != 1)) - error ("skewness: FLAG must be 0 or 1"); - endif + elseif (! isscalar (flag) || (flag != 0 && flag != 1)) + error ("skewness: FLAG must be 0 or 1"); endif nd = ndims (x); @@ -104,12 +102,12 @@ ## Find the first non-singleton dimension. (dim = find (sz > 1, 1)) || (dim = 1); else - if (!(isscalar (dim) && dim == fix (dim)) || !(1 <= dim && dim <= nd)) + if (! (isscalar (dim) && dim == fix (dim) && dim > 0)) error ("skewness: DIM must be an integer and a valid dimension"); endif endif - n = sz(dim); + n = size (x, dim); sz(dim) = 1; x = center (x, dim); # center also promotes integer, logical to double @@ -136,6 +134,7 @@ %!assert (skewness ([-1, 0, 2]) > 0) %!assert (skewness ([-3, 0, 1]) == -1 * skewness ([-1, 0, 3])) %!assert (skewness (ones (3, 5)), NaN (1, 5)) +%!assert (skewness (1, [], 3), NaN) %!test %! x = [0; 0; 0; 1]; @@ -166,5 +165,4 @@ %!error <DIM must be an integer> skewness (1, [], ones (2,2)) %!error <DIM must be an integer> skewness (1, [], 1.5) %!error <DIM must be .* a valid dimension> skewness (1, [], 0) -%!error <DIM must be .* a valid dimension> skewness (1, [], 3)