Mercurial > octave

changeset 27171:196dfb42f3e9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
eliminate unnecessary call to ios::init * procstream.h (procstreambase::pb_init): Delete. (procstreambase::procstreambase): Don't call pb_init.
author John W. Eaton <jwe@octave.org>
date Tue, 11 Jun 2019 12:50:34 -0500
parents 7206b8c222eb
children b0abae0bd94b
files libinterp/corefcn/procstream.cc libinterp/corefcn/procstream.h
diffstat 2 files changed, 1 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/libinterp/corefcn/procstream.cc	Mon Jun 10 20:45:25 2019 +0200
+++ b/libinterp/corefcn/procstream.cc	Tue Jun 11 12:50:34 2019 -0500
@@ -30,16 +30,12 @@
 
 procstreambase::procstreambase (const std::string& command, int mode)
 {
-  pb_init ();
-
   if (! pb.open (command.c_str (), mode))
     std::ios::setstate (std::ios::badbit);
 }
 
 procstreambase::procstreambase (const char *command, int mode)
 {
-  pb_init ();
-
   if (! pb.open (command, mode))
     std::ios::setstate (std::ios::badbit);
 }
--- a/libinterp/corefcn/procstream.h	Mon Jun 10 20:45:25 2019 +0200
+++ b/libinterp/corefcn/procstream.h	Tue Jun 11 12:50:34 2019 -0500
@@ -38,7 +38,7 @@
 {
 public:
 
-  procstreambase (void) : pb () { pb_init (); }
+  procstreambase (void) : pb () { }
 
   procstreambase (const std::string& name, int mode);
 
@@ -63,8 +63,6 @@
 
   octave_procbuf pb;
 
-  void pb_init (void) { init (&pb); }
-
   procstreambase (const procstreambase&);
 
   procstreambase& operator = (const procstreambase&);