Mercurial > octave

changeset 30035:9fa1d8dd3a23

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
maint: Reverse "m_" conversions of function parameters in cset e156fce82e00. * chol.cc: Reverse accidental conversion of function parameters "is_upper" to "m_is_upper".
author Rik <rik@octave.org>
date Tue, 24 Aug 2021 17:50:48 -0700
parents 0edbd0efb69d
children 80373844f8b2
files liboctave/numeric/chol.cc
diffstat 1 files changed, 12 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/liboctave/numeric/chol.cc	Tue Aug 24 17:44:10 2021 -0700
+++ b/liboctave/numeric/chol.cc	Tue Aug 24 17:50:48 2021 -0700
@@ -50,7 +50,7 @@
 namespace octave
 {
   static Matrix
-  chol2inv_internal (const Matrix& r, bool m_is_upper = true)
+  chol2inv_internal (const Matrix& r, bool is_upper = true)
   {
     Matrix retval;
 
@@ -66,7 +66,7 @@
     Matrix tmp = r;
     double *v = tmp.fortran_vec ();
 
-    if (m_is_upper)
+    if (is_upper)
       F77_XFCN (dpotri, DPOTRI, (F77_CONST_CHAR_ARG2 ("U", 1), n,
                                  v, n, info
                                  F77_CHAR_ARG_LEN (1)));
@@ -82,7 +82,7 @@
 
     if (n > 1)
       {
-        if (m_is_upper)
+        if (is_upper)
           for (octave_idx_type j = 0; j < r_nc; j++)
             for (octave_idx_type i = j+1; i < r_nr; i++)
               tmp.xelem (i, j) = tmp.xelem (j, i);
@@ -98,7 +98,7 @@
   }
 
   static FloatMatrix
-  chol2inv_internal (const FloatMatrix& r, bool m_is_upper = true)
+  chol2inv_internal (const FloatMatrix& r, bool is_upper = true)
   {
     FloatMatrix retval;
 
@@ -114,7 +114,7 @@
     FloatMatrix tmp = r;
     float *v = tmp.fortran_vec ();
 
-    if (m_is_upper)
+    if (is_upper)
       F77_XFCN (spotri, SPOTRI, (F77_CONST_CHAR_ARG2 ("U", 1), n,
                                  v, n, info
                                  F77_CHAR_ARG_LEN (1)));
@@ -130,7 +130,7 @@
 
     if (n > 1)
       {
-        if (m_is_upper)
+        if (is_upper)
           for (octave_idx_type j = 0; j < r_nc; j++)
             for (octave_idx_type i = j+1; i < r_nr; i++)
               tmp.xelem (i, j) = tmp.xelem (j, i);
@@ -146,7 +146,7 @@
   }
 
   static ComplexMatrix
-  chol2inv_internal (const ComplexMatrix& r, bool m_is_upper = true)
+  chol2inv_internal (const ComplexMatrix& r, bool is_upper = true)
   {
     ComplexMatrix retval;
 
@@ -161,7 +161,7 @@
 
     ComplexMatrix tmp = r;
 
-    if (m_is_upper)
+    if (is_upper)
       F77_XFCN (zpotri, ZPOTRI, (F77_CONST_CHAR_ARG2 ("U", 1), n,
                                  F77_DBLE_CMPLX_ARG (tmp.fortran_vec ()), n, info
                                  F77_CHAR_ARG_LEN (1)));
@@ -175,7 +175,7 @@
 
     if (n > 1)
       {
-        if (m_is_upper)
+        if (is_upper)
           for (octave_idx_type j = 0; j < r_nc; j++)
             for (octave_idx_type i = j+1; i < r_nr; i++)
               tmp.xelem (i, j) = std::conj (tmp.xelem (j, i));
@@ -191,7 +191,7 @@
   }
 
   static FloatComplexMatrix
-  chol2inv_internal (const FloatComplexMatrix& r, bool m_is_upper = true)
+  chol2inv_internal (const FloatComplexMatrix& r, bool is_upper = true)
   {
     FloatComplexMatrix retval;
 
@@ -206,7 +206,7 @@
 
     FloatComplexMatrix tmp = r;
 
-    if (m_is_upper)
+    if (is_upper)
       F77_XFCN (cpotri, CPOTRI, (F77_CONST_CHAR_ARG2 ("U", 1), n,
                                  F77_CMPLX_ARG (tmp.fortran_vec ()), n, info
                                  F77_CHAR_ARG_LEN (1)));
@@ -220,7 +220,7 @@
 
     if (n > 1)
       {
-        if (m_is_upper)
+        if (is_upper)
           for (octave_idx_type j = 0; j < r_nc; j++)
             for (octave_idx_type i = j+1; i < r_nr; i++)
               tmp.xelem (i, j) = std::conj (tmp.xelem (j, i));