Mercurial > octave

changeset 31790:abe72b9464d6 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
avoid calls to warning from GUI thread (bug #63714) * Table.cc (qStringValueFor, Table::sendCellEditCallback): Don't call warning.
author John W. Eaton <jwe@octave.org>
date Sun, 29 Jan 2023 13:03:23 -0500
parents b482ed13ac1a
children 5cb96bc0adc8 30b6a8be7128
files libgui/graphics/Table.cc
diffstat 1 files changed, 2 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/libgui/graphics/Table.cc	Fri Jan 27 14:27:10 2023 -0800
+++ b/libgui/graphics/Table.cc	Sun Jan 29 13:03:23 2023 -0500
@@ -317,11 +317,8 @@
     }
   else
     {
-      std::stringstream warn_string;
-      warn_string << "Unknown conversion for datatype " << val.class_name ()
-                  << " to " << format
-                  << " for value " << val.string_value (true);
-      warning ("%s", warn_string.str ().c_str ());
+      // FIXME: Should we warn about the unknown conversion?  If so,
+      // how?  We can't just call Octave's warning function here.
 
       text = Utils::fromStdString (val.string_value (true));
     }
@@ -560,8 +557,6 @@
       emit gh_callback_event (m_handle, "celleditcallback",
                               cellEditCallbackEventObject);
     }
-  else if (error.string_value ().length () > 0)
-    warning ("%s", error.string_value ().c_str ());
 }
 
 void