annotate tests/test-userspec.c @ 40219:53cae2062bf4

test-userspec.c: don't print NULL * tests/test-userspec.c (main): A test release of gcc, 9.0.1 20190310, warned that this test would attempt to print a NULL pointer via a %s printf format. Fix that and remove the unnecessary preceding "!diag" conjunct. Also add a comment.
author Jim Meyering <meyering@fb.com>
date Sat, 09 Mar 2019 21:38:03 -0800
parents b06060465f09
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
1 /* Test userspec.c
40057
b06060465f09 maint: Run 'make update-copyright'
Paul Eggert <eggert@cs.ucla.edu>
parents: 19484
diff changeset
2 Copyright (C) 2009-2019 Free Software Foundation, Inc.
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
3
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
4 This program is free software: you can redistribute it and/or modify
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
5 it under the terms of the GNU General Public License as published by
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
6 the Free Software Foundation; either version 3 of the License, or
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
7 (at your option) any later version.
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
8
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
9 This program is distributed in the hope that it will be useful,
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
10 but WITHOUT ANY WARRANTY; without even the implied warranty of
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
11 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
12 GNU General Public License for more details.
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
13
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
14 You should have received a copy of the GNU General Public License
19190
9759915b2aca all: prefer https: URLs
Paul Eggert <eggert@cs.ucla.edu>
parents: 18626
diff changeset
15 along with this program. If not, see <https://www.gnu.org/licenses/>. */
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
16
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
17 /* Written by Jim Meyering. */
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
18
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
19 #include <config.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
20
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
21 #include "userspec.h"
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
22
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
23 #include <stdio.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
24 #include <assert.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
25 #include <string.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
26 #include <stdlib.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
27 #include <stdbool.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
28 #include <sys/types.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
29 #include <pwd.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
30 #include <grp.h>
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
31
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
32 #include "xalloc.h"
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
33
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
34 #define ARRAY_CARDINALITY(Array) (sizeof (Array) / sizeof *(Array))
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
35
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
36 struct test
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
37 {
12820
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
38 const char *in;
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
39 uid_t uid;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
40 gid_t gid;
12820
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
41 const char *user_name;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
42 const char *group_name;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
43 const char *result;
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
44 };
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
45
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
46 static struct test T[] =
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
47 {
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
48 { "", -1, -1, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
49 { ":", -1, -1, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
50 { "+0:+0", 0, 0, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
51 { ":+1", -1, 1, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
52 { "+1", 1, -1, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
53 { ":+0", -1, 0, "", "", NULL},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
54 { "+22:+42", 22, 42, "", "", NULL},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
55 /* (uint32_t)-1 should be invalid everywhere */
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
56 { "+4294967295:+4294967295", 0, 0, NULL, NULL, "invalid user"},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
57 /* likewise, but with only the group being invalid */
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
58 { "+0:+4294967295", 0, 0, NULL, NULL, "invalid group"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
59 { ":+4294967295", 0, 0, NULL, NULL, "invalid group"},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
60 /* and only the user being invalid */
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
61 { "+4294967295:+0", 0, 0, NULL, NULL, "invalid user"},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
62 /* and using 2^32 */
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
63 { "+4294967296:+4294967296", 0, 0, NULL, NULL, "invalid user"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
64 { "+0:+4294967296", 0, 0, NULL, NULL, "invalid group"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
65 { ":+4294967296", 0, 0, NULL, NULL, "invalid group"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
66 { "+4294967296:+0", 0, 0, NULL, NULL, "invalid user"},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
67 /* numeric user and no group is invalid */
17729
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
68 { "+4294967295:", 0, 0, NULL, NULL, "invalid spec"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
69 { "+4294967296:", 0, 0, NULL, NULL, "invalid spec"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
70 { "+1:", 0, 0, NULL, NULL, "invalid spec"},
874a5cc03904 test-userspec: don't look up numeric user names
Jim Meyering <meyering@fb.com>
parents: 17576
diff changeset
71 { "+0:", 0, 0, NULL, NULL, "invalid spec"},
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
72
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
73 /* "username:" must expand to UID:GID where GID is username's login group */
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
74 /* Add an entry like the following to the table, if possible.
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
75 { "U_NAME:", UID,GID, U_NAME, G_NAME, NULL}, */
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
76 { NULL, 0, 0, NULL, NULL, ""}, /* place-holder */
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
77
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
78 { NULL, 0, 0, NULL, NULL, ""}
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
79 };
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
80
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
81 #define STREQ(a, b) (strcmp (a, b) == 0)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
82
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
83 static char const *
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
84 maybe_null (char const *s)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
85 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
86 return s ? s : "NULL";
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
87 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
88
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
89 static bool
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
90 same_diag (char const *s, char const *t)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
91 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
92 if (s == NULL && t == NULL)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
93 return true;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
94 if (s == NULL || t == NULL)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
95 return false;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
96 return STREQ (s, t);
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
97 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
98
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
99 int
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
100 main (void)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
101 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
102 unsigned int i;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
103 int fail = 0;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
104
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
105 /* Find a UID that has both a user name and login group name,
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
106 but skip UID 0. */
12820
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
107 {
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
108 uid_t uid;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
109 for (uid = 1200; 0 < uid; uid--)
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
110 {
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
111 struct group *gr;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
112 struct passwd *pw = getpwuid (uid);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
113 unsigned int j;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
114 size_t len;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
115 if (!pw || !pw->pw_name || !(gr = getgrgid (pw->pw_gid)) || !gr->gr_name)
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
116 continue;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
117 j = ARRAY_CARDINALITY (T) - 2;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
118 assert (T[j].in == NULL);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
119 assert (T[j+1].in == NULL);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
120 len = strlen (pw->pw_name);
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
121
12820
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
122 /* Store "username:" in T[j].in. */
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
123 {
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
124 char *t = xmalloc (len + 1 + 1);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
125 memcpy (t, pw->pw_name, len);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
126 t[len] = ':';
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
127 t[len+1] = '\0';
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
128 T[j].in = t;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
129 }
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
130
12820
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
131 T[j].uid = uid;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
132 T[j].gid = gr->gr_gid;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
133 T[j].user_name = xstrdup (pw->pw_name);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
134 T[j].group_name = xstrdup (gr->gr_name);
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
135 T[j].result = NULL;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
136 break;
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
137 }
c26a1084fbae test-userspec.c: avoid compiler warnings
Jim Meyering <meyering@redhat.com>
parents: 12769
diff changeset
138 }
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
139
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
140 for (i = 0; T[i].in; i++)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
141 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
142 uid_t uid = (uid_t) -1;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
143 gid_t gid = (gid_t) -1;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
144 char *user_name;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
145 char *group_name;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
146 char const *diag = parse_user_spec (T[i].in, &uid, &gid,
15338
03e2cd1cbbe8 maint: indent with spaces, not TABs, and add a rule to check this
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
147 &user_name, &group_name);
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
148 free (user_name);
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
149 free (group_name);
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
150 if (!same_diag (diag, T[i].result))
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
151 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
152 printf ("%s return value mismatch: got %s, expected %s\n",
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
153 T[i].in, maybe_null (diag), maybe_null (T[i].result));
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
154 fail = 1;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
155 continue;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
156 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
157
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
158 if (diag)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
159 continue;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
160
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
161 if (uid != T[i].uid || gid != T[i].gid)
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
162 {
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
163 printf ("%s mismatch (-: expected uid,gid; +:actual)\n"
15338
03e2cd1cbbe8 maint: indent with spaces, not TABs, and add a rule to check this
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
164 "-%3lu,%3lu\n+%3lu,%3lu\n",
03e2cd1cbbe8 maint: indent with spaces, not TABs, and add a rule to check this
Jim Meyering <meyering@redhat.com>
parents: 14079
diff changeset
165 T[i].in,
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
166 (unsigned long int) T[i].uid,
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
167 (unsigned long int) T[i].gid,
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
168 (unsigned long int) uid,
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
169 (unsigned long int) gid);
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
170 fail = 1;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
171 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
172
40219
53cae2062bf4 test-userspec.c: don't print NULL
Jim Meyering <meyering@fb.com>
parents: 40057
diff changeset
173 if (!T[i].result)
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
174 continue;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
175
40219
53cae2062bf4 test-userspec.c: don't print NULL
Jim Meyering <meyering@fb.com>
parents: 40057
diff changeset
176 /* Expected a non-NULL result diagnostic, yet got NULL. */
53cae2062bf4 test-userspec.c: don't print NULL
Jim Meyering <meyering@fb.com>
parents: 40057
diff changeset
177 diag = "NULL";
53cae2062bf4 test-userspec.c: don't print NULL
Jim Meyering <meyering@fb.com>
parents: 40057
diff changeset
178 printf ("%s diagnostic mismatch (-: expected diagnostic; +:actual)\n"
18269
5b63f09aa398 test-userspec.c: do not trigger gcc's new -Wmisleading-indentation
Jim Meyering <meyering@fb.com>
parents: 18189
diff changeset
179 "-%s\n+%s\n", T[i].in, T[i].result, diag);
5b63f09aa398 test-userspec.c: do not trigger gcc's new -Wmisleading-indentation
Jim Meyering <meyering@fb.com>
parents: 18189
diff changeset
180 fail = 1;
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
181 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
182
17490
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
183 /* Ensure NULL parameters are ignored. */
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
184 {
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
185 uid_t uid = (uid_t) -1;
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
186 char const *diag = parse_user_spec ("", &uid, NULL, NULL, NULL);
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
187 if (diag)
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
188 {
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
189 printf ("unexpected error: %s\n", diag);
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
190 fail = 1;
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
191 }
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
192 }
d618904c6748 userspec: support optional parameters to parse_user_spec()
Pádraig Brady <P@draigBrady.com>
parents: 17249
diff changeset
193
12769
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
194 return fail;
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
195 }
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
196
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
197 /*
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
198 Local Variables:
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
199 indent-tabs-mode: nil
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
200 End:
5663df33b7f1 userspec-tests: test the userspec module
Jim Meyering <meyering@redhat.com>
parents:
diff changeset
201 */