changeset 17722:20a6211f5d73

announce-gen: avoid perl warnings * build-aux/announce-gen: add two minor checks to avoid "use of uninitialized value" warnings when command-line parameters are missing.
author Assaf Gordon <assafgordon@gmail.com>
date Wed, 09 Jul 2014 19:18:40 -0400
parents 3431efc25f3c
children 9edabe80a556
files ChangeLog build-aux/announce-gen
diffstat 2 files changed, 10 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Thu Jul 10 19:42:02 2014 +0100
+++ b/ChangeLog	Wed Jul 09 19:18:40 2014 -0400
@@ -1,3 +1,10 @@
+2014-07-10  Assaf Gordon  <assafgordon@gmail.com>
+
+	announce-gen: avoid perl warnings
+	* build-aux/announce-gen: add two minor checks to avoid
+	"use of uninitialized value" warnings when command-line parameters are
+	missing.
+
 2014-07-10  Assaf Gordon  <assafgordon@gmail.com>
 
 	localename: avoid -Wsuggest-attribute={const,pure} warnings
--- a/build-aux/announce-gen	Thu Jul 10 19:42:02 2014 +0100
+++ b/build-aux/announce-gen	Wed Jul 09 19:18:40 2014 -0400
@@ -416,14 +416,15 @@
   @url_dir_list
     or (warn "URL directory name(s) not specified\n"), $fail = 1;
 
-  my @tool_list = split ',', $bootstrap_tools;
+  my @tool_list = split ',', $bootstrap_tools
+    if $bootstrap_tools;
 
   grep (/^gnulib$/, @tool_list) ^ defined $gnulib_version
     and (warn "when specifying gnulib as a tool, you must also specify\n"
         . "--gnulib-version=V, where V is the result of running git describe\n"
         . "in the gnulib source directory.\n"), $fail = 1;
 
-  exists $valid_release_types{$release_type}
+  !$release_type || exists $valid_release_types{$release_type}
     or (warn "'$release_type': invalid release type\n"), $fail = 1;
 
   @ARGV