changeset 17727:2539dbbdf52a

announce-gen: avoid failure when Digest::SHA is installed When Digest::SHA is available, Digest::SHA1 is not loaded and thus Digest::SHA1->new in print_checksums fails. * build-aux/announce-gen (digest_classes): New associative array for available message digest implementations. (print_locations): Use it.
author Daiki Ueno <ueno@gnu.org>
date Tue, 09 Jul 2013 15:54:48 +0900
parents 71758fd65b02
children 61d8a212a342
files ChangeLog build-aux/announce-gen
diffstat 2 files changed, 18 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Sat Jul 12 13:57:21 2014 +0100
+++ b/ChangeLog	Tue Jul 09 15:54:48 2013 +0900
@@ -1,3 +1,12 @@
+2014-07-14  Daiki Ueno  <ueno@gnu.org>
+
+	announce-gen: avoid failure when Digest::SHA is installed
+	When Digest::SHA is available, Digest::SHA1 is not loaded and thus
+	Digest::SHA1->new in print_checksums fails.
+	* build-aux/announce-gen (digest_classes): New associative array
+	for available message digest implementations.
+	(print_locations): Use it.
+
 2014-07-13  Pádraig Brady  <P@draigBrady.com>
 
 	gettext: revert "update macros to version 0.19"
--- a/build-aux/announce-gen	Sat Jul 12 13:57:21 2014 +0100
+++ b/build-aux/announce-gen	Tue Jul 09 15:54:48 2013 +0900
@@ -3,7 +3,7 @@
     if 0;
 # Generate a release announcement message.
 
-my $VERSION = '2012-06-08 06:53'; # UTC
+my $VERSION = '2013-07-09 06:39'; # UTC
 # The definition above must lie within the first 8 lines in order
 # for the Emacs time-stamp write hook (at end) to update it.
 # If you change this file with Emacs, please let the write hook
@@ -29,15 +29,18 @@
 use strict;
 
 use Getopt::Long;
-use Digest::MD5;
-eval { require Digest::SHA; }
-  or eval 'use Digest::SHA1';
 use POSIX qw(strftime);
 
 (my $ME = $0) =~ s|.*/||;
 
 my %valid_release_types = map {$_ => 1} qw (alpha beta stable);
 my @archive_suffixes = ('tar.gz', 'tar.bz2', 'tar.lzma', 'tar.xz');
+my %digest_classes =
+  (
+   'md5' => (eval { require Digest::MD5; } and 'Digest::MD5'),
+   'sha1' => ((eval { require Digest::SHA; } and 'Digest::SHA')
+              or (eval { require Digest::SHA1; } and 'Digest::SHA1'))
+  );
 my $srcdir = '.';
 
 sub usage ($)
@@ -157,15 +160,13 @@
 
   foreach my $meth (qw (md5 sha1))
     {
+      my $class = $digest_classes{$meth} or next;
       foreach my $f (@file)
         {
           open IN, '<', $f
             or die "$ME: $f: cannot open for reading: $!\n";
           binmode IN;
-          my $dig =
-            ($meth eq 'md5'
-             ? Digest::MD5->new->addfile(*IN)->hexdigest
-             : Digest::SHA1->new->addfile(*IN)->hexdigest);
+          my $dig = $class->new->addfile(*IN)->hexdigest;
           close IN;
           print "$dig  $f\n";
         }