Mercurial > gnulib
changeset 18311:79b2ca5b5982
git-version-gen: avoid undefined shift
Problem reported by Mosè Giordano in:
http://lists.gnu.org/archive/html/bug-gnulib/2016-05/msg00012.html
* build-aux/git-version-gen: Avoid undefined behavior if invoked
with --prefix or --fallback but without a later argument. While
we're at it, omit unnecessary quotes.
| author | Paul Eggert <eggert@cs.ucla.edu> |
|---|---|
| date | Sun, 08 May 2016 11:38:22 -0700 |
| parents | 4b44cef16a45 |
| children | ffb17b069818 |
| files | ChangeLog build-aux/git-version-gen |
| diffstat | 2 files changed, 12 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Sun May 08 09:11:48 2016 -0700 +++ b/ChangeLog Sun May 08 11:38:22 2016 -0700 @@ -1,3 +1,12 @@ +2016-05-08 Paul Eggert <eggert@cs.ucla.edu> + + git-version-gen: avoid undefined shift + Problem reported by Mosè Giordano in: + http://lists.gnu.org/archive/html/bug-gnulib/2016-05/msg00012.html + * build-aux/git-version-gen: Avoid undefined behavior if invoked + with --prefix or --fallback but without a later argument. While + we're at it, omit unnecessary quotes. + 2016-05-04 Paul Eggert <eggert@cs.ucla.edu> glob: merge glibc changes into lib/glob.c
--- a/build-aux/git-version-gen Sun May 08 09:11:48 2016 -0700 +++ b/build-aux/git-version-gen Sun May 08 11:38:22 2016 -0700 @@ -1,6 +1,6 @@ #!/bin/sh # Print a version string. -scriptversion=2016-01-11.22; # UTC +scriptversion=2016-05-08.18; # UTC # Copyright (C) 2007-2016 Free Software Foundation, Inc. # @@ -101,8 +101,8 @@ case $1 in --help) echo "$usage"; exit 0;; --version) echo "$version"; exit 0;; - --prefix) shift; prefix="$1";; - --fallback) shift; fallback="$1";; + --prefix) shift; prefix=${1?};; + --fallback) shift; fallback=${1?};; -*) echo "$0: Unknown option '$1'." >&2 echo "$0: Try '--help' for more information." >&2