changeset 17662:9454e10c1c1e

getlogin-tests: avoid false failure under cron * tests/test-getlogin.c (main): Avoid verifying errnos from ttyname() since that's not what's under test. Centos 6 was seen to return EINVAL for ttyname() when run from cron.
author Pádraig Brady <P@draigBrady.com>
date Sun, 18 May 2014 02:48:03 +0100
parents ec75d04b657d
children 59df01cdab26
files ChangeLog tests/test-getlogin.c
diffstat 2 files changed, 7 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Fri May 16 16:03:14 2014 -0700
+++ b/ChangeLog	Sun May 18 02:48:03 2014 +0100
@@ -1,3 +1,10 @@
+2014-05-18  Pádraig Brady  <P@draigBrady.com>
+
+	getlogin-tests: avoid false failure under cron
+	* tests/test-getlogin.c (main): Avoid verifying errnos from ttyname()
+	since that's not what's under test.  Centos 6 was seen to return
+	EINVAL for ttyname() when run from cron.
+
 2014-05-16  Jim Meyering  <meyering@fb.com>
 
 	mbrtowc.m4: fix a comment typo
--- a/tests/test-getlogin.c	Fri May 16 16:03:14 2014 -0700
+++ b/tests/test-getlogin.c	Sun May 18 02:48:03 2014 +0100
@@ -75,8 +75,6 @@
     tty = ttyname (STDIN_FILENO);
     if (tty == NULL)
       {
-         ASSERT (errno == ENOTTY);
-
          fprintf (stderr, "Skipping test: stdin is not a tty.\n");
          return 77;
       }