Mercurial > gnulib
changeset 18340:ec48ad192f8f
printf-posix: Fix mingw build
Commit 54615b95ff238e235e806855efc46a9abad09f2e changed the regular
expression for detecting C symbol prefixes but forgot to qoute square
brackets in the command line arguments for grep. That way when
building with mingw the condition was false although it ought to be
true instead. In particular scenarios this led to the following
compile error:
Cannot export rpl_printf: symbol not found
Cannot export rpl_scanf: symbol not found
collect2: error: ld returned 1 exit status
Fix this by properly quoting square brackets.
| author | Martin Kletzander <mkletzan@redhat.com> |
|---|---|
| date | Mon, 04 Jul 2016 09:10:59 +0200 |
| parents | f1df88870b64 |
| children | 8d26ac570cf4 |
| files | ChangeLog m4/asm-underscore.m4 |
| diffstat | 2 files changed, 17 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Sun Jul 03 12:59:54 2016 +0200 +++ b/ChangeLog Mon Jul 04 09:10:59 2016 +0200 @@ -1,3 +1,19 @@ +2016-07-04 Martin Kletzander <mkletzan@redhat.com> + + printf-posix: Fix mingw build + Commit 54615b95ff238e235e806855efc46a9abad09f2e changed the regular + expression for detecting C symbol prefixes but forgot to qoute square + brackets in the command line arguments for grep. That way when + building with mingw the condition was false although it ought to be + true instead. In particular scenarios this led to the following + compile error: + + Cannot export rpl_printf: symbol not found + Cannot export rpl_scanf: symbol not found + collect2: error: ld returned 1 exit status + + Fix this by properly quoting square brackets. + 2016-07-03 Paul Eggert <eggert@cs.ucla.edu> mktime: call tzset as per POSIX
--- a/m4/asm-underscore.m4 Sun Jul 03 12:59:54 2016 +0200 +++ b/m4/asm-underscore.m4 Mon Jul 04 09:10:59 2016 +0200 @@ -29,7 +29,7 @@ EOF # Look for the assembly language name in the .s file. AC_TRY_COMMAND(${CC-cc} $CFLAGS $CPPFLAGS $gl_c_asm_opt conftest.c) >/dev/null 2>&1 - if LC_ALL=C grep -E '(^|[^a-zA-Z0-9_])_foo([^a-zA-Z0-9_]|$)' conftest.$gl_asmext >/dev/null; then + if LC_ALL=C grep -E '(^|[[^a-zA-Z0-9_]])_foo([[^a-zA-Z0-9_]]|$)' conftest.$gl_asmext >/dev/null; then gl_cv_prog_as_underscore=yes else gl_cv_prog_as_underscore=no