Mercurial > octave
changeset 33576:273cf7c2302a
fft.c: Remove FIXME and code after testing
fft.c: A FIXME note was pointing out the strangeness of checking for
negative dimensions. Running `hg annotate` on the file did not provide
an explanation. Removing it and testing it did not show any problems.
The loop has been removed along with the FIXME.
| author | Arun Giridhar <arungiridhar@gmail.com> |
|---|---|
| date | Sat, 11 May 2024 18:48:00 -0400 |
| parents | a2ea7c2222b8 |
| children | 2506c2d30b32 3e446791b7ef |
| files | libinterp/corefcn/fft.cc |
| diffstat | 1 files changed, 0 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/libinterp/corefcn/fft.cc Sat May 11 18:10:35 2024 -0400 +++ b/libinterp/corefcn/fft.cc Sat May 11 18:48:00 2024 -0400 @@ -79,13 +79,6 @@ dim = math::nint (dval) - 1; } - // FIXME: This seems strange and unnecessary (10/21/16). - // How would you ever arrive at an octave_value object without correct dims? - // We certainly don't make this check every other place in Octave. - for (octave_idx_type i = 0; i < ndims; i++) - if (dims(i) < 0) - return retval; - if (dim < 0) { dim = dims.first_non_singleton ();