Mercurial > octave
changeset 33546:47c798415504
Array-base.cc: Return *this instead of making a copy of the array (bug #65712)
| author | Arun Giridhar <arungiridhar@gmail.com> |
|---|---|
| date | Wed, 08 May 2024 09:16:05 -0400 |
| parents | 31bc9accbe6e |
| children | b6189d2a3d3c a12d26fababc |
| files | liboctave/array/Array-base.cc |
| diffstat | 1 files changed, 3 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/liboctave/array/Array-base.cc Wed May 08 08:57:13 2024 -0400 +++ b/liboctave/array/Array-base.cc Wed May 08 09:16:05 2024 -0400 @@ -1817,15 +1817,9 @@ { // The dimension to sort along exceeds the array's dimensions, // ==> array is already trivially sorted in such higher dimensions, - // ==> copy and return. - - T *v = m.rwdata (); - const T *ov = data (); - - for (octave_idx_type i = 0; i < m.numel (); i++) - v[i] = ov[i]; - - return m; + // ==> return early. + + return *this; } octave_idx_type ns = dv(dim);