Mercurial > gnulib
annotate top/maint.mk @ 14190:6699cf2b13db
maint.mk: improve the public-submodule-commit rule
* top/maint.mk (public-submodule-commit): Prefix with $(AM_V_GEN),
to suppress printing of its commands... unless V=1.
Add git submodule's --quiet option to suppress printing of e.g.,
"Entering gnulib" output.
"cd" into $(srcdir) before running git submodule.
author | Jim Meyering <meyering@redhat.com> |
---|---|
date | Thu, 20 Jan 2011 11:50:53 +0100 |
parents | 1ca84334d3eb |
children | d6780f2a0ebc |
rev | line source |
---|---|
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1 # -*-Makefile-*- |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
2 # This Makefile fragment tries to be general-purpose enough to be |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
3 # used by many projects via the gnulib maintainer-makefile module. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
4 |
14079
97fc9a21a8fb
maint: update almost all copyright ranges to include 2011
Jim Meyering <meyering@redhat.com>
parents:
13880
diff
changeset
|
5 ## Copyright (C) 2001-2011 Free Software Foundation, Inc. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
6 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
7 ## This program is free software: you can redistribute it and/or modify |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
8 ## it under the terms of the GNU General Public License as published by |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
9 ## the Free Software Foundation, either version 3 of the License, or |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
10 ## (at your option) any later version. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
11 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
12 ## This program is distributed in the hope that it will be useful, |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
13 ## but WITHOUT ANY WARRANTY; without even the implied warranty of |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
14 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
15 ## GNU General Public License for more details. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
16 ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
17 ## You should have received a copy of the GNU General Public License |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
18 ## along with this program. If not, see <http://www.gnu.org/licenses/>. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
19 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
20 # This is reported not to work with make-3.79.1 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
21 # ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST)) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
22 ME := maint.mk |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
23 |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
24 # Override this in cfg.mk if you use a non-standard build-aux directory. |
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
25 build_aux ?= $(srcdir)/build-aux |
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
26 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
27 # Do not save the original name or timestamp in the .tar.gz file. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
28 # Use --rsyncable if available. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
29 gzip_rsyncable := \ |
13376 | 30 $(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null \ |
31 && printf %s --rsyncable) | |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
32 GZIP_ENV = '--no-name --best $(gzip_rsyncable)' |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
33 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
34 GIT = git |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
35 VC = $(GIT) |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
36 VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)' |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
37 |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
38 VC_LIST = $(build_aux)/vc-list-files -C $(srcdir) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
39 |
12736
123f8b43a3aa
top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_ALWAYS_EXCLUDE_REGEX.
Simon Josefsson <simon@josefsson.org>
parents:
12608
diff
changeset
|
40 # You can override this variable in cfg.mk to set your own regexp |
123f8b43a3aa
top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_ALWAYS_EXCLUDE_REGEX.
Simon Josefsson <simon@josefsson.org>
parents:
12608
diff
changeset
|
41 # matching files to ignore. |
123f8b43a3aa
top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_ALWAYS_EXCLUDE_REGEX.
Simon Josefsson <simon@josefsson.org>
parents:
12608
diff
changeset
|
42 VC_LIST_ALWAYS_EXCLUDE_REGEX ?= ^$$ |
123f8b43a3aa
top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_ALWAYS_EXCLUDE_REGEX.
Simon Josefsson <simon@josefsson.org>
parents:
12608
diff
changeset
|
43 |
12768
f12919d53a60
maint.mk: make VC_LIST_EXCEPT robustly handle a srcdir containing "."
Jim Meyering <meyering@redhat.com>
parents:
12767
diff
changeset
|
44 # This is to preprocess robustly the output of $(VC_LIST), so that even |
f12919d53a60
maint.mk: make VC_LIST_EXCEPT robustly handle a srcdir containing "."
Jim Meyering <meyering@redhat.com>
parents:
12767
diff
changeset
|
45 # when $(srcdir) is a pathological name like "....", the leading sed command |
f12919d53a60
maint.mk: make VC_LIST_EXCEPT robustly handle a srcdir containing "."
Jim Meyering <meyering@redhat.com>
parents:
12767
diff
changeset
|
46 # removes only the intended prefix. |
12771
a11a67aec9bf
maint.mk: fix syntax-check in a non-srcdir build directory
Jim Meyering <meyering@redhat.com>
parents:
12768
diff
changeset
|
47 _dot_escaped_srcdir = $(subst .,\.,$(srcdir)) |
12768
f12919d53a60
maint.mk: make VC_LIST_EXCEPT robustly handle a srcdir containing "."
Jim Meyering <meyering@redhat.com>
parents:
12767
diff
changeset
|
48 |
12773
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
49 # Post-process $(VC_LIST) output, prepending $(srcdir)/, but only |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
50 # when $(srcdir) is not ".". |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
51 ifeq ($(srcdir),.) |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
52 _prepend_srcdir_prefix = |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
53 else |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
54 _prepend_srcdir_prefix = | sed 's|^|$(srcdir)/|' |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
55 endif |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
56 |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
57 # In order to be able to consistently filter "."-relative names, |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
58 # (i.e., with no $(srcdir) prefix), this definition is careful to |
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
59 # remove any $(srcdir) prefix, and to restore what it removes. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
60 VC_LIST_EXCEPT = \ |
12768
f12919d53a60
maint.mk: make VC_LIST_EXCEPT robustly handle a srcdir containing "."
Jim Meyering <meyering@redhat.com>
parents:
12767
diff
changeset
|
61 $(VC_LIST) | sed 's|^$(_dot_escaped_srcdir)/||' \ |
12767
941bc7981053
maint.mk: fix VC_LIST_EXCEPT for srcdir != builddir
Jiri Denemark <jdenemar@redhat.com>
parents:
12736
diff
changeset
|
62 | if test -f $(srcdir)/.x-$@; then grep -vEf $(srcdir)/.x-$@; \ |
941bc7981053
maint.mk: fix VC_LIST_EXCEPT for srcdir != builddir
Jiri Denemark <jdenemar@redhat.com>
parents:
12736
diff
changeset
|
63 else grep -Ev -e "$${VC_LIST_EXCEPT_DEFAULT-ChangeLog}"; fi \ |
941bc7981053
maint.mk: fix VC_LIST_EXCEPT for srcdir != builddir
Jiri Denemark <jdenemar@redhat.com>
parents:
12736
diff
changeset
|
64 | grep -Ev -e '$(VC_LIST_ALWAYS_EXCLUDE_REGEX)' \ |
12773
1fedbaac4fa9
maint.mk: do not prepend "./" after filtering
Jim Meyering <meyering@redhat.com>
parents:
12771
diff
changeset
|
65 $(_prepend_srcdir_prefix) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
66 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
67 ifeq ($(origin prev_version_file), undefined) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
68 prev_version_file = $(srcdir)/.prev-version |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
69 endif |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
70 |
11736
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
71 PREV_VERSION := $(shell cat $(prev_version_file) 2>/dev/null) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
72 VERSION_REGEXP = $(subst .,\.,$(VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
73 PREV_VERSION_REGEXP = $(subst .,\.,$(PREV_VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
74 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
75 ifeq ($(VC),$(GIT)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
76 this-vc-tag = v$(VERSION) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
77 this-vc-tag-regexp = v$(VERSION_REGEXP) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
78 else |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
79 tag-package = $(shell echo "$(PACKAGE)" | tr '[:lower:]' '[:upper:]') |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
80 tag-this-version = $(subst .,_,$(VERSION)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
81 this-vc-tag = $(tag-package)-$(tag-this-version) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
82 this-vc-tag-regexp = $(this-vc-tag) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
83 endif |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
84 my_distdir = $(PACKAGE)-$(VERSION) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
85 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
86 # Old releases are stored here. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
87 release_archive_dir ?= ../release |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
88 |
12329
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
89 # Override gnu_rel_host and url_dir_list in cfg.mk if these are not right. |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
90 # Use alpha.gnu.org for alpha and beta releases. |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
91 # Use ftp.gnu.org for stable releases. |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
92 gnu_ftp_host-alpha = alpha.gnu.org |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
93 gnu_ftp_host-beta = alpha.gnu.org |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
94 gnu_ftp_host-stable = ftp.gnu.org |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
95 gnu_rel_host ?= $(gnu_ftp_host-$(RELEASE_TYPE)) |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
96 |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
97 ifeq ($(gnu_rel_host),ftp.gnu.org) |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
98 url_dir_list ?= http://ftpmirror.gnu.org/$(PACKAGE) |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
99 else |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
100 url_dir_list ?= ftp://$(gnu_rel_host)/gnu/$(PACKAGE) |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
101 endif |
1d8d8b72ddd8
build: mention ftp redirector in release announcements
Eric Blake <ebb9@byu.net>
parents:
12325
diff
changeset
|
102 |
12383
a22f69c2029c
maintainer-makefile: allow customization of NEWS entry format
Alfred M. Szmidt <ams@gnu.org>
parents:
12329
diff
changeset
|
103 # Override this in cfg.mk if you are using a different format in your |
a22f69c2029c
maintainer-makefile: allow customization of NEWS entry format
Alfred M. Szmidt <ams@gnu.org>
parents:
12329
diff
changeset
|
104 # NEWS file. |
12384
8620ff59758a
maint.mk: news-check: use grep -E
Jim Meyering <meyering@redhat.com>
parents:
12383
diff
changeset
|
105 today = $(shell date +%Y-%m-%d) |
13393
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
106 |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
107 # Select which lines of NEWS are searched for $(news-check-regexp). |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
108 # This is a sed line number spec. The default says that we search |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
109 # lines 1..10 of NEWS for $(news-check-regexp). |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
110 # If you want to search only line 3 or only lines 20-22, use "3" or "20,22". |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
111 news-check-lines-spec ?= 1,10 |
12385
ad3ca6ce84b0
maint.mk: backslash-escape parens in default regexp
Jim Meyering <meyering@redhat.com>
parents:
12384
diff
changeset
|
112 news-check-regexp ?= '^\*.* $(VERSION_REGEXP) \($(today)\)' |
12383
a22f69c2029c
maintainer-makefile: allow customization of NEWS entry format
Alfred M. Szmidt <ams@gnu.org>
parents:
12329
diff
changeset
|
113 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
114 # Prevent programs like 'sort' from considering distinct strings to be equal. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
115 # Doing it here saves us from having to set LC_ALL elsewhere in this file. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
116 export LC_ALL = C |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
117 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
118 ## --------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
119 ## Sanity checks. ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
120 ## --------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
121 |
11736
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
122 _cfg_mk := $(shell test -f $(srcdir)/cfg.mk && echo '$(srcdir)/cfg.mk') |
9f4d092a26a4
maint.mk: avoid warnings about missing files
Jim Meyering <meyering@redhat.com>
parents:
11733
diff
changeset
|
123 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
124 # Collect the names of rules starting with `sc_'. |
11927
234941dec230
maint.mk: sort the list of syntax-check rules
Daniel P. Berrange <berrange@redhat.com>
parents:
11909
diff
changeset
|
125 syntax-check-rules := $(sort $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \ |
234941dec230
maint.mk: sort the list of syntax-check rules
Daniel P. Berrange <berrange@redhat.com>
parents:
11909
diff
changeset
|
126 $(srcdir)/$(ME) $(_cfg_mk))) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
127 .PHONY: $(syntax-check-rules) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
128 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
129 local-checks-available = \ |
11498
4eb7918a17d0
top/maint.mk (makefile-check): Renamed to sc_makefile_check for consistency.
Simon Josefsson <simon@josefsson.org>
parents:
11495
diff
changeset
|
130 $(syntax-check-rules) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
131 .PHONY: $(local-checks-available) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
132 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
133 # Arrange to print the name of each syntax-checking rule just before running it. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
134 $(syntax-check-rules): %: %.m |
12866
bedb32c7fa1b
maint.mk: mark syntax-check sc_*.m rules as .PHONY
Jim Meyering <meyering@redhat.com>
parents:
12865
diff
changeset
|
135 sc_m_rules_ = $(patsubst %, %.m, $(syntax-check-rules)) |
bedb32c7fa1b
maint.mk: mark syntax-check sc_*.m rules as .PHONY
Jim Meyering <meyering@redhat.com>
parents:
12865
diff
changeset
|
136 .PHONY: $(sc_m_rules_) |
bedb32c7fa1b
maint.mk: mark syntax-check sc_*.m rules as .PHONY
Jim Meyering <meyering@redhat.com>
parents:
12865
diff
changeset
|
137 $(sc_m_rules_): |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
138 @echo $(patsubst sc_%.m, %, $@) |
13208
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
139 @date +%s.%N > .sc-start-$(basename $@) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
140 |
13208
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
141 # Compute and print the elapsed time for each syntax-check rule. |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
142 sc_z_rules_ = $(patsubst %, %.z, $(syntax-check-rules)) |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
143 .PHONY: $(sc_z_rules_) |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
144 $(sc_z_rules_): %.z: % |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
145 @end=$$(date +%s.%N); \ |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
146 start=$$(cat .sc-start-$*); \ |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
147 rm -f .sc-start-$*; \ |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
148 awk -v s=$$start -v e=$$end \ |
13221
6b5e6ecef4f5
maint.mk: generate more concise timing data for syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13210
diff
changeset
|
149 'END {printf "%.2f $(patsubst sc_%,%,$*)\n", e - s}' < /dev/null |
13208
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
150 |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
151 # The patsubst here is to replace each sc_% rule with its sc_%.z wrapper |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
152 # that computes and prints elapsed time. |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
153 local-check := \ |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
154 $(patsubst sc_%, sc_%.z, \ |
85be704c72eb
maint.mk: print the elapsed time for each syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13207
diff
changeset
|
155 $(filter-out $(local-checks-to-skip), $(local-checks-available))) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
156 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
157 syntax-check: $(local-check) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
158 |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
159 # _sc_search_regexp |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
160 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
161 # This macro searches for a given construct in the selected files and |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
162 # then takes some action. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
163 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
164 # Parameters (shell variables): |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
165 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
166 # prohibit | require |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
167 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
168 # Regular expression (ERE) denoting either a forbidden construct |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
169 # or a required construct. Those arguments are exclusive. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
170 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
171 # in_vc_files | in_files |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
172 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
173 # grep-E-style regexp denoting the files to check. If no files |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
174 # are specified the default are all the files that are under |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
175 # version control. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
176 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
177 # containing | non_containing |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
178 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
179 # Select the files (non) containing strings matching this regexp. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
180 # If both arguments are specified then CONTAINING takes |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
181 # precedence. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
182 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
183 # with_grep_options |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
184 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
185 # Extra options for grep. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
186 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
187 # ignore_case |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
188 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
189 # Ignore case. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
190 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
191 # halt |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
192 # |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
193 # Message to display before to halting execution. |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
194 |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
195 # By default, _sc_search_regexp does not ignore case. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
196 export ignore_case = |
13376 | 197 _ignore_case = $$(test -n "$$ignore_case" && printf %s -i || :) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
198 |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
199 define _sc_say_and_exit |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
200 dummy=; : so we do not need a semicolon before each use; \ |
13376 | 201 { printf '%s\n' "$(ME): $$msg" 1>&2; exit 1; }; |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
202 endef |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
203 |
13126
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
204 # _sc_search_regexp used to be named _prohibit_regexp. However, |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
205 # upgrading to the new definition and leaving the old name undefined |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
206 # would usually convert each custom rule using $(_prohibit_regexp) |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
207 # (usually defined in cfg.mk) into a no-op. This definition ensures |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
208 # that people know right away if they're still using the old name. |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
209 # FIXME: remove in 2012. |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
210 _prohibit_regexp = \ |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
211 $(error '*** you need to s/_prohibit_regexp/_sc_search_regexp/, and adapt') |
5f4b249b16d0
maint.mk: don't silently disable project-specific syntax-check rules
Jim Meyering <meyering@redhat.com>
parents:
13104
diff
changeset
|
212 |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
213 define _sc_search_regexp |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
214 dummy=; : so we do not need a semicolon before each use; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
215 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
216 : Check arguments; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
217 test -n "$$prohibit" && test -n "$$require" \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
218 && { msg='Cannot specify both prohibit and require' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
219 $(_sc_say_and_exit) } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
220 test -z "$$prohibit" && test -z "$$require" \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
221 && { msg='Should specify either prohibit or require' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
222 $(_sc_say_and_exit) } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
223 test -n "$$in_vc_files" && test -n "$$in_files" \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
224 && { msg='Cannot specify both in_vc_files and in_files' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
225 $(_sc_say_and_exit) } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
226 test "x$$halt" != x \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
227 || { msg='halt not defined' $(_sc_say_and_exit) }; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
228 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
229 : Filter by file name; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
230 if test -n "$$in_files"; then \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
231 files=$$(find $(srcdir) | grep -E "$$in_files"); \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
232 else \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
233 files=$$($(VC_LIST_EXCEPT)); \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
234 if test -n "$$in_vc_files"; then \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
235 files=$$(echo "$$files" | grep -E "$$in_vc_files"); \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
236 fi; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
237 fi; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
238 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
239 : Filter by content; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
240 test -n "$$files" && test -n "$$containing" \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
241 && { files=$$(grep -l "$$containing" $$files); } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
242 test -n "$$files" && test -n "$$non_containing" \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
243 && { files=$$(grep -vl "$$non_containing" $$files); } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
244 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
245 : Check for the construct; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
246 if test -n "$$files"; then \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
247 if test -n "$$prohibit"; then \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
248 grep $$with_grep_options $(_ignore_case) -nE "$$prohibit" $$files \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
249 && { msg="$$halt" $(_sc_say_and_exit) } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
250 else \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
251 grep $$with_grep_options $(_ignore_case) -LE "$$require" $$files \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
252 | grep . \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
253 && { msg="$$halt" $(_sc_say_and_exit) } || :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
254 fi \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
255 else :; \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
256 fi || :; |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
257 endef |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
258 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
259 sc_avoid_if_before_free: |
11564
ab18b3d5e34a
* top/maint.mk: Adjust backslash alignment.
Jim Meyering <meyering@redhat.com>
parents:
11563
diff
changeset
|
260 @$(build_aux)/useless-if-before-free \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
261 $(useless_free_options) \ |
11518
956eb61203ab
top/maint.mk (sc_avoid_if_before_free): Except useless-if-before-free script.
Simon Josefsson <simon@josefsson.org>
parents:
11517
diff
changeset
|
262 $$($(VC_LIST_EXCEPT) | grep -v useless-if-before-free) && \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
263 { echo '$(ME): found useless "if" before "free" above' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
264 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
265 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
266 sc_cast_of_argument_to_free: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
267 @prohibit='\<free *\( *\(' halt='don'\''t cast free argument' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
268 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
269 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
270 sc_cast_of_x_alloc_return_value: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
271 @prohibit='\*\) *x(m|c|re)alloc\>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
272 halt='don'\''t cast x*alloc return value' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
273 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
274 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
275 sc_cast_of_alloca_return_value: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
276 @prohibit='\*\) *alloca\>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
277 halt='don'\''t cast alloca return value' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
278 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
279 |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
280 sc_space_tab: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
281 @prohibit='[ ] ' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
282 halt='found SPACE-TAB sequence; remove the SPACE' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
283 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
284 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
285 # Don't use *scanf or the old ato* functions in `real' code. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
286 # They provide no error checking mechanism. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
287 # Instead, use strto* functions. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
288 sc_prohibit_atoi_atof: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
289 @prohibit='\<([fs]?scanf|ato([filq]|ll)) *\(' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
290 halt='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
291 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
292 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
293 # Use STREQ rather than comparing strcmp == 0, or != 0. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
294 sc_prohibit_strcmp: |
14140
1ca84334d3eb
maint.mk: improve sc_prohibit_strcmp regex
Eric Blake <eblake@redhat.com>
parents:
14137
diff
changeset
|
295 @grep -nE '! *str''cmp *\(|\<str''cmp *\(.+\) *[!=]=' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
296 $$($(VC_LIST_EXCEPT)) \ |
14140
1ca84334d3eb
maint.mk: improve sc_prohibit_strcmp regex
Eric Blake <eblake@redhat.com>
parents:
14137
diff
changeset
|
297 | grep -vE ':# *define STRN?EQ\(' && \ |
1ca84334d3eb
maint.mk: improve sc_prohibit_strcmp regex
Eric Blake <eblake@redhat.com>
parents:
14137
diff
changeset
|
298 { echo '$(ME): replace str''cmp calls above with STREQ/STRNEQ' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
299 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
300 |
12208
a377ab624fcc
maint: detect usage(1) and other suspicious exits
Eric Blake <ebb9@byu.net>
parents:
12083
diff
changeset
|
301 # Pass EXIT_*, not number, to usage, exit, and error (when exiting) |
12325
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
302 # Convert all uses automatically, via these two commands: |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
303 # git grep -l '\<exit *(1)' \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
304 # | grep -vEf .x-sc_prohibit_magic_number_exit \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
305 # | xargs --no-run-if-empty \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
306 # perl -pi -e 's/(^|[^.])\b(exit ?)\(1\)/$1$2(EXIT_FAILURE)/' |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
307 # git grep -l '\<exit *(0)' \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
308 # | grep -vEf .x-sc_prohibit_magic_number_exit \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
309 # | xargs --no-run-if-empty \ |
444e305ec8cc
maint.mk: improve sc_prohibit_magic_number_exit
Jim Meyering <meyering@redhat.com>
parents:
12287
diff
changeset
|
310 # perl -pi -e 's/(^|[^.])\b(exit ?)\(0\)/$1$2(EXIT_SUCCESS)/' |
12208
a377ab624fcc
maint: detect usage(1) and other suspicious exits
Eric Blake <ebb9@byu.net>
parents:
12083
diff
changeset
|
311 sc_prohibit_magic_number_exit: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
312 @prohibit='(^|[^.])\<(usage|exit) ?\([0-9]|\<error ?\([1-9][0-9]*,' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
313 halt='use EXIT_* values rather than magic number' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
314 $(_sc_search_regexp) |
12208
a377ab624fcc
maint: detect usage(1) and other suspicious exits
Eric Blake <ebb9@byu.net>
parents:
12083
diff
changeset
|
315 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
316 # Using EXIT_SUCCESS as the first argument to error is misleading, |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
317 # since when that parameter is 0, error does not exit. Use `0' instead. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
318 sc_error_exit_success: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
319 @prohibit='error *\(EXIT_SUCCESS,' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
320 in_vc_files='\.[chly]$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
321 halt='found error (EXIT_SUCCESS' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
322 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
323 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
324 # `FATAL:' should be fully upper-cased in error messages |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
325 # `WARNING:' should be fully upper-cased, or fully lower-cased |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
326 sc_error_message_warn_fatal: |
13102
9c58202271c4
maint.mk: match 0 or more whitespace-before-function-call '('
Jose E. Marchesi <jemarch@gnu.org>
parents:
13101
diff
changeset
|
327 @grep -nEA2 '[^rp]error *\(' $$($(VC_LIST_EXCEPT)) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
328 | grep -E '"Warning|"Fatal|"fatal' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
329 { echo '$(ME): use FATAL, WARNING or warning' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
330 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
331 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
332 # Error messages should not start with a capital letter |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
333 sc_error_message_uppercase: |
13102
9c58202271c4
maint.mk: match 0 or more whitespace-before-function-call '('
Jose E. Marchesi <jemarch@gnu.org>
parents:
13101
diff
changeset
|
334 @grep -nEA2 '[^rp]error *\(' $$($(VC_LIST_EXCEPT)) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
335 | grep -E '"[A-Z]' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
336 | grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
337 { echo '$(ME): found capitalized error message' 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
338 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
339 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
340 # Error messages should not end with a period |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
341 sc_error_message_period: |
13102
9c58202271c4
maint.mk: match 0 or more whitespace-before-function-call '('
Jose E. Marchesi <jemarch@gnu.org>
parents:
13101
diff
changeset
|
342 @grep -nEA2 '[^rp]error *\(' $$($(VC_LIST_EXCEPT)) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
343 | grep -E '[^."]\."' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
344 { echo '$(ME): found error message ending in period' 1>&2; \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
345 exit 1; } || : |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
346 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
347 sc_file_system: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
348 @prohibit=file''system \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
349 ignore_case=1 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
350 halt='found use of "file''system"; spell it "file system"' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
351 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
352 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
353 # Don't use cpp tests of this symbol. All code assumes config.h is included. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
354 sc_prohibit_have_config_h: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
355 @prohibit='^# *if.*HAVE''_CONFIG_H' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
356 halt='found use of HAVE''_CONFIG_H; remove' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
357 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
358 |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
359 # Nearly all .c files must include <config.h>. However, we also permit this |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
360 # via inclusion of a package-specific header, if cfg.mk specified one. |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
361 # config_h_header must be suitable for grep -E. |
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
362 config_h_header ?= <config\.h> |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
363 sc_require_config_h: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
364 @require='^# *include $(config_h_header)' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
365 in_vc_files='\.c$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
366 halt='the above files do not include <config.h>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
367 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
368 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
369 # You must include <config.h> before including any other header file. |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
370 # This can possibly be via a package-specific header, if given by cfg.mk. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
371 sc_require_config_h_first: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
372 @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
373 fail=0; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
374 for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
375 grep '^# *include\>' $$i | sed 1q \ |
11519
49521800ab0c
maint.mk: allow package-specific header to provide <config.h>
Eric Blake <ebb9@byu.net>
parents:
11518
diff
changeset
|
376 | grep -E '^# *include $(config_h_header)' > /dev/null \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
377 || { echo $$i; fail=1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
378 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
379 test $$fail = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
380 { echo '$(ME): the above files include some other header' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
381 'before <config.h>' 1>&2; exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
382 else :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
383 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
384 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
385 sc_prohibit_HAVE_MBRTOWC: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
386 @prohibit='\bHAVE_MBRTOWC\b' \ |
13202
69a6d1611d1b
maint.mk: correct a diagnostic
Jim Meyering <meyering@redhat.com>
parents:
13192
diff
changeset
|
387 halt="do not use $$prohibit; it is always defined" \ |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
388 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
389 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
390 # To use this "command" macro, you must first define two shell variables: |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
391 # h: the header, enclosed in <> or "" |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
392 # re: a regular expression that matches IFF something provided by $h is used. |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
393 define _sc_header_without_use |
11853
97a383c7cec4
maint.mk: _header_without_use: fix a quoting bug and remove a bash'ism
Jim Meyering <meyering@redhat.com>
parents:
11847
diff
changeset
|
394 dummy=; : so we do not need a semicolon before each use; \ |
97a383c7cec4
maint.mk: _header_without_use: fix a quoting bug and remove a bash'ism
Jim Meyering <meyering@redhat.com>
parents:
11847
diff
changeset
|
395 h_esc=`echo "$$h"|sed 's/\./\\\\./g'`; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
396 if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then \ |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
397 files=$$(grep -l '^# *include '"$$h_esc" \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
398 $$($(VC_LIST_EXCEPT) | grep '\.c$$')) && \ |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
399 grep -LE "$$re" $$files | grep . && \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
400 { echo "$(ME): the above files include $$h but don't use it" \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
401 1>&2; exit 1; } || :; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
402 else :; \ |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
403 fi |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
404 endef |
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
405 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
406 # Prohibit the inclusion of assert.h without an actual use of assert. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
407 sc_prohibit_assert_without_use: |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
408 @h='<assert.h>' re='\<assert *\(' $(_sc_header_without_use) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
409 |
12245
86929e33bdad
maint.mk: Prohibit inclusion of "close-stream.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12208
diff
changeset
|
410 # Prohibit the inclusion of close-stream.h without an actual use. |
86929e33bdad
maint.mk: Prohibit inclusion of "close-stream.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12208
diff
changeset
|
411 sc_prohibit_close_stream_without_use: |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
412 @h='"close-stream.h"' re='\<close_stream *\(' $(_sc_header_without_use) |
12245
86929e33bdad
maint.mk: Prohibit inclusion of "close-stream.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12208
diff
changeset
|
413 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
414 # Prohibit the inclusion of getopt.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
415 sc_prohibit_getopt_without_use: |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
416 @h='<getopt.h>' re='\<getopt(_long)? *\(' $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
417 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
418 # Don't include quotearg.h unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
419 sc_prohibit_quotearg_without_use: |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
420 @h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
421 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
422 # Don't include quote.h unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
423 sc_prohibit_quote_without_use: |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
424 @h='"quote.h"' re='\<quote(_n)? *\(' $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
425 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
426 # Don't include this header unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
427 sc_prohibit_long_options_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
428 @h='"long-options.h"' re='\<parse_long_options *\(' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
429 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
430 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
431 # Don't include this header unless you use one of its functions. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
432 sc_prohibit_inttostr_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
433 @h='"inttostr.h"' re='\<(off|[iu]max|uint)tostr *\(' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
434 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
435 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
436 # Don't include this header unless you use one of its functions. |
12861
2afdfba76c99
maint.mk: prohibit inclusion of "ignore-value.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12827
diff
changeset
|
437 sc_prohibit_ignore_value_without_use: |
2afdfba76c99
maint.mk: prohibit inclusion of "ignore-value.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12827
diff
changeset
|
438 @h='"ignore-value.h"' re='\<ignore_(value|ptr) *\(' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
439 $(_sc_header_without_use) |
12861
2afdfba76c99
maint.mk: prohibit inclusion of "ignore-value.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12827
diff
changeset
|
440 |
2afdfba76c99
maint.mk: prohibit inclusion of "ignore-value.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12827
diff
changeset
|
441 # Don't include this header unless you use one of its functions. |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
442 sc_prohibit_error_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
443 @h='"error.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
444 re='\<error(_at_line|_print_progname|_one_per_line|_message_count)? *\('\ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
445 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
446 |
12287
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
447 # Don't include xalloc.h unless you use one of its functions. |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
448 # Consider these symbols: |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
449 # perl -lne '/^# *define (\w+)\(/ and print $1' lib/xalloc.h|grep -v '^__'; |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
450 # perl -lne '/^(?:extern )?(?:void|char) \*?(\w+) *\(/ and print $1' lib/xalloc.h |
12287
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
451 # Divide into two sets on case, and filter each through this: |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
452 # | sort | perl -MRegexp::Assemble -le \ |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
453 # 'print Regexp::Assemble->new(file => "/dev/stdin")->as_string'|sed 's/\?://g' |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
454 # Note this was produced by the above: |
12576
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
455 # _xa1 = \ |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
456 #x(((2n?)?re|c(har)?|n(re|m)|z)alloc|alloc_(oversized|die)|m(alloc|emdup)|strdup) |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
457 # But we can do better, in at least two ways: |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
458 # 1) take advantage of two "dup"-suffixed strings: |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
459 # x(((2n?)?re|c(har)?|n(re|m)|[mz])alloc|alloc_(oversized|die)|(mem|str)dup) |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
460 # 2) notice that "c(har)?|[mz]" is equivalent to the shorter and more readable |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
461 # "char|[cmz]" |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
462 # x(((2n?)?re|char|n(re|m)|[cmz])alloc|alloc_(oversized|die)|(mem|str)dup) |
51b39cac47f1
maint.mk: include 4 more function names in alloca.h-checking regexp
Jim Meyering <meyering@redhat.com>
parents:
12559
diff
changeset
|
463 _xa1 = x(((2n?)?re|char|n(re|m)|[cmz])alloc|alloc_(oversized|die)|(mem|str)dup) |
12287
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
464 _xa2 = X([CZ]|N?M)ALLOC |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
465 sc_prohibit_xalloc_without_use: |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
466 @h='"xalloc.h"' \ |
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
467 re='\<($(_xa1)|$(_xa2)) *\('\ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
468 $(_sc_header_without_use) |
12287
0c467c7c0132
maint.mk: Prohibit inclusion of "xalloc.h" without use.
Jim Meyering <meyering@redhat.com>
parents:
12245
diff
changeset
|
469 |
12863
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
470 # Extract function names: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
471 # perl -lne '/^(?:extern )?(?:void|char) \*?(\w+) *\(/ and print $1' lib/hash.h |
12863
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
472 _hash_re = \ |
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
473 clear|delete|free|get_(first|next)|insert|lookup|print_statistics|reset_tuning |
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
474 _hash_fn = \<($(_hash_re)) *\( |
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
475 _hash_struct = (struct )?\<[Hh]ash_(table|tuning)\> |
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
476 sc_prohibit_hash_without_use: |
12865
19a113553866
maint.mk: prohibit inclusion of "hash-pjw.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12864
diff
changeset
|
477 @h='"hash.h"' \ |
12863
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
478 re='$(_hash_fn)|$(_hash_struct)'\ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
479 $(_sc_header_without_use) |
12863
8fd1fe5e9683
maint.mk: prohibit inclusion of "hash.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12861
diff
changeset
|
480 |
12865
19a113553866
maint.mk: prohibit inclusion of "hash-pjw.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12864
diff
changeset
|
481 sc_prohibit_hash_pjw_without_use: |
19a113553866
maint.mk: prohibit inclusion of "hash-pjw.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12864
diff
changeset
|
482 @h='"hash-pjw.h"' \ |
19a113553866
maint.mk: prohibit inclusion of "hash-pjw.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12864
diff
changeset
|
483 re='\<hash_pjw *\(' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
484 $(_sc_header_without_use) |
12865
19a113553866
maint.mk: prohibit inclusion of "hash-pjw.h" without_use
Jim Meyering <meyering@redhat.com>
parents:
12864
diff
changeset
|
485 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
486 sc_prohibit_safe_read_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
487 @h='"safe-read.h"' re='(\<SAFE_READ_ERROR\>|\<safe_read *\()' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
488 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
489 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
490 sc_prohibit_argmatch_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
491 @h='"argmatch.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
492 re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid) *\()' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
493 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
494 |
12035
2898ee238452
syntax-check: detect unnecessary inclusion of canonicalize.h
Jim Meyering <meyering@redhat.com>
parents:
11969
diff
changeset
|
495 sc_prohibit_canonicalize_without_use: |
2898ee238452
syntax-check: detect unnecessary inclusion of canonicalize.h
Jim Meyering <meyering@redhat.com>
parents:
11969
diff
changeset
|
496 @h='"canonicalize.h"' \ |
2898ee238452
syntax-check: detect unnecessary inclusion of canonicalize.h
Jim Meyering <meyering@redhat.com>
parents:
11969
diff
changeset
|
497 re='CAN_(EXISTING|ALL_BUT_LAST|MISSING)|canonicalize_(mode_t|filename_mode)' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
498 $(_sc_header_without_use) |
12035
2898ee238452
syntax-check: detect unnecessary inclusion of canonicalize.h
Jim Meyering <meyering@redhat.com>
parents:
11969
diff
changeset
|
499 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
500 sc_prohibit_root_dev_ino_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
501 @h='"root-dev-ino.h"' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
502 re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
503 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
504 |
11954
c2aabb82023d
syntax-check: detect unnecessary inclusion of openat.h
Jim Meyering <meyering@redhat.com>
parents:
11927
diff
changeset
|
505 sc_prohibit_openat_without_use: |
c2aabb82023d
syntax-check: detect unnecessary inclusion of openat.h
Jim Meyering <meyering@redhat.com>
parents:
11927
diff
changeset
|
506 @h='"openat.h"' \ |
11969
25d12bf7e5bf
openat: provide more convenience names
Eric Blake <ebb9@byu.net>
parents:
11954
diff
changeset
|
507 re='\<(openat_(permissive|needs_fchdir|(save|restore)_fail)|l?(stat|ch(own|mod))at|(euid)?accessat)\>' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
508 $(_sc_header_without_use) |
11954
c2aabb82023d
syntax-check: detect unnecessary inclusion of openat.h
Jim Meyering <meyering@redhat.com>
parents:
11927
diff
changeset
|
509 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
510 # Prohibit the inclusion of c-ctype.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
511 ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
512 |isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
513 sc_prohibit_c_ctype_without_use: |
13098
8d61d11c6cf0
maint.mk: split a long line
Jim Meyering <meyering@redhat.com>
parents:
13097
diff
changeset
|
514 @h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' \ |
8d61d11c6cf0
maint.mk: split a long line
Jim Meyering <meyering@redhat.com>
parents:
13097
diff
changeset
|
515 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
516 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
517 _empty = |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
518 _sp = $(_empty) $(_empty) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
519 # The following list was generated by running: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
520 # man signal.h|col -b|perl -ne '/bsd_signal.*;/.../sigwaitinfo.*;/ and print' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
521 # | perl -lne '/^\s+(?:int|void).*?(\w+).*/ and print $1' | fmt |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
522 _sig_functions = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
523 bsd_signal kill killpg pthread_kill pthread_sigmask raise sigaction \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
524 sigaddset sigaltstack sigdelset sigemptyset sigfillset sighold sigignore \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
525 siginterrupt sigismember signal sigpause sigpending sigprocmask sigqueue \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
526 sigrelse sigset sigsuspend sigtimedwait sigwait sigwaitinfo |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
527 _sig_function_re = $(subst $(_sp),|,$(strip $(_sig_functions))) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
528 # The following were extracted from "man signal.h" manually. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
529 _sig_types_and_consts = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
530 MINSIGSTKSZ SA_NOCLDSTOP SA_NOCLDWAIT SA_NODEFER SA_ONSTACK \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
531 SA_RESETHAND SA_RESTART SA_SIGINFO SIGEV_NONE SIGEV_SIGNAL \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
532 SIGEV_THREAD SIGSTKSZ SIG_BLOCK SIG_SETMASK SIG_UNBLOCK SS_DISABLE \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
533 SS_ONSTACK mcontext_t pid_t sig_atomic_t sigevent siginfo_t sigset_t \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
534 sigstack sigval stack_t ucontext_t |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
535 # generated via this: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
536 # perl -lne '/^#ifdef (SIG\w+)/ and print $1' lib/sig2str.c|sort -u|fmt -70 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
537 _sig_names = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
538 SIGABRT SIGALRM SIGALRM1 SIGBUS SIGCANCEL SIGCHLD SIGCLD SIGCONT \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
539 SIGDANGER SIGDIL SIGEMT SIGFPE SIGFREEZE SIGGRANT SIGHUP SIGILL \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
540 SIGINFO SIGINT SIGIO SIGIOT SIGKAP SIGKILL SIGKILLTHR SIGLOST SIGLWP \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
541 SIGMIGRATE SIGMSG SIGPHONE SIGPIPE SIGPOLL SIGPRE SIGPROF SIGPWR \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
542 SIGQUIT SIGRETRACT SIGSAK SIGSEGV SIGSOUND SIGSTKFLT SIGSTOP SIGSYS \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
543 SIGTERM SIGTHAW SIGTRAP SIGTSTP SIGTTIN SIGTTOU SIGURG SIGUSR1 \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
544 SIGUSR2 SIGVIRT SIGVTALRM SIGWAITING SIGWINCH SIGWIND SIGWINDOW \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
545 SIGXCPU SIGXFSZ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
546 _sig_syms_re = $(subst $(_sp),|,$(strip $(_sig_names) $(_sig_types_and_consts))) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
547 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
548 # Prohibit the inclusion of signal.h without an actual use. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
549 sc_prohibit_signal_without_use: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
550 @h='<signal.h>' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
551 re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
552 $(_sc_header_without_use) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
553 |
13304
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
554 # Prohibit the inclusion of strings.h without a sensible use. |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
555 # Using the likes of bcmp, bcopy, bzero, index or rindex is not sensible. |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
556 sc_prohibit_strings_without_use: |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
557 @h='<strings.h>' \ |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
558 re='\<(strn?casecmp|ffs(ll)?)\>' \ |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
559 $(_sc_header_without_use) |
e5593199cd7e
maint.mk: prohibit unwarranted use of <strings.h>
Jim Meyering <meyering@redhat.com>
parents:
13302
diff
changeset
|
560 |
13029
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
561 # Get the list of symbol names with this: |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
562 # perl -lne '/^# *define (\w+)\(/ and print $1' lib/intprops.h|grep -v '^s'|fmt |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
563 _intprops_names = \ |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
564 TYPE_IS_INTEGER TYPE_TWOS_COMPLEMENT TYPE_ONES_COMPLEMENT \ |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
565 TYPE_SIGNED_MAGNITUDE TYPE_SIGNED TYPE_MINIMUM TYPE_MAXIMUM \ |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
566 INT_STRLEN_BOUND INT_BUFSIZE_BOUND |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
567 _intprops_syms_re = $(subst $(_sp),|,$(strip $(_intprops_names))) |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
568 # Prohibit the inclusion of intprops.h without an actual use. |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
569 sc_prohibit_intprops_without_use: |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
570 @h='"intprops.h"' \ |
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
571 re='\<($(_intprops_syms_re)) *\(' \ |
13097
ef132cd978fc
maint.mk: s/_header_without_use/_sc_header_without_use/
Jose E. Marchesi <jemarch@gnu.org>
parents:
13085
diff
changeset
|
572 $(_sc_header_without_use) |
13029
44ae789f77b0
maint.mk: prohibit inclusion of "intprops.h" without use
Jim Meyering <meyering@redhat.com>
parents:
12866
diff
changeset
|
573 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
574 sc_obsolete_symbols: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
575 @prohibit='\<(HAVE''_FCNTL_H|O''_NDELAY)\>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
576 halt='do not use HAVE''_FCNTL_H or O'_NDELAY \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
577 $(_sc_search_regexp) |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
578 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
579 # FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
580 |
11468
65ab7e6dcafe
maint.mk: import changes to syntax-check macros from coreutils
Reuben Thomas <rrt@sc3d.org>
parents:
11406
diff
changeset
|
581 # Each nonempty ChangeLog line must start with a year number, or a TAB. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
582 sc_changelog: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
583 @prohibit='^[^12 ]' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
584 in_vc_files='^ChangeLog$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
585 halt='found unexpected prefix in a ChangeLog' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
586 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
587 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
588 # Ensure that each .c file containing a "main" function also |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
589 # calls set_program_name. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
590 sc_program_name: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
591 @require='set_program_name *\(m?argv\[0\]\);' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
592 in_vc_files='\.c$$' \ |
13853
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
593 containing='\<main *(' \ |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
594 halt='the above files do not call set_program_name' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
595 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
596 |
13853
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
597 # Ensure that each .c file containing a "main" function also |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
598 # calls bindtextdomain. |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
599 sc_bindtextdomain: |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
600 @require='bindtextdomain *\(' \ |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
601 in_vc_files='\.c$$' \ |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
602 containing='\<main *(' \ |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
603 halt='the above files do not call bindtextdomain' \ |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
604 $(_sc_search_regexp) |
2f3dbd409322
maintainer-makefile: check for i18n setup
Eric Blake <eblake@redhat.com>
parents:
13704
diff
changeset
|
605 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
606 # Require that the final line of each test-lib.sh-using test be this one: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
607 # Exit $fail |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
608 # Note: this test requires GNU grep's --label= option. |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
609 Exit_witness_file ?= tests/test-lib.sh |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
610 Exit_base := $(notdir $(Exit_witness_file)) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
611 sc_require_test_exit_idiom: |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
612 @if test -f $(srcdir)/$(Exit_witness_file); then \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
613 die=0; \ |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
614 for i in $$(grep -l -F 'srcdir/$(Exit_base)' \ |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
615 $$($(VC_LIST) tests)); do \ |
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
616 tail -n1 $$i | grep '^Exit .' > /dev/null \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
617 && : || { die=1; echo $$i; } \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
618 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
619 test $$die = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
620 { echo 1>&2 '$(ME): the final line in each of the above is not:'; \ |
11646
fc7e7bde323e
tests: maint.mk: make sc_require_test_exit_idiom more generic
Jim Meyering <meyering@redhat.com>
parents:
11575
diff
changeset
|
621 echo 1>&2 'Exit something'; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
622 exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
623 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
624 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
625 sc_the_the: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
626 @prohibit='\<the ''the\>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
627 ignore_case=1 \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
628 halt='found use of "the ''the";' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
629 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
630 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
631 sc_trailing_blank: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
632 @prohibit='[ ]$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
633 halt='found trailing blank(s)' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
634 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
635 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
636 # Match lines like the following, but where there is only one space |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
637 # between the options and the description: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
638 # -D, --all-repeated[=delimit-method] print all duplicate lines\n |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
639 longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)? |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
640 sc_two_space_separator_in_usage: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
641 @prohibit='^ *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
642 halt='help2man requires at least two spaces between an option and its description'\ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
643 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
644 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
645 # Look for diagnostics that aren't marked for translation. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
646 # This won't find any for which error's format string is on a separate line. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
647 sc_unmarked_diagnostics: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
648 @grep -nE \ |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
649 '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
650 | grep -v '_''(' && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
651 { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
652 exit 1; } || : |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
653 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
654 # Avoid useless parentheses like those in this example: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
655 # #if defined (SYMBOL) || defined (SYM2) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
656 sc_useless_cpp_parens: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
657 @prohibit='^# *if .*defined *\(' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
658 halt='found useless parentheses in cpp directive' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
659 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
660 |
13275
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
661 # List headers for which HAVE_HEADER_H is always true, assuming you are |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
662 # using the appropriate gnulib module. CAUTION: for each "unnecessary" |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
663 # #if HAVE_HEADER_H that you remove, be sure that your project explicitly |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
664 # requires the gnulib module that guarantees the usability of that header. |
13277
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
665 gl_assured_headers_ = \ |
13278
a7cc50668746
maint.mk: fix a bug introduced in last change
Jim Meyering <meyering@redhat.com>
parents:
13277
diff
changeset
|
666 cd $(gnulib_dir)/lib && echo *.in.h|sed 's/\.in\.h//g' |
13275
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
667 |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
668 # Convert the list of names to upper case, and replace each space with "|". |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
669 az_ = abcdefghijklmnopqrstuvwxyz |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
670 AZ_ = ABCDEFGHIJKLMNOPQRSTUVWXYZ |
13277
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
671 gl_header_upper_case_or_ = \ |
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
672 $$($(gl_assured_headers_) \ |
13275
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
673 | tr $(az_)/.- $(AZ_)___ \ |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
674 | tr -s ' ' '|' \ |
13277
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
675 ) |
13275
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
676 sc_prohibit_always_true_header_tests: |
13277
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
677 @or=$(gl_header_upper_case_or_); \ |
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
678 re="HAVE_($$or)_H"; \ |
b07571bc9838
maint.mk: avoid side-effect in latest syntax-check
Jim Meyering <meyering@redhat.com>
parents:
13275
diff
changeset
|
679 prohibit='\<'"$$re"'\>' \ |
13704
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
680 halt=$$(printf '%s\n' \ |
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
681 'do not test the above HAVE_<header>_H symbol(s);' \ |
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
682 ' with the corresponding gnulib module, they are always true') \ |
13275
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
683 $(_sc_search_regexp) |
2917aab6182c
maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true
Jim Meyering <meyering@redhat.com>
parents:
13253
diff
changeset
|
684 |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
685 # ================================================================== |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
686 gl_other_headers_ ?= \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
687 intprops.h \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
688 openat.h \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
689 stat-macros.h |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
690 |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
691 # Perl -lne code to extract "significant" cpp-defined symbols from a |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
692 # gnulib header file, eliminating a few common false-positives. |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
693 gl_extract_significant_defines_ = \ |
13337
23825f79a03a
maint.mk: gnulib doesn't guarantee NSIG
Eric Blake <eblake@redhat.com>
parents:
13333
diff
changeset
|
694 /^\# *define ([^_ (][^ (]*)(\s*\(|\s+\w+)/\ |
23825f79a03a
maint.mk: gnulib doesn't guarantee NSIG
Eric Blake <eblake@redhat.com>
parents:
13333
diff
changeset
|
695 && $$2 !~ /(?:rpl_|_used_without_)/\ |
13338
43bae0ee08b9
maint.mk: tweak preceding change
Jim Meyering <meyering@redhat.com>
parents:
13337
diff
changeset
|
696 && $$1 !~ /^(?:NSIG|ATTRIBUTE_NORETURN)$$/\ |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
697 and print $$1 |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
698 |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
699 # Create a list of regular expressions matching the names |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
700 # of macros that are guaranteed to be defined by parts of gnulib. |
13333
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
701 define def_sym_regex |
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
702 gen_h=$(gl_generated_headers_); \ |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
703 (cd $(gnulib_dir)/lib; \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
704 for f in *.in.h $(gl_other_headers_); do \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
705 perl -lne '$(gl_extract_significant_defines_)' $$f; \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
706 done; \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
707 ) | sort -u \ |
13378
c4a059473950
maint.mk: also prohibit "#undef" of always-defined symbols
Jim Meyering <meyering@redhat.com>
parents:
13376
diff
changeset
|
708 | grep -Ev '^ATTRIBUTE_NORETURN' \ |
c4a059473950
maint.mk: also prohibit "#undef" of always-defined symbols
Jim Meyering <meyering@redhat.com>
parents:
13376
diff
changeset
|
709 | sed 's/^/^ *# *(define|undef) */;s/$$/\\>/' |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
710 endef |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
711 |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
712 # Don't define macros that we already get from gnulib header files. |
13333
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
713 sc_prohibit_always-defined_macros: |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
714 @if test -d $(gnulib_dir); then \ |
13333
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
715 case $$(echo all: | grep -l -f - Makefile) in Makefile);; *) \ |
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
716 echo '$(ME): skipping $@: you lack GNU grep' 1>&2; exit 0;; \ |
dd75a1afe536
maint.mk: avoid using a temporary file in the always-defined-macros check
Jim Meyering <meyering@redhat.com>
parents:
13331
diff
changeset
|
717 esac; \ |
13378
c4a059473950
maint.mk: also prohibit "#undef" of always-defined symbols
Jim Meyering <meyering@redhat.com>
parents:
13376
diff
changeset
|
718 $(def_sym_regex) | grep -E -f - $$($(VC_LIST_EXCEPT)) \ |
13329
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
719 && { echo '$(ME): define the above via some gnulib .h file' \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
720 1>&2; exit 1; } || :; \ |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
721 fi |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
722 # ================================================================== |
256d057c7f1f
maint.mk: prohibit definition of symbols defined by gnulib
Jim Meyering <meyering@redhat.com>
parents:
13309
diff
changeset
|
723 |
13253
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
724 # Prohibit checked in backup files. |
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
725 sc_prohibit_backup_files: |
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
726 @$(VC_LIST) | grep '~$$' && \ |
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
727 { echo '$(ME): found version controlled backup file' 1>&2; \ |
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
728 exit 1; } || : |
51e653bb55dd
top/maint.mk (sc_prohibit_backup_files): Prohibit checked in backup files.
Simon Josefsson <simon@josefsson.org>
parents:
13241
diff
changeset
|
729 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
730 # Require the latest GPL. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
731 sc_GPL_version: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
732 @prohibit='either ''version [^3]' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
733 halt='GPL vN, N!=3' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
734 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
735 |
12593
e8847ec6bc92
maint.mk: detect incorrect GFDL usage
Eric Blake <ebb9@byu.net>
parents:
12592
diff
changeset
|
736 # Require the latest GFDL. Two regexp, since some .texi files end up |
e8847ec6bc92
maint.mk: detect incorrect GFDL usage
Eric Blake <ebb9@byu.net>
parents:
12592
diff
changeset
|
737 # line wrapping between 'Free Documentation License,' and 'Version'. |
e8847ec6bc92
maint.mk: detect incorrect GFDL usage
Eric Blake <ebb9@byu.net>
parents:
12592
diff
changeset
|
738 _GFDL_regexp = (Free ''Documentation.*Version 1\.[^3]|Version 1\.[^3] or any) |
e8847ec6bc92
maint.mk: detect incorrect GFDL usage
Eric Blake <ebb9@byu.net>
parents:
12592
diff
changeset
|
739 sc_GFDL_version: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
740 @prohibit='$(_GFDL_regexp)' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
741 halt='GFDL vN, N!=3' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
742 $(_sc_search_regexp) |
12593
e8847ec6bc92
maint.mk: detect incorrect GFDL usage
Eric Blake <ebb9@byu.net>
parents:
12592
diff
changeset
|
743 |
13880
fe3adfe381fa
maint.mk: add a URL discussing the no-@acronym policy
Jim Meyering <meyering@redhat.com>
parents:
13871
diff
changeset
|
744 # Don't use Texinfo's @acronym{}. |
fe3adfe381fa
maint.mk: add a URL discussing the no-@acronym policy
Jim Meyering <meyering@redhat.com>
parents:
13871
diff
changeset
|
745 # http://lists.gnu.org/archive/html/bug-gnulib/2010-03/msg00321.html |
13233
2376509f2722
maint.mk: texinfo_suffix_re_: correct the default regexp
Jim Meyering <meyering@redhat.com>
parents:
13232
diff
changeset
|
746 texinfo_suffix_re_ ?= \.(txi|texi(nfo)?)$$ |
13045
04f53e0b1556
top/maint.mk (sc_texinfo_acronym): Add rule.
Simon Josefsson <simon@josefsson.org>
parents:
13029
diff
changeset
|
747 sc_texinfo_acronym: |
13232
80668c656e53
top/maint.mk (sc_texinfo_acronym): Improve filename regexp.
Simon Josefsson <simon@josefsson.org>
parents:
13221
diff
changeset
|
748 @prohibit='@acronym\{' \ |
80668c656e53
top/maint.mk (sc_texinfo_acronym): Improve filename regexp.
Simon Josefsson <simon@josefsson.org>
parents:
13221
diff
changeset
|
749 in_vc_files='$(texinfo_suffix_re_)' \ |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
750 halt='found use of Texinfo @acronym{}' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
751 $(_sc_search_regexp) |
13045
04f53e0b1556
top/maint.mk (sc_texinfo_acronym): Add rule.
Simon Josefsson <simon@josefsson.org>
parents:
13029
diff
changeset
|
752 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
753 cvs_keywords = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
754 Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
755 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
756 sc_prohibit_cvs_keyword: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
757 @prohibit='\$$($(cvs_keywords))\$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
758 halt='do not use CVS keyword expansion' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
759 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
760 |
13209
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
761 # This Perl code is slightly obfuscated. Not only is each "$" doubled |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
762 # because it's in a Makefile, but the $$c's are comments; we cannot |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
763 # use "#" due to the way the script ends up concatenated onto one line. |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
764 # It would be much more concise, and would produce better output (including |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
765 # counts) if written as: |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
766 # perl -ln -0777 -e '/\n(\n+)$/ and print "$ARGV: ".length $1' ... |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
767 # but that would be far less efficient, reading the entire contents |
13209
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
768 # of each file, rather than just the last two bytes of each. |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
769 # |
13209
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
770 # This is a perl script that is expected to be the single-quoted argument |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
771 # to a command-line "-le". The remaining arguments are file names. |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
772 # Print the name of each file that ends in two or more newline bytes. |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
773 # Exit nonzero if at least one such file is found, otherwise, exit 0. |
13209
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
774 # Warn about, but otherwise ignore open failure. Ignore seek/read failure. |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
775 # |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
776 # Use this if you want to remove trailing empty lines from selected files: |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
777 # perl -pi -0777 -e 's/\n\n+$/\n/' files... |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
778 # |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
779 detect_empty_lines_at_EOF_ = \ |
13241
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
780 foreach my $$f (@ARGV) \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
781 { \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
782 open F, "<", $$f or (warn "failed to open $$f: $$!\n"), next; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
783 my $$p = sysseek (F, -2, 2); \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
784 my $$c = "seek failure probably means file has < 2 bytes; ignore"; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
785 my $$last_two_bytes; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
786 defined $$p and $$p = sysread F, $$last_two_bytes, 2; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
787 close F; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
788 $$c = "ignore read failure"; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
789 $$p && $$last_two_bytes eq "\n\n" and (print $$f), $$fail=1; \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
790 } \ |
cf12b14b472b
maint.mk: use gnu-style indentation in an embedded perl script
Jim Meyering <meyering@redhat.com>
parents:
13233
diff
changeset
|
791 END { exit defined $$fail } |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
792 sc_prohibit_empty_lines_at_EOF: |
13209
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
793 @perl -le '$(detect_empty_lines_at_EOF_)' $$($(VC_LIST_EXCEPT)) \ |
473dffe238d2
maint.mk: improve empty-line-at-EOF check
Jim Meyering <meyering@redhat.com>
parents:
13208
diff
changeset
|
794 || { echo '$(ME): the above files end with empty line(s)' \ |
13203
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
795 1>&2; exit 1; } || :; \ |
0f51b742ab58
maint.mk: new syntax-check rule: prohibit empty lines at end of file
Jim Meyering <meyering@redhat.com>
parents:
13202
diff
changeset
|
796 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
797 # Make sure we don't use st_blocks. Use ST_NBLOCKS instead. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
798 # This is a bit of a kludge, since it prevents use of the string |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
799 # even in comments, but for now it does the job with no false positives. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
800 sc_prohibit_stat_st_blocks: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
801 @prohibit='[.>]st_blocks' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
802 halt='do not use st_blocks; use ST_NBLOCKS' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
803 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
804 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
805 # Make sure we don't define any S_IS* macros in src/*.c files. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
806 # They're already defined via gnulib's sys/stat.h replacement. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
807 sc_prohibit_S_IS_definition: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
808 @prohibit='^ *# *define *S_IS' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
809 halt='do not define S_IS* macros; include <sys/stat.h>' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
810 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
811 |
13085
fb5165836aea
maint.mk: prohibit use of test's -o and -a operators
Jim Meyering <meyering@redhat.com>
parents:
13058
diff
changeset
|
812 _ptm1 = use "test C1 && test C2", not "test C1 -''a C2" |
fb5165836aea
maint.mk: prohibit use of test's -o and -a operators
Jim Meyering <meyering@redhat.com>
parents:
13058
diff
changeset
|
813 _ptm2 = use "test C1 || test C2", not "test C1 -''o C2" |
fb5165836aea
maint.mk: prohibit use of test's -o and -a operators
Jim Meyering <meyering@redhat.com>
parents:
13058
diff
changeset
|
814 # Using test's -a and -o operators is not portable. |
13101
8dad7d30953c
maint.mk: check for [ as well as test
Eric Blake <eblake@redhat.com>
parents:
13098
diff
changeset
|
815 # We prefer test over [, since the latter is spelled [[ in configure.ac. |
13085
fb5165836aea
maint.mk: prohibit use of test's -o and -a operators
Jim Meyering <meyering@redhat.com>
parents:
13058
diff
changeset
|
816 sc_prohibit_test_minus_ao: |
13104
3f4bdc04f3f1
maint.mk: fix some fallout
Eric Blake <eblake@redhat.com>
parents:
13103
diff
changeset
|
817 @prohibit='(\<test| \[+) .+ -[ao] ' \ |
3f4bdc04f3f1
maint.mk: fix some fallout
Eric Blake <eblake@redhat.com>
parents:
13103
diff
changeset
|
818 halt='$(_ptm1); $(_ptm2)' \ |
3f4bdc04f3f1
maint.mk: fix some fallout
Eric Blake <eblake@redhat.com>
parents:
13103
diff
changeset
|
819 $(_sc_search_regexp) |
13085
fb5165836aea
maint.mk: prohibit use of test's -o and -a operators
Jim Meyering <meyering@redhat.com>
parents:
13058
diff
changeset
|
820 |
13855
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
821 # Avoid a test bashism. |
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
822 sc_prohibit_test_double_equal: |
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
823 @prohibit='(\<test| \[+) .+ == ' \ |
13865
85922ab33c1c
maintainer-makefile: cover a few more files
Eric Blake <eblake@redhat.com>
parents:
13858
diff
changeset
|
824 containing='#! */bin/[a-z]*sh' \ |
13855
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
825 halt='use "test x = x", not "test x =''= x"' \ |
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
826 $(_sc_search_regexp) |
78d646edb95c
maintainer-makefile: prohibit test x == x
Eric Blake <eblake@redhat.com>
parents:
13853
diff
changeset
|
827 |
12608
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
828 # Each program that uses proper_name_utf8 must link with one of the |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
829 # ICONV libraries. Otherwise, some ICONV library must appear in LDADD. |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
830 # The perl -0777 invocation below extracts the possibly-multi-line |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
831 # definition of LDADD from the appropriate Makefile.am and exits 0 |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
832 # when it contains "ICONV". |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
833 sc_proper_name_utf8_requires_ICONV: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
834 @progs=$$(grep -l 'proper_name_utf8 ''("' $$($(VC_LIST_EXCEPT)));\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
835 if test "x$$progs" != x; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
836 fail=0; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
837 for p in $$progs; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
838 dir=$$(dirname "$$p"); \ |
12608
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
839 perl -0777 \ |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
840 -ne 'exit !(/^LDADD =(.+?[^\\]\n)/ms && $$1 =~ /ICONV/)' \ |
d2cfa946257a
maint.mk: extend proper_name_utf8-vs-LIBICONV-checking rule
Jim Meyering <meyering@redhat.com>
parents:
12606
diff
changeset
|
841 $$dir/Makefile.am && continue; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
842 base=$$(basename "$$p" .c); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
843 grep "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
844 || { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
845 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
846 test $$fail = 1 && \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
847 { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
848 exit 1; } || :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
849 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
850 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
851 # Warn about "c0nst struct Foo const foo[]", |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
852 # but not about "char const *const foo" or "#define const const". |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
853 sc_redundant_const: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
854 @prohibit='\bconst\b[[:space:][:alnum:]]{2,}\bconst\b' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
855 halt='redundant "const" in declarations' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
856 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
857 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
858 sc_const_long_option: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
859 @grep '^ *static.*struct option ' $$($(VC_LIST_EXCEPT)) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
860 | grep -Ev 'const struct option|struct option const' && { \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
861 echo 1>&2 '$(ME): add "const" to the above declarations'; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
862 exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
863 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
864 NEWS_hash = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
865 $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
866 $(srcdir)/NEWS \ |
12592
f46f6a6b078c
maint.mk: ignore multi-line copyright in NEWS
Eric Blake <ebb9@byu.net>
parents:
12581
diff
changeset
|
867 | perl -0777 -pe \ |
f46f6a6b078c
maint.mk: ignore multi-line copyright in NEWS
Eric Blake <ebb9@byu.net>
parents:
12581
diff
changeset
|
868 's/^Copyright.+?Free\sSoftware\sFoundation,\sInc\.\n//ms' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
869 | md5sum - \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
870 | sed 's/ .*//') |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
871 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
872 # Ensure that we don't accidentally insert an entry into an old NEWS block. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
873 sc_immutable_NEWS: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
874 @if test -f $(srcdir)/NEWS; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
875 test "$(NEWS_hash)" = '$(old_NEWS_hash)' && : || \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
876 { echo '$(ME): you have modified old NEWS' 1>&2; exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
877 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
878 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
879 # Update the hash stored above. Do this after each release and |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
880 # for any corrections to old entries. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
881 update-NEWS-hash: NEWS |
11750
246d2e2f523d
maint.mk: relax update-NEWS-hash to accept more syntax
Peter Simons <simons@cryp.to>
parents:
11736
diff
changeset
|
882 perl -pi -e 's/^(old_NEWS_hash[ \t]+:?=[ \t]+).*/$${1}'"$(NEWS_hash)/" \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
883 $(srcdir)/cfg.mk |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
884 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
885 # Ensure that we use only the standard $(VAR) notation, |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
886 # not @...@ in Makefile.am, now that we can rely on automake |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
887 # to emit a definition for each substituted variable. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
888 # We use perl rather than "grep -nE ..." to exempt a single |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
889 # use of an @...@-delimited variable name in src/Makefile.am. |
12606
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
890 # Allow the package to add exceptions via a hook in cfg.mk; |
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
891 # for example, @PRAGMA_SYSTEM_HEADER@ can be permitted by |
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
892 # setting this to ' && !/PRAGMA_SYSTEM_HEADER/'. |
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
893 _makefile_at_at_check_exceptions ?= |
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
894 sc_makefile_at_at_check: |
47c45341eca0
maint.mk: allow packages to add makefile @@ exceptions
Eric Blake <ebb9@byu.net>
parents:
12593
diff
changeset
|
895 @perl -ne '/\@[A-Z_0-9]+\@/'$(_makefile_at_at_check_exceptions) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
896 -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
897 $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$') \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
898 && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
899 |
12384
8620ff59758a
maint.mk: news-check: use grep -E
Jim Meyering <meyering@redhat.com>
parents:
12383
diff
changeset
|
900 news-check: NEWS |
13393
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
901 if sed -n $(news-check-lines-spec)p $(srcdir)/NEWS \ |
50e9a2259a7d
maint.mk: make the news-check rule more configurable
Peter Simons <simons@cryp.to>
parents:
13378
diff
changeset
|
902 | grep -E $(news-check-regexp) >/dev/null; then \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
903 :; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
904 else \ |
12384
8620ff59758a
maint.mk: news-check: use grep -E
Jim Meyering <meyering@redhat.com>
parents:
12383
diff
changeset
|
905 echo 'NEWS: $$(news-check-regexp) failed to match' 1>&2; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
906 exit 1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
907 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
908 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
909 sc_makefile_TAB_only_indentation: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
910 @prohibit='^ [ ]{8}' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
911 in_vc_files='akefile|\.mk$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
912 halt='found TAB-8-space indentation' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
913 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
914 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
915 sc_m4_quote_check: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
916 @prohibit='(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
917 in_vc_files='(^configure\.ac|\.m4)$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
918 halt='quote the first arg to AC_DEF*' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
919 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
920 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
921 fix_po_file_diag = \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
922 'you have changed the set of files with translatable diagnostics;\n\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
923 apply the above patch\n' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
924 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
925 # Verify that all source files using _() are listed in po/POTFILES.in. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
926 po_file = po/POTFILES.in |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
927 sc_po_check: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
928 @if test -f $(po_file); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
929 grep -E -v '^(#|$$)' $(po_file) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
930 | grep -v '^src/false\.c$$' | sort > $@-1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
931 files=; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
932 for file in $$($(VC_LIST_EXCEPT)) lib/*.[ch]; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
933 test -r $$file || continue; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
934 case $$file in \ |
11710
e59c94826772
maint.mk: don't look for translatable strings in *.m4 or *.mk
Jim Meyering <meyering@redhat.com>
parents:
11646
diff
changeset
|
935 *.m4|*.mk) continue ;; \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
936 *.?|*.??) ;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
937 *) continue;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
938 esac; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
939 case $$file in \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
940 *.[ch]) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
941 base=`expr " $$file" : ' \(.*\)\..'`; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
942 { test -f $$base.l || test -f $$base.y; } && continue;; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
943 esac; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
944 files="$$files $$file"; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
945 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
946 grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
947 | sort -u > $@-2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
948 diff -u -L $(po_file) -L $(po_file) $@-1 $@-2 \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
949 || { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
950 rm -f $@-1 $@-2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
951 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
952 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
953 # Sometimes it is useful to change the PATH environment variable |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
954 # in Makefiles. When doing so, it's better not to use the Unix-centric |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
955 # path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
956 msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
957 sc_makefile_path_separator_check: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
958 @prohibit='PATH[=].*:' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
959 in_vc_files='akefile|\.mk$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
960 halt=$(msg) \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
961 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
962 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
963 # Check that `make alpha' will not fail at the end of the process. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
964 writable-files: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
965 if test -d $(release_archive_dir); then :; else \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
966 for file in $(distdir).tar.gz \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
967 $(release_archive_dir)/$(distdir).tar.gz; do \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
968 test -e $$file || continue; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
969 test -w $$file \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
970 || { echo ERROR: $$file is not writable; fail=1; }; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
971 done; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
972 test "$$fail" && exit 1 || : ; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
973 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
974 |
13635
102e01a1ca93
maint.mk: avoid obscure sc_copyright_check failure in coreutils
Jim Meyering <meyering@redhat.com>
parents:
13393
diff
changeset
|
975 v_etc_file = $(gnulib_dir)/lib/version-etc.c |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
976 sample-test = tests/sample-test |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
977 texi = doc/$(PACKAGE).texi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
978 # Make sure that the copyright date in $(v_etc_file) is up to date. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
979 # Do the same for the $(sample-test) and the main doc/.texi file. |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
980 sc_copyright_check: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
981 @require='enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
982 in_files=$(v_etc_file) \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
983 halt='out of date copyright in $(v_etc_file); update it' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
984 $(_sc_search_regexp) |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
985 @require='# Copyright \(C\) '$$(date +%Y)' Free' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
986 in_vc_files=$(sample-test) \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
987 halt='out of date copyright in $(sample-test); update it' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
988 $(_sc_search_regexp) |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
989 @require='Copyright @copyright\{\} .*'$$(date +%Y)' Free' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
990 in_vc_files=$(texi) \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
991 halt='out of date copyright in $(texi); update it' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
992 $(_sc_search_regexp) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
993 |
13185
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
994 # If tests/help-version exists and seems to be new enough, assume that its |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
995 # use of init.sh and path_prepend_ is correct, and ensure that every other |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
996 # use of init.sh is identical. |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
997 # This is useful because help-version cross-checks prog --version |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
998 # with $(VERSION), which verifies that its path_prepend_ invocation |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
999 # sets PATH correctly. This is an inexpensive way to ensure that |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
1000 # the other init.sh-using tests also get it right. |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
1001 _hv_file ?= $(srcdir)/tests/help-version |
13331
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1002 _hv_regex_weak ?= ^ *\. .*/init\.sh" |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1003 _hv_regex_strong ?= ^ *\. "\$${srcdir=\.}/init\.sh" |
13185
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
1004 sc_cross_check_PATH_usage_in_tests: |
13192
ba35e9647b3b
maint.mk: print better diagnostic when there is no $(_hv_file)
Jim Meyering <meyering@redhat.com>
parents:
13185
diff
changeset
|
1005 @if test -f $(_hv_file); then \ |
13331
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1006 grep -l 'VERSION mismatch' $(_hv_file) >/dev/null \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1007 || { echo "$@: skipped: no such file: $(_hv_file)" 1>&2; \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1008 exit 0; }; \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1009 grep -lE '$(_hv_regex_strong)' $(_hv_file) >/dev/null \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1010 || { echo "$@: $(_hv_file) lacks conforming use of init.sh" 1>&2; \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1011 exit 1; }; \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1012 good=$$(grep -E '$(_hv_regex_strong)' $(_hv_file)); \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1013 grep -LFx "$$good" \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1014 $$(grep -lE '$(_hv_regex_weak)' $$($(VC_LIST_EXCEPT))) \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1015 | grep . && \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1016 { echo "$(ME): the above files use path_prepend_ inconsistently" \ |
dc2c7e3048ec
maint.mk: improve sc_cross_check_PATH_usage_in_tests
Jim Meyering <meyering@redhat.com>
parents:
13329
diff
changeset
|
1017 1>&2; exit 1; } || :; \ |
13185
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
1018 fi |
8845faccc61b
maint.mk: add a PATH crosschecking syntax-check rule
Jim Meyering <meyering@redhat.com>
parents:
13126
diff
changeset
|
1019 |
12816
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1020 # #if HAVE_... will evaluate to false for any non numeric string. |
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1021 # That would be flagged by using -Wundef, however gnulib currently |
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1022 # tests many undefined macros, and so we can't enable that option. |
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1023 # So at least preclude common boolean strings as macro values. |
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1024 sc_Wundef_boolean: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1025 @prohibit='^#define.*(yes|no|true|false)$$' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1026 in_files='$(CONFIG_INCLUDE)' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1027 halt='Use 0 or 1 for macro values' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1028 $(_sc_search_regexp) |
12816
7a4d2814715b
syntax-check: detect incorrect boolean macro values in config.h
Pádraig Brady <P@draigBrady.com>
parents:
12773
diff
changeset
|
1029 |
12827
d844fd639561
maint: add a syntax-check rule to check for vulnerable Makefile.in
Jim Meyering <meyering@redhat.com>
parents:
12816
diff
changeset
|
1030 sc_vulnerable_makefile_CVE-2009-4029: |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1031 @prohibit='perm -777 -exec chmod a\+rwx|chmod 777 \$$\(distdir\)' \ |
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1032 in_files=$$(find $(srcdir) -name Makefile.in) \ |
13704
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
1033 halt=$$(printf '%s\n' \ |
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
1034 'the above files are vulnerable; beware of running' \ |
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
1035 ' "make dist*" rules, and upgrade to fixed automake' \ |
fe063c25c0ce
maint.mk: avoid unexpanded \n in two diagnostics
Jim Meyering <meyering@redhat.com>
parents:
13635
diff
changeset
|
1036 ' see http://bugzilla.redhat.com/542609 for details') \ |
13103
3622812c3a89
maint.mk: _sc_search_regexp: generalize and rename from _prohibit_regexp
Jose E. Marchesi <jemarch@gnu.org>
parents:
13102
diff
changeset
|
1037 $(_sc_search_regexp) |
12827
d844fd639561
maint: add a syntax-check rule to check for vulnerable Makefile.in
Jim Meyering <meyering@redhat.com>
parents:
12816
diff
changeset
|
1038 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1039 vc-diff-check: |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
1040 (unset CDPATH; cd $(srcdir) && $(VC) diff) > vc-diffs || : |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1041 if test -s vc-diffs; then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1042 cat vc-diffs; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1043 echo "Some files are locally modified:" 1>&2; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1044 exit 1; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1045 else \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1046 rm vc-diffs; \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1047 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1048 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1049 rel-files = $(DIST_ARCHIVES) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1050 |
11575
cfe435cf936c
maint.mk: allow gnulib_dir in VPATH build
Eric Blake <ebb9@byu.net>
parents:
11573
diff
changeset
|
1051 gnulib_dir ?= $(srcdir)/gnulib |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1052 gnulib-version = $$(cd $(gnulib_dir) && git describe) |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
1053 bootstrap-tools ?= autoconf,automake,gnulib |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1054 |
12539
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1055 # If it's not already specified, derive the GPG key ID from |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1056 # the signed tag we've just applied to mark this release. |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1057 gpg_key_ID ?= \ |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1058 $$(git cat-file tag v$(VERSION) > .ann-sig \ |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1059 && gpgv .ann-sig - < /dev/null 2>&1 \ |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1060 | sed -n '/.*key ID \([0-9A-F]*\)/s//\1/p'; rm -f .ann-sig) |
dafd055586ef
maint.mk: don't require explicit gpg_key_ID in cfg.mk
Jim Meyering <meyering@redhat.com>
parents:
12538
diff
changeset
|
1061 |
13306
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1062 translation_project_ ?= coordinator@translationproject.org |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1063 announcement_Cc_ ?= $(translation_project_), $(PACKAGE_BUGREPORT) |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1064 announcement_mail_headers_ ?= \ |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1065 To: info-gnu@gnu.org \ |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1066 Cc: $(announcement_Cc_) \ |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1067 Mail-Followup-To: $(PACKAGE_BUGREPORT) |
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1068 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1069 announcement: NEWS ChangeLog $(rel-files) |
11564
ab18b3d5e34a
* top/maint.mk: Adjust backslash alignment.
Jim Meyering <meyering@redhat.com>
parents:
11563
diff
changeset
|
1070 @$(build_aux)/announce-gen \ |
13306
3b72fc82a799
maint.mk, announce-gen: allow project-specific announcement mail headers
Jim Meyering <meyering@redhat.com>
parents:
13304
diff
changeset
|
1071 --mail-headers='$(announcement_mail_headers_)' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1072 --release-type=$(RELEASE_TYPE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1073 --package=$(PACKAGE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1074 --prev=$(PREV_VERSION) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1075 --curr=$(VERSION) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1076 --gpg-key-id=$(gpg_key_ID) \ |
12581
25232b487199
maint: support 'make announcement' from a VPATH build
Eric Blake <ebb9@byu.net>
parents:
12576
diff
changeset
|
1077 --news=$(srcdir)/NEWS \ |
11501
5223ecd9ec17
maint.mk: import improvements from m4
Eric Blake <ebb9@byu.net>
parents:
11500
diff
changeset
|
1078 --bootstrap-tools=$(bootstrap-tools) \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1079 --gnulib-version=$(gnulib-version) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1080 --no-print-checksums \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1081 $(addprefix --url-dir=, $(url_dir_list)) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1082 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1083 ## ---------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1084 ## Updating files. ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1085 ## ---------------- ## |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1086 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1087 ftp-gnu = ftp://ftp.gnu.org/gnu |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1088 www-gnu = http://www.gnu.org |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1089 |
12864
9ab78f8f0368
maint.mk: allow the default upload destination dir to be overridden
Jim Meyering <meyering@redhat.com>
parents:
12863
diff
changeset
|
1090 upload_dest_dir_ ?= $(PACKAGE) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1091 emit_upload_commands: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1092 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1093 @echo ===================================== |
11563
861b812ba15f
top/maint.mk: Make $(srcdir)/build-aux configurable.
Simon Josefsson <simon@josefsson.org>
parents:
11547
diff
changeset
|
1094 @echo "$(build_aux)/gnupload $(GNUPLOADFLAGS) \\" |
12864
9ab78f8f0368
maint.mk: allow the default upload destination dir to be overridden
Jim Meyering <meyering@redhat.com>
parents:
12863
diff
changeset
|
1095 @echo " --to $(gnu_rel_host):$(upload_dest_dir_) \\" |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1096 @echo " $(rel-files)" |
12538
a8059f620e8f
maint.mk: create announcement template in ~/, not in /tmp
Jim Meyering <meyering@redhat.com>
parents:
12443
diff
changeset
|
1097 @echo '# send the ~/announce-$(my_distdir) e-mail' |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1098 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1099 @echo ===================================== |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1100 |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1101 define emit-commit-log |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1102 printf '%s\n' 'post-release administrivia' '' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1103 '* NEWS: Add header line for next release.' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1104 '* .prev-version: Record previous version.' \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1105 '* cfg.mk (old_NEWS_hash): Auto-update.' |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1106 endef |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1107 |
11534
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1108 .PHONY: no-submodule-changes |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1109 no-submodule-changes: |
11547
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
1110 if test -d $(srcdir)/.git; then \ |
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
1111 diff=$$(cd $(srcdir) && git submodule -q foreach \ |
3f43faadaf9d
maint: make the new no-submodule-changes rule VPATH-safe
Eric Blake <ebb9@byu.net>
parents:
11534
diff
changeset
|
1112 git diff-index --name-only HEAD) \ |
11534
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1113 || exit 1; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1114 case $$diff in '') ;; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1115 *) echo '$(ME): submodule files are locally modified:'; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1116 echo "$$diff"; exit 1;; esac; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1117 else \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1118 : ; \ |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1119 fi |
9f608fba8b1c
build: ensure that a release build fails when a submodule is unclean
Jim Meyering <meyering@redhat.com>
parents:
11519
diff
changeset
|
1120 |
14137
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1121 submodule-checks ?= no-submodule-changes public-submodule-commit |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1122 |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1123 # Ensure that each sub-module commit we're using is public. |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1124 # Without this, it is too easy to tag and release code that |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1125 # cannot be built from a fresh clone. |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1126 .PHONY: public-submodule-commit |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1127 public-submodule-commit: |
14190
6699cf2b13db
maint.mk: improve the public-submodule-commit rule
Jim Meyering <meyering@redhat.com>
parents:
14140
diff
changeset
|
1128 $(AM_V_GEN)if test -d $(srcdir)/.git; then \ |
6699cf2b13db
maint.mk: improve the public-submodule-commit rule
Jim Meyering <meyering@redhat.com>
parents:
14140
diff
changeset
|
1129 cd $(srcdir) && \ |
6699cf2b13db
maint.mk: improve the public-submodule-commit rule
Jim Meyering <meyering@redhat.com>
parents:
14140
diff
changeset
|
1130 git submodule --quiet foreach 'test $$(git rev-parse origin)' \ |
14137
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1131 = '"$$(git merge-base --independent origin $$sha1)"' \ |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1132 || { echo '$(ME): found non-public submodule commit' >&2; \ |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1133 exit 1; }; \ |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1134 else \ |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1135 : ; \ |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1136 fi |
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1137 |
12083
b7b81ca175f4
maint.mk: requiring "make major" was annoying, for a "minor" release.
Jim Meyering <meyering@redhat.com>
parents:
12035
diff
changeset
|
1138 .PHONY: alpha beta stable |
b7b81ca175f4
maint.mk: requiring "make major" was annoying, for a "minor" release.
Jim Meyering <meyering@redhat.com>
parents:
12035
diff
changeset
|
1139 ALL_RECURSIVE_TARGETS += alpha beta stable |
14137
2dbfa19b11d0
maint.mk: add pre-release check to ensure submodule commits are public
Eric Blake <eblake@redhat.com>
parents:
14079
diff
changeset
|
1140 alpha beta stable: $(local-check) writable-files $(submodule-checks) |
12083
b7b81ca175f4
maint.mk: requiring "make major" was annoying, for a "minor" release.
Jim Meyering <meyering@redhat.com>
parents:
12035
diff
changeset
|
1141 test $@ = stable \ |
b7b81ca175f4
maint.mk: requiring "make major" was annoying, for a "minor" release.
Jim Meyering <meyering@redhat.com>
parents:
12035
diff
changeset
|
1142 && { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1143 || { echo "invalid version string: $(VERSION)" 1>&2; exit 1;};}\ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1144 || : |
11909
2cd9af4a1b6a
maint.mk: remove more coreutils-specific targets; XZ_OPT=-9ev
Jim Meyering <meyering@redhat.com>
parents:
11853
diff
changeset
|
1145 $(MAKE) vc-diff-check |
12384
8620ff59758a
maint.mk: news-check: use grep -E
Jim Meyering <meyering@redhat.com>
parents:
12383
diff
changeset
|
1146 $(MAKE) news-check |
11909
2cd9af4a1b6a
maint.mk: remove more coreutils-specific targets; XZ_OPT=-9ev
Jim Meyering <meyering@redhat.com>
parents:
11853
diff
changeset
|
1147 $(MAKE) distcheck |
2cd9af4a1b6a
maint.mk: remove more coreutils-specific targets; XZ_OPT=-9ev
Jim Meyering <meyering@redhat.com>
parents:
11853
diff
changeset
|
1148 $(MAKE) dist XZ_OPT=-9ev |
12443
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1149 $(MAKE) $(release-prep-hook) RELEASE_TYPE=$@ |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1150 $(MAKE) -s emit_upload_commands RELEASE_TYPE=$@ |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1151 |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1152 # Override this in cfg.mk if you follow different procedures. |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1153 release-prep-hook ?= release-prep |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1154 |
13871
8c865631b168
maint.mk: rename variable: s/noteworthy/gl_noteworthy_news_/
Jim Meyering <meyering@redhat.com>
parents:
13865
diff
changeset
|
1155 gl_noteworthy_news_ = * Noteworthy changes in release ?.? (????-??-??) [?] |
12443
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1156 .PHONY: release-prep |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1157 release-prep: |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1158 case $$RELEASE_TYPE in alpha|beta|stable) ;; \ |
3a97f22a64eb
maint.mk: allow a project to override release-prep commands
Alfred M. Szmidt <ams@gnu.org>
parents:
12441
diff
changeset
|
1159 *) echo "invalid RELEASE_TYPE: $$RELEASE_TYPE" 1>&2; exit 1;; esac |
12538
a8059f620e8f
maint.mk: create announcement template in ~/, not in /tmp
Jim Meyering <meyering@redhat.com>
parents:
12443
diff
changeset
|
1160 $(MAKE) -s announcement > ~/announce-$(my_distdir) |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1161 if test -d $(release_archive_dir); then \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1162 ln $(rel-files) $(release_archive_dir); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1163 chmod a-w $(rel-files); \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1164 fi |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1165 echo $(VERSION) > $(prev_version_file) |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1166 $(MAKE) update-NEWS-hash |
13871
8c865631b168
maint.mk: rename variable: s/noteworthy/gl_noteworthy_news_/
Jim Meyering <meyering@redhat.com>
parents:
13865
diff
changeset
|
1167 perl -pi -e '$$. == 3 and print "$(gl_noteworthy_news_)\n\n\n"' NEWS |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1168 $(emit-commit-log) > .ci-msg |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1169 $(VC) commit -F .ci-msg -a |
12538
a8059f620e8f
maint.mk: create announcement template in ~/, not in /tmp
Jim Meyering <meyering@redhat.com>
parents:
12443
diff
changeset
|
1170 rm .ci-msg |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1171 |
13309
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1172 # Override this with e.g., -s $(srcdir)/some_other_name.texi |
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1173 # if the default $(PACKAGE)-derived name doesn't apply. |
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1174 gendocs_options_ ?= |
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1175 |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1176 .PHONY: web-manual |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1177 web-manual: |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1178 @test -z "$(manual_title)" \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1179 && { echo define manual_title in cfg.mk 1>&2; exit 1; } || : |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1180 @cd '$(srcdir)/doc'; \ |
13309
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1181 $(SHELL) ../build-aux/gendocs.sh $(gendocs_options_) \ |
eeb72cb4f562
maint.mk: allow to pass options to gendocs.sh
Jim Meyering <meyering@redhat.com>
parents:
13306
diff
changeset
|
1182 -o '$(abs_builddir)/doc/manual' \ |
11495
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1183 --email $(PACKAGE_BUGREPORT) $(PACKAGE) \ |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1184 "$(PACKAGE_NAME) - $(manual_title)" |
d88c5ec9288d
Sync maint.mk with coreutils.
Simon Josefsson <simon@josefsson.org>
parents:
11484
diff
changeset
|
1185 @echo " *** Upload the doc/manual directory to web-cvs." |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1186 |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1187 # Code Coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1188 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1189 init-coverage: |
11406
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
1190 $(MAKE) $(AM_MAKEFLAGS) clean |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1191 lcov --directory . --zerocounters |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1192 |
10757
0affc3e42aa9
maint.mk: Use --coverage.
Simon Josefsson <simon@josefsson.org>
parents:
10738
diff
changeset
|
1193 COVERAGE_CCOPTS ?= "-g --coverage" |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1194 COVERAGE_OUT ?= doc/coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1195 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1196 build-coverage: |
11406
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
1197 $(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS) |
ae9bcb808cfd
maint.mk: really add $(AM_MAKEFLAGS)
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
parents:
11405
diff
changeset
|
1198 $(MAKE) $(AM_MAKEFLAGS) CFLAGS=$(COVERAGE_CCOPTS) CXXFLAGS=$(COVERAGE_CCOPTS) check |
10738
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1199 mkdir -p $(COVERAGE_OUT) |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1200 lcov --directory . --output-file $(COVERAGE_OUT)/$(PACKAGE).info \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1201 --capture |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1202 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1203 gen-coverage: |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1204 genhtml --output-directory $(COVERAGE_OUT) \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1205 $(COVERAGE_OUT)/$(PACKAGE).info \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1206 --highlight --frames --legend \ |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1207 --title "$(PACKAGE_NAME)" |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1208 |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1209 coverage: init-coverage build-coverage gen-coverage |
af888e12d10d
top/maint.mk: Add coverage rules, inspired by scripts in gnupdf.
Simon Josefsson <simon@josefsson.org>
parents:
10368
diff
changeset
|
1210 |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1211 # Update gettext files. |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1212 PACKAGE ?= $(shell basename $(PWD)) |
11484
489151a3b578
maintainer-makefile: (PO_DOMAIN): New variable, allows overriding of gettext domain.
Simon Josefsson <simon@josefsson.org>
parents:
11468
diff
changeset
|
1213 PO_DOMAIN ?= $(PACKAGE) |
489151a3b578
maintainer-makefile: (PO_DOMAIN): New variable, allows overriding of gettext domain.
Simon Josefsson <simon@josefsson.org>
parents:
11468
diff
changeset
|
1214 POURL = http://translationproject.org/latest/$(PO_DOMAIN)/ |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1215 PODIR ?= po |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1216 refresh-po: |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1217 rm -f $(PODIR)/*.po && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1218 echo "$(ME): getting translations into po (please ignore the robots.txt ERROR 404)..." && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1219 wget --no-verbose --directory-prefix $(PODIR) --no-directories --recursive --level 1 --accept .po --accept .po.1 $(POURL) && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1220 echo 'en@boldquot' > $(PODIR)/LINGUAS && \ |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1221 echo 'en@quot' >> $(PODIR)/LINGUAS && \ |
10828
45b8dcc40064
maintainer-makefile: Fix sed regexp.
Simon Josefsson <simon@josefsson.org>
parents:
10757
diff
changeset
|
1222 ls $(PODIR)/*.po | sed 's/\.po//' | sed 's,$(PODIR)/,,' | sort >> $(PODIR)/LINGUAS |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1223 |
13286
bacd8565eeaa
top/maint.mk (indent): Run twice to produce idempotent results.
Simon Josefsson <simon@josefsson.org>
parents:
13278
diff
changeset
|
1224 # Running indent once is not idempotent, but running it twice is. |
9811
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1225 INDENT_SOURCES ?= $(C_SOURCES) |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1226 .PHONY: indent |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1227 indent: |
5f79eb63c21e
Alter GNUmakefile to install into top directory.
Eric Blake <ebb9@byu.net>
parents:
diff
changeset
|
1228 indent $(INDENT_SOURCES) |
13286
bacd8565eeaa
top/maint.mk (indent): Run twice to produce idempotent results.
Simon Josefsson <simon@josefsson.org>
parents:
13278
diff
changeset
|
1229 indent $(INDENT_SOURCES) |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
1230 |
11834
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
1231 # If you want to set UPDATE_COPYRIGHT_* environment variables, |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
1232 # put the assignments in this variable. |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
1233 update-copyright-env ?= |
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
1234 |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
1235 # Run this rule once per year (usually early in January) |
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
1236 # to update all FSF copyright year lists in your project. |
11836
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1237 # If you have an additional project-specific rule, |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1238 # add it in cfg.mk along with a line 'update-copyright: prereq'. |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1239 # By default, exclude all variants of COPYING; you can also |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1240 # add exemptions (such as ChangeLog..* for rotated change logs) |
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1241 # in the file .x-update-copyright. |
11776
9deb84e458cb
maint.mk: add a copyright-updating rule
Jim Meyering <meyering@redhat.com>
parents:
11750
diff
changeset
|
1242 .PHONY: update-copyright |
11836
4103ca3d0881
maint.mk: simplify update-copyright rule
Eric Blake <ebb9@byu.net>
parents:
11834
diff
changeset
|
1243 update-copyright: |
11847
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
1244 grep -l -w Copyright \ |
5dd8e8cf05db
maint.mk: give full control over update-copyright exclusions
Joel E. Denny <jdenny@clemson.edu>
parents:
11836
diff
changeset
|
1245 $$(export VC_LIST_EXCEPT_DEFAULT=COPYING && $(VC_LIST_EXCEPT)) \ |
11834
5c2855361aa1
maint.mk: support update-copyright-env
Joel E. Denny <jdenny@clemson.edu>
parents:
11788
diff
changeset
|
1246 | $(update-copyright-env) xargs $(build_aux)/$@ |